diff options
author | Al Viro <viro@www.linux.org.uk> | 2005-04-25 10:55:57 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-04-25 10:55:57 -0400 |
commit | 92a11f9e7cb876e6cf9080e4a1642142cb9221b2 (patch) | |
tree | be7957195d3f013327b45add983e5106356286e0 | |
parent | 9090e001f28de4bccae232f1b78e78fad5132ecb (diff) |
[PATCH] ppc iomem annotations: ->io_base_virt
* ->io_base_virt in struct pci_controller is iomem pointer. Marked as such.
Most of the places that used it are already annotated to expect iomem.
* places that did gratitious (and wrong) casts a-la
isa_io_base = (unsigned long)ioremap(...);
hose->io_base_virt = (void *)isa_io_base;
turned into
hose->io_base_virt = ioremap(...);
isa_io_base = (unsigned long)hose->io_base_virt;
* pci_bus_io_base() annotated as returning iomem pointer.
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | arch/ppc/kernel/pci.c | 2 | ||||
-rw-r--r-- | arch/ppc/platforms/4xx/ebony.c | 5 | ||||
-rw-r--r-- | arch/ppc/platforms/4xx/luan.c | 5 | ||||
-rw-r--r-- | arch/ppc/platforms/4xx/ocotea.c | 5 | ||||
-rw-r--r-- | arch/ppc/syslib/m8260_pci.c | 5 | ||||
-rw-r--r-- | arch/ppc/syslib/mpc52xx_pci.c | 8 | ||||
-rw-r--r-- | arch/ppc/syslib/ppc85xx_setup.c | 12 | ||||
-rw-r--r-- | include/asm-ppc/pci-bridge.h | 4 |
8 files changed, 19 insertions, 27 deletions
diff --git a/arch/ppc/kernel/pci.c b/arch/ppc/kernel/pci.c index 98f94b60204c..47a15306823a 100644 --- a/arch/ppc/kernel/pci.c +++ b/arch/ppc/kernel/pci.c | |||
@@ -1432,7 +1432,7 @@ pci_bus_to_hose(int bus) | |||
1432 | return NULL; | 1432 | return NULL; |
1433 | } | 1433 | } |
1434 | 1434 | ||
1435 | void* | 1435 | void __iomem * |
1436 | pci_bus_io_base(unsigned int bus) | 1436 | pci_bus_io_base(unsigned int bus) |
1437 | { | 1437 | { |
1438 | struct pci_controller *hose; | 1438 | struct pci_controller *hose; |
diff --git a/arch/ppc/platforms/4xx/ebony.c b/arch/ppc/platforms/4xx/ebony.c index f63bca83e757..55120c317f7d 100644 --- a/arch/ppc/platforms/4xx/ebony.c +++ b/arch/ppc/platforms/4xx/ebony.c | |||
@@ -210,9 +210,8 @@ ebony_setup_hose(void) | |||
210 | hose->io_space.end = EBONY_PCI_UPPER_IO; | 210 | hose->io_space.end = EBONY_PCI_UPPER_IO; |
211 | hose->mem_space.start = EBONY_PCI_LOWER_MEM; | 211 | hose->mem_space.start = EBONY_PCI_LOWER_MEM; |
212 | hose->mem_space.end = EBONY_PCI_UPPER_MEM; | 212 | hose->mem_space.end = EBONY_PCI_UPPER_MEM; |
213 | isa_io_base = | 213 | hose->io_base_virt = ioremap64(EBONY_PCI_IO_BASE, EBONY_PCI_IO_SIZE); |
214 | (unsigned long)ioremap64(EBONY_PCI_IO_BASE, EBONY_PCI_IO_SIZE); | 214 | isa_io_base = (unsigned long)hose->io_base_virt; |
215 | hose->io_base_virt = (void *)isa_io_base; | ||
216 | 215 | ||
217 | setup_indirect_pci(hose, | 216 | setup_indirect_pci(hose, |
218 | EBONY_PCI_CFGA_PLB32, | 217 | EBONY_PCI_CFGA_PLB32, |
diff --git a/arch/ppc/platforms/4xx/luan.c b/arch/ppc/platforms/4xx/luan.c index 1df2339f1f6c..95359f748e7b 100644 --- a/arch/ppc/platforms/4xx/luan.c +++ b/arch/ppc/platforms/4xx/luan.c | |||
@@ -223,9 +223,8 @@ luan_setup_hose(struct pci_controller *hose, | |||
223 | hose->io_space.end = LUAN_PCIX_UPPER_IO; | 223 | hose->io_space.end = LUAN_PCIX_UPPER_IO; |
224 | hose->mem_space.start = lower_mem; | 224 | hose->mem_space.start = lower_mem; |
225 | hose->mem_space.end = upper_mem; | 225 | hose->mem_space.end = upper_mem; |
226 | isa_io_base = | 226 | hose->io_base_virt = ioremap64(pcix_io_base, PCIX_IO_SIZE); |
227 | (unsigned long)ioremap64(pcix_io_base, PCIX_IO_SIZE); | 227 | isa_io_base = (unsigned long) hose->io_base_virt; |
228 | hose->io_base_virt = (void *)isa_io_base; | ||
229 | 228 | ||
230 | setup_indirect_pci(hose, cfga, cfgd); | 229 | setup_indirect_pci(hose, cfga, cfgd); |
231 | hose->set_cfg_type = 1; | 230 | hose->set_cfg_type = 1; |
diff --git a/arch/ppc/platforms/4xx/ocotea.c b/arch/ppc/platforms/4xx/ocotea.c index 28de707434f1..5f82a6bc7046 100644 --- a/arch/ppc/platforms/4xx/ocotea.c +++ b/arch/ppc/platforms/4xx/ocotea.c | |||
@@ -227,9 +227,8 @@ ocotea_setup_hose(void) | |||
227 | hose->io_space.end = OCOTEA_PCI_UPPER_IO; | 227 | hose->io_space.end = OCOTEA_PCI_UPPER_IO; |
228 | hose->mem_space.start = OCOTEA_PCI_LOWER_MEM; | 228 | hose->mem_space.start = OCOTEA_PCI_LOWER_MEM; |
229 | hose->mem_space.end = OCOTEA_PCI_UPPER_MEM; | 229 | hose->mem_space.end = OCOTEA_PCI_UPPER_MEM; |
230 | isa_io_base = | 230 | hose->io_base_virt = ioremap64(OCOTEA_PCI_IO_BASE, OCOTEA_PCI_IO_SIZE); |
231 | (unsigned long)ioremap64(OCOTEA_PCI_IO_BASE, OCOTEA_PCI_IO_SIZE); | 231 | isa_io_base = (unsigned long) hose->io_base_virt; |
232 | hose->io_base_virt = (void *)isa_io_base; | ||
233 | 232 | ||
234 | setup_indirect_pci(hose, | 233 | setup_indirect_pci(hose, |
235 | OCOTEA_PCI_CFGA_PLB32, | 234 | OCOTEA_PCI_CFGA_PLB32, |
diff --git a/arch/ppc/syslib/m8260_pci.c b/arch/ppc/syslib/m8260_pci.c index bd564fb35ab6..057cc3f8ff37 100644 --- a/arch/ppc/syslib/m8260_pci.c +++ b/arch/ppc/syslib/m8260_pci.c | |||
@@ -171,10 +171,9 @@ void __init m8260_find_bridges(void) | |||
171 | m8260_setup_pci(hose); | 171 | m8260_setup_pci(hose); |
172 | hose->pci_mem_offset = MPC826x_PCI_MEM_OFFSET; | 172 | hose->pci_mem_offset = MPC826x_PCI_MEM_OFFSET; |
173 | 173 | ||
174 | isa_io_base = | 174 | hose->io_base_virt = ioremap(MPC826x_PCI_IO_BASE, |
175 | (unsigned long) ioremap(MPC826x_PCI_IO_BASE, | ||
176 | MPC826x_PCI_IO_SIZE); | 175 | MPC826x_PCI_IO_SIZE); |
177 | hose->io_base_virt = (void *) isa_io_base; | 176 | isa_io_base = (unsigned long) hose->io_base_virt; |
178 | 177 | ||
179 | /* setup resources */ | 178 | /* setup resources */ |
180 | pci_init_resource(&hose->mem_resources[0], | 179 | pci_init_resource(&hose->mem_resources[0], |
diff --git a/arch/ppc/syslib/mpc52xx_pci.c b/arch/ppc/syslib/mpc52xx_pci.c index c723efd954a6..59cf3e8bd1a0 100644 --- a/arch/ppc/syslib/mpc52xx_pci.c +++ b/arch/ppc/syslib/mpc52xx_pci.c | |||
@@ -205,13 +205,11 @@ mpc52xx_find_bridges(void) | |||
205 | 205 | ||
206 | hose->pci_mem_offset = MPC52xx_PCI_MEM_OFFSET; | 206 | hose->pci_mem_offset = MPC52xx_PCI_MEM_OFFSET; |
207 | 207 | ||
208 | isa_io_base = | 208 | hose->io_base_virt = ioremap(MPC52xx_PCI_IO_BASE, MPC52xx_PCI_IO_SIZE); |
209 | (unsigned long) ioremap(MPC52xx_PCI_IO_BASE, | 209 | isa_io_base = (unsigned long) hose->io_base_virt; |
210 | MPC52xx_PCI_IO_SIZE); | ||
211 | hose->io_base_virt = (void *) isa_io_base; | ||
212 | 210 | ||
213 | hose->cfg_addr = &pci_regs->car; | 211 | hose->cfg_addr = &pci_regs->car; |
214 | hose->cfg_data = (void __iomem *) isa_io_base; | 212 | hose->cfg_data = hose->io_base_virt; |
215 | 213 | ||
216 | /* Setup resources */ | 214 | /* Setup resources */ |
217 | pci_init_resource(&hose->mem_resources[0], | 215 | pci_init_resource(&hose->mem_resources[0], |
diff --git a/arch/ppc/syslib/ppc85xx_setup.c b/arch/ppc/syslib/ppc85xx_setup.c index 81f1968c3269..152c3ef1312a 100644 --- a/arch/ppc/syslib/ppc85xx_setup.c +++ b/arch/ppc/syslib/ppc85xx_setup.c | |||
@@ -280,16 +280,14 @@ mpc85xx_setup_hose(void) | |||
280 | hose_a->io_space.end = MPC85XX_PCI1_UPPER_IO; | 280 | hose_a->io_space.end = MPC85XX_PCI1_UPPER_IO; |
281 | hose_a->io_base_phys = MPC85XX_PCI1_IO_BASE; | 281 | hose_a->io_base_phys = MPC85XX_PCI1_IO_BASE; |
282 | #ifdef CONFIG_85xx_PCI2 | 282 | #ifdef CONFIG_85xx_PCI2 |
283 | isa_io_base = | 283 | hose_a->io_base_virt = ioremap(MPC85XX_PCI1_IO_BASE, |
284 | (unsigned long) ioremap(MPC85XX_PCI1_IO_BASE, | ||
285 | MPC85XX_PCI1_IO_SIZE + | 284 | MPC85XX_PCI1_IO_SIZE + |
286 | MPC85XX_PCI2_IO_SIZE); | 285 | MPC85XX_PCI2_IO_SIZE); |
287 | #else | 286 | #else |
288 | isa_io_base = | 287 | hose_a->io_base_virt = ioremap(MPC85XX_PCI1_IO_BASE, |
289 | (unsigned long) ioremap(MPC85XX_PCI1_IO_BASE, | ||
290 | MPC85XX_PCI1_IO_SIZE); | 288 | MPC85XX_PCI1_IO_SIZE); |
291 | #endif | 289 | #endif |
292 | hose_a->io_base_virt = (void *) isa_io_base; | 290 | isa_io_base = (unsigned long)hose_a->io_base_virt; |
293 | 291 | ||
294 | /* setup resources */ | 292 | /* setup resources */ |
295 | pci_init_resource(&hose_a->mem_resources[0], | 293 | pci_init_resource(&hose_a->mem_resources[0], |
@@ -329,8 +327,8 @@ mpc85xx_setup_hose(void) | |||
329 | hose_b->io_space.start = MPC85XX_PCI2_LOWER_IO; | 327 | hose_b->io_space.start = MPC85XX_PCI2_LOWER_IO; |
330 | hose_b->io_space.end = MPC85XX_PCI2_UPPER_IO; | 328 | hose_b->io_space.end = MPC85XX_PCI2_UPPER_IO; |
331 | hose_b->io_base_phys = MPC85XX_PCI2_IO_BASE; | 329 | hose_b->io_base_phys = MPC85XX_PCI2_IO_BASE; |
332 | hose_b->io_base_virt = (void *) isa_io_base + MPC85XX_PCI1_IO_SIZE; | 330 | hose_b->io_base_virt = hose_a->io_base_virt + MPC85XX_PCI1_IO_SIZE; |
333 | 331 | ||
334 | /* setup resources */ | 332 | /* setup resources */ |
335 | pci_init_resource(&hose_b->mem_resources[0], | 333 | pci_init_resource(&hose_b->mem_resources[0], |
336 | MPC85XX_PCI2_LOWER_MEM, | 334 | MPC85XX_PCI2_LOWER_MEM, |
diff --git a/include/asm-ppc/pci-bridge.h b/include/asm-ppc/pci-bridge.h index 78e9be619f14..ffa423456c2b 100644 --- a/include/asm-ppc/pci-bridge.h +++ b/include/asm-ppc/pci-bridge.h | |||
@@ -12,7 +12,7 @@ struct pci_controller; | |||
12 | * pci_io_base returns the memory address at which you can access | 12 | * pci_io_base returns the memory address at which you can access |
13 | * the I/O space for PCI bus number `bus' (or NULL on error). | 13 | * the I/O space for PCI bus number `bus' (or NULL on error). |
14 | */ | 14 | */ |
15 | extern void *pci_bus_io_base(unsigned int bus); | 15 | extern void __iomem *pci_bus_io_base(unsigned int bus); |
16 | extern unsigned long pci_bus_io_base_phys(unsigned int bus); | 16 | extern unsigned long pci_bus_io_base_phys(unsigned int bus); |
17 | extern unsigned long pci_bus_mem_base_phys(unsigned int bus); | 17 | extern unsigned long pci_bus_mem_base_phys(unsigned int bus); |
18 | 18 | ||
@@ -48,7 +48,7 @@ struct pci_controller { | |||
48 | int last_busno; | 48 | int last_busno; |
49 | int bus_offset; | 49 | int bus_offset; |
50 | 50 | ||
51 | void *io_base_virt; | 51 | void __iomem *io_base_virt; |
52 | unsigned long io_base_phys; | 52 | unsigned long io_base_phys; |
53 | 53 | ||
54 | /* Some machines (PReP) have a non 1:1 mapping of | 54 | /* Some machines (PReP) have a non 1:1 mapping of |