diff options
author | Steven Whitehouse <swhiteho@redhat.com> | 2007-07-10 07:28:27 -0400 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2007-07-10 07:28:27 -0400 |
commit | 3ebf44902f77537b5784eb5059c2b78d8b5a920a (patch) | |
tree | 77290d029e6652ed09bb23c05b8b203bc569cd69 | |
parent | a0a24741cac414aba5918e9939afafa70c37f952 (diff) |
[GFS2] Accept old format NFS filehandles
On Tue, 2007-07-10 at 10:06 +0100, Christoph Hellwig wrote:
> > -#define GFS2_LARGE_FH_SIZE 10
> > -
> > -struct gfs2_fh_obj {
> > - struct gfs2_inum_host this;
> > - u32 imode;
> > -};
> > +#define GFS2_LARGE_FH_SIZE 8
>
> Because gfs2_decode_fh only accepts file handles with GFS2_LARGE_FH_SIZE
> or GFS2_LARGE_FH_SIZE you don't accept filehandles sent out by and older
> gfs version anymore. Stale filehandles because of a new kernel version
> are a big no-no, so please add back code to handle the old filehandles
> on the decode side.
>
This should fix that problem I think since its only relating to end of
the fh we can just ignore that field in order to accept the older
format.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Wendy Cheng <wcheng@redhat.com>
-rw-r--r-- | fs/gfs2/ops_export.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/gfs2/ops_export.c b/fs/gfs2/ops_export.c index e317db2a5548..99ea5659bc2c 100644 --- a/fs/gfs2/ops_export.c +++ b/fs/gfs2/ops_export.c | |||
@@ -28,6 +28,7 @@ | |||
28 | 28 | ||
29 | #define GFS2_SMALL_FH_SIZE 4 | 29 | #define GFS2_SMALL_FH_SIZE 4 |
30 | #define GFS2_LARGE_FH_SIZE 8 | 30 | #define GFS2_LARGE_FH_SIZE 8 |
31 | #define GFS2_OLD_FH_SIZE 10 | ||
31 | 32 | ||
32 | static struct dentry *gfs2_decode_fh(struct super_block *sb, | 33 | static struct dentry *gfs2_decode_fh(struct super_block *sb, |
33 | __u32 *p, | 34 | __u32 *p, |
@@ -44,6 +45,7 @@ static struct dentry *gfs2_decode_fh(struct super_block *sb, | |||
44 | 45 | ||
45 | switch (fh_len) { | 46 | switch (fh_len) { |
46 | case GFS2_LARGE_FH_SIZE: | 47 | case GFS2_LARGE_FH_SIZE: |
48 | case GFS2_OLD_FH_SIZE: | ||
47 | parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32; | 49 | parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32; |
48 | parent.no_formal_ino |= be32_to_cpu(fh[5]); | 50 | parent.no_formal_ino |= be32_to_cpu(fh[5]); |
49 | parent.no_addr = ((u64)be32_to_cpu(fh[6])) << 32; | 51 | parent.no_addr = ((u64)be32_to_cpu(fh[6])) << 32; |