diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-05-18 21:57:27 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-05-18 22:05:18 -0400 |
commit | 8a7ddad8e756a72906851fdd5a6e149cbb056e0d (patch) | |
tree | 3393ed7329a4efb9d853a32991068e0e219e3d56 | |
parent | b448c4b613542c16ad66042017946e68da4e422b (diff) |
perf probe: Don't call die()
Functions that were calling xzalloc also returned -1 when, for other
reasons, it could fail, and the calleds are coping with failures, so
stop using die() and xzalloc().
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-probe.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c index 61c6d70732c9..e4a4da32a568 100644 --- a/tools/perf/builtin-probe.c +++ b/tools/perf/builtin-probe.c | |||
@@ -65,8 +65,10 @@ static int parse_probe_event(const char *str) | |||
65 | int ret; | 65 | int ret; |
66 | 66 | ||
67 | pr_debug("probe-definition(%d): %s\n", params.nevents, str); | 67 | pr_debug("probe-definition(%d): %s\n", params.nevents, str); |
68 | if (++params.nevents == MAX_PROBES) | 68 | if (++params.nevents == MAX_PROBES) { |
69 | die("Too many probes (> %d) are specified.", MAX_PROBES); | 69 | pr_err("Too many probes (> %d) were specified.", MAX_PROBES); |
70 | return -1; | ||
71 | } | ||
70 | 72 | ||
71 | /* Parse a perf-probe command into event */ | 73 | /* Parse a perf-probe command into event */ |
72 | ret = parse_perf_probe_command(str, pev); | 74 | ret = parse_perf_probe_command(str, pev); |
@@ -84,7 +86,9 @@ static int parse_probe_event_argv(int argc, const char **argv) | |||
84 | len = 0; | 86 | len = 0; |
85 | for (i = 0; i < argc; i++) | 87 | for (i = 0; i < argc; i++) |
86 | len += strlen(argv[i]) + 1; | 88 | len += strlen(argv[i]) + 1; |
87 | buf = xzalloc(len + 1); | 89 | buf = zalloc(len + 1); |
90 | if (buf == NULL) | ||
91 | return -ENOMEM; | ||
88 | len = 0; | 92 | len = 0; |
89 | for (i = 0; i < argc; i++) | 93 | for (i = 0; i < argc; i++) |
90 | len += sprintf(&buf[len], "%s ", argv[i]); | 94 | len += sprintf(&buf[len], "%s ", argv[i]); |