diff options
author | Pavel Machek <pavel@ucw.cz> | 2006-03-25 06:07:33 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-25 11:22:55 -0500 |
commit | 36a95bf5cd2c33280282da18eff0180a99cff201 (patch) | |
tree | 1fa365a57f0744218ecf53f162771872c056f70c | |
parent | bd34596239bfff615db7be7812d84c4ff6093f63 (diff) |
[PATCH] fix hardcoded values in collie frontlight
In frontlight support, we should really use values from flash-ROM instead
of hardcoding our own. Cleanup includes.
Signed-off-by: Pavel Machek <pavel@suse.cz>
Acked-by: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/video/backlight/locomolcd.c | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/drivers/video/backlight/locomolcd.c b/drivers/video/backlight/locomolcd.c index ada6e75eb048..60831bb23685 100644 --- a/drivers/video/backlight/locomolcd.c +++ b/drivers/video/backlight/locomolcd.c | |||
@@ -20,14 +20,10 @@ | |||
20 | 20 | ||
21 | #include <asm/hardware/locomo.h> | 21 | #include <asm/hardware/locomo.h> |
22 | #include <asm/irq.h> | 22 | #include <asm/irq.h> |
23 | #include <asm/mach/sharpsl_param.h> | ||
24 | #include <asm/mach-types.h> | ||
23 | 25 | ||
24 | #ifdef CONFIG_SA1100_COLLIE | 26 | #include "../../../arch/arm/mach-sa1100/generic.h" |
25 | #include <asm/arch/collie.h> | ||
26 | #else | ||
27 | #include <asm/arch/poodle.h> | ||
28 | #endif | ||
29 | |||
30 | extern void (*sa1100fb_lcd_power)(int on); | ||
31 | 27 | ||
32 | static struct locomo_dev *locomolcd_dev; | 28 | static struct locomo_dev *locomolcd_dev; |
33 | 29 | ||
@@ -82,7 +78,7 @@ static void locomolcd_off(int comadj) | |||
82 | 78 | ||
83 | void locomolcd_power(int on) | 79 | void locomolcd_power(int on) |
84 | { | 80 | { |
85 | int comadj = 118; | 81 | int comadj = sharpsl_param.comadj; |
86 | unsigned long flags; | 82 | unsigned long flags; |
87 | 83 | ||
88 | local_irq_save(flags); | 84 | local_irq_save(flags); |
@@ -93,11 +89,12 @@ void locomolcd_power(int on) | |||
93 | } | 89 | } |
94 | 90 | ||
95 | /* read comadj */ | 91 | /* read comadj */ |
96 | #ifdef CONFIG_MACH_POODLE | 92 | if (comadj == -1) { |
97 | comadj = 118; | 93 | if (machine_is_poodle()) |
98 | #else | 94 | comadj = 118; |
99 | comadj = 128; | 95 | if (machine_is_collie()) |
100 | #endif | 96 | comadj = 128; |
97 | } | ||
101 | 98 | ||
102 | if (on) | 99 | if (on) |
103 | locomolcd_on(comadj); | 100 | locomolcd_on(comadj); |