diff options
author | Adam Litke <agl@us.ibm.com> | 2007-06-16 13:16:15 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-06-16 16:16:16 -0400 |
commit | 22741925d268e8479ef66312749bd8d96ed35365 (patch) | |
tree | 33d6ed9143d4e65a1fa8f2bc75b2b41ea4fe3b0e | |
parent | 74584ae509befc2ed711810e7df4b075473869b2 (diff) |
hugetlb: fix get_policy for stacked shared memory files
Here's another breakage as a result of shared memory stacked files :(
The NUMA policy for a VMA is determined by checking the following (in the
order given):
1) vma->vm_ops->get_policy() (if defined)
2) vma->vm_policy (if defined)
3) task->mempolicy (if defined)
4) Fall back to default_policy
By switching to stacked files for shared memory, get_policy() is now always
set to shm_get_policy which is a wrapper function. This causes us to stop
at step 1, which yields NULL for hugetlb instead of task->mempolicy which
was the previous (and correct) result.
This patch modifies the shm_get_policy() wrapper to maintain steps 1-3 for
the wrapped vm_ops.
(akpm: the refcounting of mempolicies is busted and this patch does nothing to
improve it)
Signed-off-by: Adam Litke <agl@us.ibm.com>
Acked-by: William Irwin <bill.irwin@oracle.com>
Cc: dean gaudet <dean@arctic.org>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Andi Kleen <ak@suse.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | ipc/shm.c | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -254,8 +254,10 @@ struct mempolicy *shm_get_policy(struct vm_area_struct *vma, unsigned long addr) | |||
254 | 254 | ||
255 | if (sfd->vm_ops->get_policy) | 255 | if (sfd->vm_ops->get_policy) |
256 | pol = sfd->vm_ops->get_policy(vma, addr); | 256 | pol = sfd->vm_ops->get_policy(vma, addr); |
257 | else | 257 | else if (vma->vm_policy) |
258 | pol = vma->vm_policy; | 258 | pol = vma->vm_policy; |
259 | else | ||
260 | pol = current->mempolicy; | ||
259 | return pol; | 261 | return pol; |
260 | } | 262 | } |
261 | #endif | 263 | #endif |