diff options
author | Eric Sandeen <sandeen@redhat.com> | 2009-12-14 13:59:18 -0500 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2009-12-23 07:43:50 -0500 |
commit | ed505ee454dbf133b1a4067d3ac0325d4261eda1 (patch) | |
tree | 352720f71d096b838d7db68b2005a00ee4966a2e | |
parent | dc52dd3a3a800e70b3440ea4424f8c87ab043e42 (diff) |
ext3: Remove outdated comment about lock_super()
ext3_fill_super() is no longer called by read_super(), and it is no
longer called with the superblock locked. The
unlock_super()/lock_super() is no longer present, so this comment is
entirely superfluous.
Port of ext4 commit 32ed5058ce90024efcd811254b4b1de0468099df by
Theodore Ts'o <tytso@mit.edu>.
CC: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r-- | fs/ext3/super.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 7ad1e8c30bd0..8ad566b845ae 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -2014,14 +2014,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
2014 | } | 2014 | } |
2015 | 2015 | ||
2016 | ext3_setup_super (sb, es, sb->s_flags & MS_RDONLY); | 2016 | ext3_setup_super (sb, es, sb->s_flags & MS_RDONLY); |
2017 | /* | 2017 | |
2018 | * akpm: core read_super() calls in here with the superblock locked. | ||
2019 | * That deadlocks, because orphan cleanup needs to lock the superblock | ||
2020 | * in numerous places. Here we just pop the lock - it's relatively | ||
2021 | * harmless, because we are now ready to accept write_super() requests, | ||
2022 | * and aviro says that's the only reason for hanging onto the | ||
2023 | * superblock lock. | ||
2024 | */ | ||
2025 | EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS; | 2018 | EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS; |
2026 | ext3_orphan_cleanup(sb, es); | 2019 | ext3_orphan_cleanup(sb, es); |
2027 | EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS; | 2020 | EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS; |