aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2010-08-08 00:50:36 -0400
committerDavid S. Miller <davem@davemloft.net>2010-08-17 05:32:54 -0400
commit7136e11e0cf520ab3fc7b55a20e60c2ec5ea88e1 (patch)
tree7d52e07cbdfdca5c697fdac0768c05ac778048cb
parentea0a52c4fd8eb2c8e0586b939c484e160fb4a721 (diff)
pcnet_cs: Use pr_fmt and pr_<level>
It looks as if the printks in get_ax88190 are incorrect and were duplicated and superceded by a test in pcnet_config, so I removed them. Changed the level of the ax88190 test to KERN_NOTICE to match the other message styles in pcnet_config. Compiled but untested. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/pcmcia/pcnet_cs.c26
1 files changed, 13 insertions, 13 deletions
diff --git a/drivers/net/pcmcia/pcnet_cs.c b/drivers/net/pcmcia/pcnet_cs.c
index 296f8a8e57ca..1815b2644b96 100644
--- a/drivers/net/pcmcia/pcnet_cs.c
+++ b/drivers/net/pcmcia/pcnet_cs.c
@@ -28,6 +28,8 @@
28 28
29======================================================================*/ 29======================================================================*/
30 30
31#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
32
31#include <linux/kernel.h> 33#include <linux/kernel.h>
32#include <linux/module.h> 34#include <linux/module.h>
33#include <linux/init.h> 35#include <linux/init.h>
@@ -432,8 +434,6 @@ static hw_info_t *get_ax88190(struct pcmcia_device *link)
432 dev->dev_addr[i] = j & 0xff; 434 dev->dev_addr[i] = j & 0xff;
433 dev->dev_addr[i+1] = j >> 8; 435 dev->dev_addr[i+1] = j >> 8;
434 } 436 }
435 printk(KERN_NOTICE "pcnet_cs: this is an AX88190 card!\n");
436 printk(KERN_NOTICE "pcnet_cs: use axnet_cs instead.\n");
437 return NULL; 437 return NULL;
438} 438}
439 439
@@ -568,15 +568,15 @@ static int pcnet_config(struct pcmcia_device *link)
568 if ((if_port == 1) || (if_port == 2)) 568 if ((if_port == 1) || (if_port == 2))
569 dev->if_port = if_port; 569 dev->if_port = if_port;
570 else 570 else
571 printk(KERN_NOTICE "pcnet_cs: invalid if_port requested\n"); 571 pr_notice("invalid if_port requested\n");
572 } else { 572 } else {
573 dev->if_port = 0; 573 dev->if_port = 0;
574 } 574 }
575 575
576 if ((link->conf.ConfigBase == 0x03c0) && 576 if ((link->conf.ConfigBase == 0x03c0) &&
577 (link->manf_id == 0x149) && (link->card_id == 0xc1ab)) { 577 (link->manf_id == 0x149) && (link->card_id == 0xc1ab)) {
578 printk(KERN_INFO "pcnet_cs: this is an AX88190 card!\n"); 578 pr_notice("this is an AX88190 card!\n");
579 printk(KERN_INFO "pcnet_cs: use axnet_cs instead.\n"); 579 pr_notice("use axnet_cs instead.\n");
580 goto failed; 580 goto failed;
581 } 581 }
582 582
@@ -591,8 +591,8 @@ static int pcnet_config(struct pcmcia_device *link)
591 local_hw_info = get_hwired(link); 591 local_hw_info = get_hwired(link);
592 592
593 if (local_hw_info == NULL) { 593 if (local_hw_info == NULL) {
594 printk(KERN_NOTICE "pcnet_cs: unable to read hardware net" 594 pr_notice("unable to read hardware net address for io base %#3lx\n",
595 " address for io base %#3lx\n", dev->base_addr); 595 dev->base_addr);
596 goto failed; 596 goto failed;
597 } 597 }
598 598
@@ -632,7 +632,7 @@ static int pcnet_config(struct pcmcia_device *link)
632 SET_NETDEV_DEV(dev, &link->dev); 632 SET_NETDEV_DEV(dev, &link->dev);
633 633
634 if (register_netdev(dev) != 0) { 634 if (register_netdev(dev) != 0) {
635 printk(KERN_NOTICE "pcnet_cs: register_netdev() failed\n"); 635 pr_notice("register_netdev() failed\n");
636 goto failed; 636 goto failed;
637 } 637 }
638 638
@@ -641,16 +641,16 @@ static int pcnet_config(struct pcmcia_device *link)
641 netdev_info(dev, "NE2000 (DL100%d rev %02x): ", 641 netdev_info(dev, "NE2000 (DL100%d rev %02x): ",
642 (info->flags & IS_DL10022) ? 22 : 19, id); 642 (info->flags & IS_DL10022) ? 22 : 19, id);
643 if (info->pna_phy) 643 if (info->pna_phy)
644 printk("PNA, "); 644 pr_cont("PNA, ");
645 } else { 645 } else {
646 netdev_info(dev, "NE2000 Compatible: "); 646 netdev_info(dev, "NE2000 Compatible: ");
647 } 647 }
648 printk("io %#3lx, irq %d,", dev->base_addr, dev->irq); 648 pr_cont("io %#3lx, irq %d,", dev->base_addr, dev->irq);
649 if (info->flags & USE_SHMEM) 649 if (info->flags & USE_SHMEM)
650 printk (" mem %#5lx,", dev->mem_start); 650 pr_cont(" mem %#5lx,", dev->mem_start);
651 if (info->flags & HAS_MISC_REG) 651 if (info->flags & HAS_MISC_REG)
652 printk(" %s xcvr,", if_names[dev->if_port]); 652 pr_cont(" %s xcvr,", if_names[dev->if_port]);
653 printk(" hw_addr %pM\n", dev->dev_addr); 653 pr_cont(" hw_addr %pM\n", dev->dev_addr);
654 return 0; 654 return 0;
655 655
656failed: 656failed: