aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-12-06 02:02:55 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2010-12-06 19:09:45 -0500
commit6b74705e15d5c87181008f1ac984df7faaad55c9 (patch)
tree33cc1f638feaf9983a56a9ce77a3b25cfa036e8b
parentcd0b0ebfbe134b9c98fa8e628732b0e41b2cb48c (diff)
Staging: Beceem: use after free in bcm_exit()
We can't call class_destroy() until after the driver has been deregistered. It leads to a NULL deref on module unload. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/bcm/InterfaceInit.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c
index dd829409a8c8..b4d22562d060 100644
--- a/drivers/staging/bcm/InterfaceInit.c
+++ b/drivers/staging/bcm/InterfaceInit.c
@@ -658,9 +658,8 @@ static __init int bcm_init(void)
658 658
659static __exit void bcm_exit(void) 659static __exit void bcm_exit(void)
660{ 660{
661 class_destroy(bcm_class);
662
663 usb_deregister(&usbbcm_driver); 661 usb_deregister(&usbbcm_driver);
662 class_destroy(bcm_class);
664} 663}
665 664
666module_init(bcm_init); 665module_init(bcm_init);