diff options
| author | Ingo Molnar <mingo@elte.hu> | 2008-10-12 09:06:29 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-10-12 09:09:23 -0400 |
| commit | 46eaa6702016e3ac9a188172a2c309d6ca1be1cd (patch) | |
| tree | 77e893c287fe15acafd68bede8eb9b46bd541672 | |
| parent | a9b9e81c915e4a57ac3b21d1a7fa7ff184639780 (diff) | |
x86: memory corruption check - cleanup
Move the prototypes from the generic kernel.h header to the more
appropriate include/asm-x86/bios_ebda.h header file.
Also, remove the check from the power management code - this is a
pure x86 matter for now.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| -rw-r--r-- | arch/x86/mm/init_32.c | 1 | ||||
| -rw-r--r-- | arch/x86/mm/init_64.c | 1 | ||||
| -rw-r--r-- | drivers/base/power/main.c | 1 | ||||
| -rw-r--r-- | include/asm-x86/bios_ebda.h | 17 | ||||
| -rw-r--r-- | include/linux/kernel.h | 17 |
5 files changed, 19 insertions, 18 deletions
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c index 7e05462ffb11..bbe044dbe014 100644 --- a/arch/x86/mm/init_32.c +++ b/arch/x86/mm/init_32.c | |||
| @@ -31,6 +31,7 @@ | |||
| 31 | #include <linux/cpumask.h> | 31 | #include <linux/cpumask.h> |
| 32 | 32 | ||
| 33 | #include <asm/asm.h> | 33 | #include <asm/asm.h> |
| 34 | #include <asm/bios_ebda.h> | ||
| 34 | #include <asm/processor.h> | 35 | #include <asm/processor.h> |
| 35 | #include <asm/system.h> | 36 | #include <asm/system.h> |
| 36 | #include <asm/uaccess.h> | 37 | #include <asm/uaccess.h> |
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index d84d3e91d348..3e10054c5731 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c | |||
| @@ -31,6 +31,7 @@ | |||
| 31 | #include <linux/nmi.h> | 31 | #include <linux/nmi.h> |
| 32 | 32 | ||
| 33 | #include <asm/processor.h> | 33 | #include <asm/processor.h> |
| 34 | #include <asm/bios_ebda.h> | ||
| 34 | #include <asm/system.h> | 35 | #include <asm/system.h> |
| 35 | #include <asm/uaccess.h> | 36 | #include <asm/uaccess.h> |
| 36 | #include <asm/pgtable.h> | 37 | #include <asm/pgtable.h> |
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index bf6d3554e506..273a944d4040 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c | |||
| @@ -254,7 +254,6 @@ static char *pm_verb(int event) | |||
| 254 | 254 | ||
| 255 | static void pm_dev_dbg(struct device *dev, pm_message_t state, char *info) | 255 | static void pm_dev_dbg(struct device *dev, pm_message_t state, char *info) |
| 256 | { | 256 | { |
| 257 | check_for_bios_corruption(); | ||
| 258 | dev_dbg(dev, "%s%s%s\n", info, pm_verb(state.event), | 257 | dev_dbg(dev, "%s%s%s\n", info, pm_verb(state.event), |
| 259 | ((state.event & PM_EVENT_SLEEP) && device_may_wakeup(dev)) ? | 258 | ((state.event & PM_EVENT_SLEEP) && device_may_wakeup(dev)) ? |
| 260 | ", may wakeup" : ""); | 259 | ", may wakeup" : ""); |
diff --git a/include/asm-x86/bios_ebda.h b/include/asm-x86/bios_ebda.h index ec42ed874591..79b4b88505d7 100644 --- a/include/asm-x86/bios_ebda.h +++ b/include/asm-x86/bios_ebda.h | |||
| @@ -16,4 +16,21 @@ static inline unsigned int get_bios_ebda(void) | |||
| 16 | 16 | ||
| 17 | void reserve_ebda_region(void); | 17 | void reserve_ebda_region(void); |
| 18 | 18 | ||
| 19 | #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION | ||
| 20 | /* | ||
| 21 | * This is obviously not a great place for this, but we want to be | ||
| 22 | * able to scatter it around anywhere in the kernel. | ||
| 23 | */ | ||
| 24 | void check_for_bios_corruption(void); | ||
| 25 | void start_periodic_check_for_corruption(void); | ||
| 26 | #else | ||
| 27 | static inline void check_for_bios_corruption(void) | ||
| 28 | { | ||
| 29 | } | ||
| 30 | |||
| 31 | static inline void start_periodic_check_for_corruption(void) | ||
| 32 | { | ||
| 33 | } | ||
| 34 | #endif | ||
| 35 | |||
| 19 | #endif /* ASM_X86__BIOS_EBDA_H */ | 36 | #endif /* ASM_X86__BIOS_EBDA_H */ |
diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 50873b211788..2651f805ba6d 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h | |||
| @@ -240,23 +240,6 @@ extern const char *print_tainted(void); | |||
| 240 | extern void add_taint(unsigned); | 240 | extern void add_taint(unsigned); |
| 241 | extern int root_mountflags; | 241 | extern int root_mountflags; |
| 242 | 242 | ||
| 243 | #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION | ||
| 244 | /* | ||
| 245 | * This is obviously not a great place for this, but we want to be | ||
| 246 | * able to scatter it around anywhere in the kernel. | ||
| 247 | */ | ||
| 248 | void check_for_bios_corruption(void); | ||
| 249 | void start_periodic_check_for_corruption(void); | ||
| 250 | #else | ||
| 251 | static inline void check_for_bios_corruption(void) | ||
| 252 | { | ||
| 253 | } | ||
| 254 | |||
| 255 | static inline void start_periodic_check_for_corruption(void) | ||
| 256 | { | ||
| 257 | } | ||
| 258 | #endif | ||
| 259 | |||
| 260 | /* Values used for system_state */ | 243 | /* Values used for system_state */ |
| 261 | extern enum system_states { | 244 | extern enum system_states { |
| 262 | SYSTEM_BOOTING, | 245 | SYSTEM_BOOTING, |
