diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-06-11 16:32:46 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-07-09 12:09:16 -0400 |
commit | 46cb650c224bb8e64a749090105d74b9e8eda669 (patch) | |
tree | 03c6b21bc70a983a63642c2bec6c0e26f07e4efb | |
parent | b22602a673b1743bba4b62bb404ffd3b269d2f09 (diff) |
NFS: Remove the redundant file_open entry from struct nfs_rpc_ops
All instances are set to nfs_open(), so we should just remove the redundant
indirection. Ditto for the file_release op
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r-- | fs/nfs/file.c | 4 | ||||
-rw-r--r-- | fs/nfs/nfs3proc.c | 2 | ||||
-rw-r--r-- | fs/nfs/nfs4proc.c | 2 | ||||
-rw-r--r-- | fs/nfs/proc.c | 2 | ||||
-rw-r--r-- | include/linux/nfs_xdr.h | 2 |
5 files changed, 2 insertions, 10 deletions
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index 78b26f875eee..509dcb58959e 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c | |||
@@ -129,7 +129,7 @@ nfs_file_open(struct inode *inode, struct file *filp) | |||
129 | 129 | ||
130 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); | 130 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); |
131 | lock_kernel(); | 131 | lock_kernel(); |
132 | res = NFS_PROTO(inode)->file_open(inode, filp); | 132 | res = nfs_open(inode, filp); |
133 | unlock_kernel(); | 133 | unlock_kernel(); |
134 | return res; | 134 | return res; |
135 | } | 135 | } |
@@ -147,7 +147,7 @@ nfs_file_release(struct inode *inode, struct file *filp) | |||
147 | if (filp->f_mode & FMODE_WRITE) | 147 | if (filp->f_mode & FMODE_WRITE) |
148 | nfs_wb_all(dentry->d_inode); | 148 | nfs_wb_all(dentry->d_inode); |
149 | nfs_inc_stats(inode, NFSIOS_VFSRELEASE); | 149 | nfs_inc_stats(inode, NFSIOS_VFSRELEASE); |
150 | return NFS_PROTO(inode)->file_release(inode, filp); | 150 | return nfs_release(inode, filp); |
151 | } | 151 | } |
152 | 152 | ||
153 | /** | 153 | /** |
diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c index b9c2d995332b..1e750e4574a9 100644 --- a/fs/nfs/nfs3proc.c +++ b/fs/nfs/nfs3proc.c | |||
@@ -816,8 +816,6 @@ const struct nfs_rpc_ops nfs_v3_clientops = { | |||
816 | .write_done = nfs3_write_done, | 816 | .write_done = nfs3_write_done, |
817 | .commit_setup = nfs3_proc_commit_setup, | 817 | .commit_setup = nfs3_proc_commit_setup, |
818 | .commit_done = nfs3_commit_done, | 818 | .commit_done = nfs3_commit_done, |
819 | .file_open = nfs_open, | ||
820 | .file_release = nfs_release, | ||
821 | .lock = nfs3_proc_lock, | 819 | .lock = nfs3_proc_lock, |
822 | .clear_acl_cache = nfs3_forget_cached_acls, | 820 | .clear_acl_cache = nfs3_forget_cached_acls, |
823 | }; | 821 | }; |
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 31a7e4c54a12..dfdd19a6d17e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
@@ -3714,8 +3714,6 @@ const struct nfs_rpc_ops nfs_v4_clientops = { | |||
3714 | .write_done = nfs4_write_done, | 3714 | .write_done = nfs4_write_done, |
3715 | .commit_setup = nfs4_proc_commit_setup, | 3715 | .commit_setup = nfs4_proc_commit_setup, |
3716 | .commit_done = nfs4_commit_done, | 3716 | .commit_done = nfs4_commit_done, |
3717 | .file_open = nfs_open, | ||
3718 | .file_release = nfs_release, | ||
3719 | .lock = nfs4_proc_lock, | 3717 | .lock = nfs4_proc_lock, |
3720 | .clear_acl_cache = nfs4_zap_acl_attr, | 3718 | .clear_acl_cache = nfs4_zap_acl_attr, |
3721 | }; | 3719 | }; |
diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index c7605587d0eb..4dbb84df1b68 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c | |||
@@ -655,8 +655,6 @@ const struct nfs_rpc_ops nfs_v2_clientops = { | |||
655 | .write_setup = nfs_proc_write_setup, | 655 | .write_setup = nfs_proc_write_setup, |
656 | .write_done = nfs_write_done, | 656 | .write_done = nfs_write_done, |
657 | .commit_setup = nfs_proc_commit_setup, | 657 | .commit_setup = nfs_proc_commit_setup, |
658 | .file_open = nfs_open, | ||
659 | .file_release = nfs_release, | ||
660 | .lock = nfs_proc_lock, | 658 | .lock = nfs_proc_lock, |
661 | .lock_check_bounds = nfs_lock_check_bounds, | 659 | .lock_check_bounds = nfs_lock_check_bounds, |
662 | }; | 660 | }; |
diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h index 8d780de371f0..8c77c11224d1 100644 --- a/include/linux/nfs_xdr.h +++ b/include/linux/nfs_xdr.h | |||
@@ -829,8 +829,6 @@ struct nfs_rpc_ops { | |||
829 | int (*write_done) (struct rpc_task *, struct nfs_write_data *); | 829 | int (*write_done) (struct rpc_task *, struct nfs_write_data *); |
830 | void (*commit_setup) (struct nfs_write_data *, struct rpc_message *); | 830 | void (*commit_setup) (struct nfs_write_data *, struct rpc_message *); |
831 | int (*commit_done) (struct rpc_task *, struct nfs_write_data *); | 831 | int (*commit_done) (struct rpc_task *, struct nfs_write_data *); |
832 | int (*file_open) (struct inode *, struct file *); | ||
833 | int (*file_release) (struct inode *, struct file *); | ||
834 | int (*lock)(struct file *, int, struct file_lock *); | 832 | int (*lock)(struct file *, int, struct file_lock *); |
835 | int (*lock_check_bounds)(const struct file_lock *); | 833 | int (*lock_check_bounds)(const struct file_lock *); |
836 | void (*clear_acl_cache)(struct inode *); | 834 | void (*clear_acl_cache)(struct inode *); |