diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-10-05 15:04:41 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-10-05 15:04:41 -0400 |
commit | 41cb6654eb2cf01476223a3742946b9f65bd1bbd (patch) | |
tree | 6874faea173541ef1692173b9984739e8254ffcc | |
parent | e69a9ac59629db81971a9e03048f9a107712947a (diff) | |
parent | 1ad0560e8cdb6d5b381220dc2da187691b5ce124 (diff) |
Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
* 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
perf tools: Run generate-cmdlist.sh properly
perf_event: Clean up perf_event_init_task()
perf_event: Fix event group handling in __perf_event_sched_*()
perf timechart: Add a power-only mode
perf top: Add poll_idle to the skip list
-rw-r--r-- | kernel/perf_event.c | 34 | ||||
-rw-r--r-- | tools/perf/Documentation/perf-timechart.txt | 3 | ||||
-rw-r--r-- | tools/perf/Makefile | 2 | ||||
-rw-r--r-- | tools/perf/builtin-timechart.c | 10 | ||||
-rw-r--r-- | tools/perf/builtin-top.c | 1 | ||||
-rw-r--r-- | tools/perf/util/svghelper.c | 14 |
6 files changed, 34 insertions, 30 deletions
diff --git a/kernel/perf_event.c b/kernel/perf_event.c index 0f86feb6db0c..e491fb087939 100644 --- a/kernel/perf_event.c +++ b/kernel/perf_event.c | |||
@@ -1030,14 +1030,10 @@ void __perf_event_sched_out(struct perf_event_context *ctx, | |||
1030 | update_context_time(ctx); | 1030 | update_context_time(ctx); |
1031 | 1031 | ||
1032 | perf_disable(); | 1032 | perf_disable(); |
1033 | if (ctx->nr_active) { | 1033 | if (ctx->nr_active) |
1034 | list_for_each_entry(event, &ctx->group_list, group_entry) { | 1034 | list_for_each_entry(event, &ctx->group_list, group_entry) |
1035 | if (event != event->group_leader) | 1035 | group_sched_out(event, cpuctx, ctx); |
1036 | event_sched_out(event, cpuctx, ctx); | 1036 | |
1037 | else | ||
1038 | group_sched_out(event, cpuctx, ctx); | ||
1039 | } | ||
1040 | } | ||
1041 | perf_enable(); | 1037 | perf_enable(); |
1042 | out: | 1038 | out: |
1043 | spin_unlock(&ctx->lock); | 1039 | spin_unlock(&ctx->lock); |
@@ -1258,12 +1254,8 @@ __perf_event_sched_in(struct perf_event_context *ctx, | |||
1258 | if (event->cpu != -1 && event->cpu != cpu) | 1254 | if (event->cpu != -1 && event->cpu != cpu) |
1259 | continue; | 1255 | continue; |
1260 | 1256 | ||
1261 | if (event != event->group_leader) | 1257 | if (group_can_go_on(event, cpuctx, 1)) |
1262 | event_sched_in(event, cpuctx, ctx, cpu); | 1258 | group_sched_in(event, cpuctx, ctx, cpu); |
1263 | else { | ||
1264 | if (group_can_go_on(event, cpuctx, 1)) | ||
1265 | group_sched_in(event, cpuctx, ctx, cpu); | ||
1266 | } | ||
1267 | 1259 | ||
1268 | /* | 1260 | /* |
1269 | * If this pinned group hasn't been scheduled, | 1261 | * If this pinned group hasn't been scheduled, |
@@ -1291,15 +1283,9 @@ __perf_event_sched_in(struct perf_event_context *ctx, | |||
1291 | if (event->cpu != -1 && event->cpu != cpu) | 1283 | if (event->cpu != -1 && event->cpu != cpu) |
1292 | continue; | 1284 | continue; |
1293 | 1285 | ||
1294 | if (event != event->group_leader) { | 1286 | if (group_can_go_on(event, cpuctx, can_add_hw)) |
1295 | if (event_sched_in(event, cpuctx, ctx, cpu)) | 1287 | if (group_sched_in(event, cpuctx, ctx, cpu)) |
1296 | can_add_hw = 0; | 1288 | can_add_hw = 0; |
1297 | } else { | ||
1298 | if (group_can_go_on(event, cpuctx, can_add_hw)) { | ||
1299 | if (group_sched_in(event, cpuctx, ctx, cpu)) | ||
1300 | can_add_hw = 0; | ||
1301 | } | ||
1302 | } | ||
1303 | } | 1289 | } |
1304 | perf_enable(); | 1290 | perf_enable(); |
1305 | out: | 1291 | out: |
@@ -4781,9 +4767,7 @@ int perf_event_init_task(struct task_struct *child) | |||
4781 | * We dont have to disable NMIs - we are only looking at | 4767 | * We dont have to disable NMIs - we are only looking at |
4782 | * the list, not manipulating it: | 4768 | * the list, not manipulating it: |
4783 | */ | 4769 | */ |
4784 | list_for_each_entry_rcu(event, &parent_ctx->event_list, event_entry) { | 4770 | list_for_each_entry(event, &parent_ctx->group_list, group_entry) { |
4785 | if (event != event->group_leader) | ||
4786 | continue; | ||
4787 | 4771 | ||
4788 | if (!event->attr.inherit) { | 4772 | if (!event->attr.inherit) { |
4789 | inherited_all = 0; | 4773 | inherited_all = 0; |
diff --git a/tools/perf/Documentation/perf-timechart.txt b/tools/perf/Documentation/perf-timechart.txt index 1c2ed3090cce..a7910099d6fd 100644 --- a/tools/perf/Documentation/perf-timechart.txt +++ b/tools/perf/Documentation/perf-timechart.txt | |||
@@ -31,6 +31,9 @@ OPTIONS | |||
31 | -w:: | 31 | -w:: |
32 | --width=:: | 32 | --width=:: |
33 | Select the width of the SVG file (default: 1000) | 33 | Select the width of the SVG file (default: 1000) |
34 | -p:: | ||
35 | --power-only:: | ||
36 | Only output the CPU power section of the diagram | ||
34 | 37 | ||
35 | 38 | ||
36 | SEE ALSO | 39 | SEE ALSO |
diff --git a/tools/perf/Makefile b/tools/perf/Makefile index b5f1953b6144..5881943f0c34 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile | |||
@@ -728,7 +728,7 @@ $(BUILT_INS): perf$X | |||
728 | common-cmds.h: util/generate-cmdlist.sh command-list.txt | 728 | common-cmds.h: util/generate-cmdlist.sh command-list.txt |
729 | 729 | ||
730 | common-cmds.h: $(wildcard Documentation/perf-*.txt) | 730 | common-cmds.h: $(wildcard Documentation/perf-*.txt) |
731 | $(QUIET_GEN)util/generate-cmdlist.sh > $@+ && mv $@+ $@ | 731 | $(QUIET_GEN). util/generate-cmdlist.sh > $@+ && mv $@+ $@ |
732 | 732 | ||
733 | $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh | 733 | $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh |
734 | $(QUIET_GEN)$(RM) $@ $@+ && \ | 734 | $(QUIET_GEN)$(RM) $@ $@+ && \ |
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index 4405681b3134..702d8fe58fbc 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c | |||
@@ -46,6 +46,8 @@ static u64 turbo_frequency; | |||
46 | 46 | ||
47 | static u64 first_time, last_time; | 47 | static u64 first_time, last_time; |
48 | 48 | ||
49 | static int power_only; | ||
50 | |||
49 | 51 | ||
50 | static struct perf_header *header; | 52 | static struct perf_header *header; |
51 | 53 | ||
@@ -547,7 +549,7 @@ static void end_sample_processing(void) | |||
547 | u64 cpu; | 549 | u64 cpu; |
548 | struct power_event *pwr; | 550 | struct power_event *pwr; |
549 | 551 | ||
550 | for (cpu = 0; cpu < numcpus; cpu++) { | 552 | for (cpu = 0; cpu <= numcpus; cpu++) { |
551 | pwr = malloc(sizeof(struct power_event)); | 553 | pwr = malloc(sizeof(struct power_event)); |
552 | if (!pwr) | 554 | if (!pwr) |
553 | return; | 555 | return; |
@@ -871,7 +873,7 @@ static int determine_display_tasks(u64 threshold) | |||
871 | /* no exit marker, task kept running to the end */ | 873 | /* no exit marker, task kept running to the end */ |
872 | if (p->end_time == 0) | 874 | if (p->end_time == 0) |
873 | p->end_time = last_time; | 875 | p->end_time = last_time; |
874 | if (p->total_time >= threshold) | 876 | if (p->total_time >= threshold && !power_only) |
875 | p->display = 1; | 877 | p->display = 1; |
876 | 878 | ||
877 | c = p->all; | 879 | c = p->all; |
@@ -882,7 +884,7 @@ static int determine_display_tasks(u64 threshold) | |||
882 | if (c->start_time == 1) | 884 | if (c->start_time == 1) |
883 | c->start_time = first_time; | 885 | c->start_time = first_time; |
884 | 886 | ||
885 | if (c->total_time >= threshold) { | 887 | if (c->total_time >= threshold && !power_only) { |
886 | c->display = 1; | 888 | c->display = 1; |
887 | count++; | 889 | count++; |
888 | } | 890 | } |
@@ -1134,6 +1136,8 @@ static const struct option options[] = { | |||
1134 | "output file name"), | 1136 | "output file name"), |
1135 | OPT_INTEGER('w', "width", &svg_page_width, | 1137 | OPT_INTEGER('w', "width", &svg_page_width, |
1136 | "page width"), | 1138 | "page width"), |
1139 | OPT_BOOLEAN('p', "power-only", &power_only, | ||
1140 | "output power data only"), | ||
1137 | OPT_END() | 1141 | OPT_END() |
1138 | }; | 1142 | }; |
1139 | 1143 | ||
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 1ca88896eee4..37512e936235 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
@@ -782,6 +782,7 @@ static const char *skip_symbols[] = { | |||
782 | "exit_idle", | 782 | "exit_idle", |
783 | "mwait_idle", | 783 | "mwait_idle", |
784 | "mwait_idle_with_hints", | 784 | "mwait_idle_with_hints", |
785 | "poll_idle", | ||
785 | "ppc64_runlatch_off", | 786 | "ppc64_runlatch_off", |
786 | "pseries_dedicated_idle_sleep", | 787 | "pseries_dedicated_idle_sleep", |
787 | NULL | 788 | NULL |
diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c index a778fd0f4ae4..856655d8b0b8 100644 --- a/tools/perf/util/svghelper.c +++ b/tools/perf/util/svghelper.c | |||
@@ -28,7 +28,7 @@ static u64 turbo_frequency, max_freq; | |||
28 | 28 | ||
29 | int svg_page_width = 1000; | 29 | int svg_page_width = 1000; |
30 | 30 | ||
31 | #define MIN_TEXT_SIZE 0.001 | 31 | #define MIN_TEXT_SIZE 0.01 |
32 | 32 | ||
33 | static u64 total_height; | 33 | static u64 total_height; |
34 | static FILE *svgfile; | 34 | static FILE *svgfile; |
@@ -217,6 +217,18 @@ static char *cpu_model(void) | |||
217 | } | 217 | } |
218 | fclose(file); | 218 | fclose(file); |
219 | } | 219 | } |
220 | |||
221 | /* CPU type */ | ||
222 | file = fopen("/sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequencies", "r"); | ||
223 | if (file) { | ||
224 | while (fgets(buf, 255, file)) { | ||
225 | unsigned int freq; | ||
226 | freq = strtoull(buf, NULL, 10); | ||
227 | if (freq > max_freq) | ||
228 | max_freq = freq; | ||
229 | } | ||
230 | fclose(file); | ||
231 | } | ||
220 | return cpu_m; | 232 | return cpu_m; |
221 | } | 233 | } |
222 | 234 | ||