diff options
author | Jonathan Woithe <jwoithe@physics.adelaide.edu.au> | 2009-12-22 17:49:42 -0500 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2009-12-23 02:24:32 -0500 |
commit | 3b1c37cab3765b87efbd4ed40301ceaf72b9f5c2 (patch) | |
tree | 8d0c96819aa3c6b109ba6ccc2a40dfd2a9a1ffd0 | |
parent | 4a28395d72a956f2dad24e343d06bc08c9afb89a (diff) |
fujitu-laptop: fix tests of acpi_evaluate_integer() return value
Fix tests on return value from acpi_evaluate_integer(). Based on a patch by
Roel Kluin <roel.kluin@gmail.com> and incorporating suggestions from Len
Brown <lenb@kernel.org>.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r-- | drivers/platform/x86/fujitsu-laptop.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index bcd4ba8be7db..3c2d0384b43b 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c | |||
@@ -376,8 +376,8 @@ static int get_lcd_level(void) | |||
376 | 376 | ||
377 | status = | 377 | status = |
378 | acpi_evaluate_integer(fujitsu->acpi_handle, "GBLL", NULL, &state); | 378 | acpi_evaluate_integer(fujitsu->acpi_handle, "GBLL", NULL, &state); |
379 | if (status < 0) | 379 | if (ACPI_FAILURE(status)) |
380 | return status; | 380 | return 0; |
381 | 381 | ||
382 | fujitsu->brightness_level = state & 0x0fffffff; | 382 | fujitsu->brightness_level = state & 0x0fffffff; |
383 | 383 | ||
@@ -398,8 +398,8 @@ static int get_max_brightness(void) | |||
398 | 398 | ||
399 | status = | 399 | status = |
400 | acpi_evaluate_integer(fujitsu->acpi_handle, "RBLL", NULL, &state); | 400 | acpi_evaluate_integer(fujitsu->acpi_handle, "RBLL", NULL, &state); |
401 | if (status < 0) | 401 | if (ACPI_FAILURE(status)) |
402 | return status; | 402 | return -1; |
403 | 403 | ||
404 | fujitsu->max_brightness = state; | 404 | fujitsu->max_brightness = state; |
405 | 405 | ||