diff options
author | Alexey Dobriyan <adobriyan@sw.ru> | 2008-02-08 07:20:14 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-08 12:22:32 -0500 |
commit | 25478445c4a39318acbe08ba8df7945766cbb5b5 (patch) | |
tree | de8a3dec84bb554daf0b53a06bf3b1107e7e8ff6 | |
parent | 50e8a2890ed0eeb7a11ae0c39144fcdd1cad1cf8 (diff) |
Fix container_of() usage
Using "attr" twice is not OK, because it effectively prohibits such
container_of() on variables not named "attr".
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | arch/sh/kernel/cpu/sh4/sq.c | 2 | ||||
-rw-r--r-- | drivers/lguest/lguest_device.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 3008c00eea6b..8250e017bd4e 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c | |||
@@ -263,7 +263,7 @@ struct sq_sysfs_attr { | |||
263 | ssize_t (*store)(const char *buf, size_t count); | 263 | ssize_t (*store)(const char *buf, size_t count); |
264 | }; | 264 | }; |
265 | 265 | ||
266 | #define to_sq_sysfs_attr(attr) container_of(attr, struct sq_sysfs_attr, attr) | 266 | #define to_sq_sysfs_attr(a) container_of(a, struct sq_sysfs_attr, attr) |
267 | 267 | ||
268 | static ssize_t sq_sysfs_show(struct kobject *kobj, struct attribute *attr, | 268 | static ssize_t sq_sysfs_show(struct kobject *kobj, struct attribute *attr, |
269 | char *buf) | 269 | char *buf) |
diff --git a/drivers/lguest/lguest_device.c b/drivers/lguest/lguest_device.c index 84f85e23cca7..1b2ec0bf5eb1 100644 --- a/drivers/lguest/lguest_device.c +++ b/drivers/lguest/lguest_device.c | |||
@@ -47,7 +47,7 @@ struct lguest_device { | |||
47 | /* Since the virtio infrastructure hands us a pointer to the virtio_device all | 47 | /* Since the virtio infrastructure hands us a pointer to the virtio_device all |
48 | * the time, it helps to have a curt macro to get a pointer to the struct | 48 | * the time, it helps to have a curt macro to get a pointer to the struct |
49 | * lguest_device it's enclosed in. */ | 49 | * lguest_device it's enclosed in. */ |
50 | #define to_lgdev(vdev) container_of(vdev, struct lguest_device, vdev) | 50 | #define to_lgdev(vd) container_of(vd, struct lguest_device, vdev) |
51 | 51 | ||
52 | /*D:130 | 52 | /*D:130 |
53 | * Device configurations | 53 | * Device configurations |