diff options
author | Jeremy Fitzhardinge <jeremy@goop.org> | 2009-02-07 18:39:40 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-02-09 07:34:46 -0500 |
commit | 05876f88ed9a66b26af613e222795ae790616252 (patch) | |
tree | 1f2c5be1c98eb2ea668410fa90b2f28156e479f6 | |
parent | eecb9a697f0b790e5840dae8a8b866bea49a86ee (diff) |
acpi: remove final __acpi_map_table mapping before setting acpi_gbl_permanent_mmap
On x86, __acpi_map_table uses early_ioremap() to create the mapping,
replacing the previous mapping with a new one. Once enough of the
kernel is up an running it switches to using normal ioremap(). At
that point, we need to clean up the final mapping to avoid a warning
from the early_ioremap subsystem.
This can be removed after all the instances in the ACPI code are fixed
that rely on early-ioremap's implicit overmapping of previously
mapped tables.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Acked-by: Len Brown <len.brown@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | arch/x86/kernel/acpi/boot.c | 8 | ||||
-rw-r--r-- | drivers/acpi/bus.c | 6 |
2 files changed, 11 insertions, 3 deletions
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 5424a18f2e4e..7217834f6b1d 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c | |||
@@ -124,12 +124,14 @@ char *__init __acpi_map_table(unsigned long phys, unsigned long size) | |||
124 | static char *prev_map; | 124 | static char *prev_map; |
125 | static unsigned long prev_size; | 125 | static unsigned long prev_size; |
126 | 126 | ||
127 | if (prev_map) { | ||
128 | early_iounmap(prev_map, prev_size); | ||
129 | prev_map = NULL; | ||
130 | } | ||
131 | |||
127 | if (!phys || !size) | 132 | if (!phys || !size) |
128 | return NULL; | 133 | return NULL; |
129 | 134 | ||
130 | if (prev_map) | ||
131 | early_iounmap(prev_map, prev_size); | ||
132 | |||
133 | prev_size = size; | 135 | prev_size = size; |
134 | prev_map = early_ioremap(phys, size); | 136 | prev_map = early_ioremap(phys, size); |
135 | 137 | ||
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 765fd1c56cd6..fb1be7b5dbc1 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c | |||
@@ -694,6 +694,12 @@ void __init acpi_early_init(void) | |||
694 | if (!acpi_strict) | 694 | if (!acpi_strict) |
695 | acpi_gbl_enable_interpreter_slack = TRUE; | 695 | acpi_gbl_enable_interpreter_slack = TRUE; |
696 | 696 | ||
697 | /* | ||
698 | * Doing a zero-sized mapping will clear out the previous | ||
699 | * __acpi_map_table() mapping, if any. | ||
700 | */ | ||
701 | __acpi_map_table(0, 0); | ||
702 | |||
697 | acpi_gbl_permanent_mmap = 1; | 703 | acpi_gbl_permanent_mmap = 1; |
698 | 704 | ||
699 | status = acpi_reallocate_root_table(); | 705 | status = acpi_reallocate_root_table(); |