diff options
author | Jack Steiner <steiner@sgi.com> | 2009-09-03 13:56:02 -0400 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2009-09-09 17:05:24 -0400 |
commit | fa526d0d641b5365676a1fb821ce359e217c9b85 (patch) | |
tree | fa08cded30f46df90fe103a750f412e306f2d53e | |
parent | a269cca9926faf8e44b340b017be0d884203141b (diff) |
x86, pat: Fix cacheflush address in change_page_attr_set_clr()
Fix address passed to cpa_flush_range() when changing page
attributes from WB to UC. The address (*addr) is
modified by __change_page_attr_set_clr(). The result is that
the pages being flushed start at the _end_ of the changed range
instead of the beginning.
This should be considered for 2.6.30-stable and 2.6.31-stable.
Signed-off-by: Jack Steiner <steiner@sgi.com>
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Stable team <stable@kernel.org>
-rw-r--r-- | arch/x86/mm/pageattr.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c index 7e600c1962db..e245775ec856 100644 --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c | |||
@@ -822,6 +822,7 @@ static int change_page_attr_set_clr(unsigned long *addr, int numpages, | |||
822 | { | 822 | { |
823 | struct cpa_data cpa; | 823 | struct cpa_data cpa; |
824 | int ret, cache, checkalias; | 824 | int ret, cache, checkalias; |
825 | unsigned long baddr = 0; | ||
825 | 826 | ||
826 | /* | 827 | /* |
827 | * Check, if we are requested to change a not supported | 828 | * Check, if we are requested to change a not supported |
@@ -853,6 +854,11 @@ static int change_page_attr_set_clr(unsigned long *addr, int numpages, | |||
853 | */ | 854 | */ |
854 | WARN_ON_ONCE(1); | 855 | WARN_ON_ONCE(1); |
855 | } | 856 | } |
857 | /* | ||
858 | * Save address for cache flush. *addr is modified in the call | ||
859 | * to __change_page_attr_set_clr() below. | ||
860 | */ | ||
861 | baddr = *addr; | ||
856 | } | 862 | } |
857 | 863 | ||
858 | /* Must avoid aliasing mappings in the highmem code */ | 864 | /* Must avoid aliasing mappings in the highmem code */ |
@@ -900,7 +906,7 @@ static int change_page_attr_set_clr(unsigned long *addr, int numpages, | |||
900 | cpa_flush_array(addr, numpages, cache, | 906 | cpa_flush_array(addr, numpages, cache, |
901 | cpa.flags, pages); | 907 | cpa.flags, pages); |
902 | } else | 908 | } else |
903 | cpa_flush_range(*addr, numpages, cache); | 909 | cpa_flush_range(baddr, numpages, cache); |
904 | } else | 910 | } else |
905 | cpa_flush_all(cache); | 911 | cpa_flush_all(cache); |
906 | 912 | ||