aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2007-11-05 16:16:15 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2008-01-24 23:40:23 -0500
commitf62ed9e33b3ccff54d66b08f82d11940bb9e269b (patch)
tree730e79fe5e1c38a0a277b075405d6671b8e450fe
parent15f2f9b3a9db65aaf908fe7ee17bbe262ae3550f (diff)
firmware: change firmware_kset to firmware_kobj
There is no firmware "subsystem" it's just a directory in /sys that other portions of the kernel want to hook into. So make it a kobject not a kset to help alivate anyone who tries to do some odd kset-like things with this. Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--arch/s390/kernel/ipl.c8
-rw-r--r--drivers/acpi/bus.c2
-rw-r--r--drivers/base/firmware.c8
-rw-r--r--drivers/firmware/edd.c2
-rw-r--r--drivers/firmware/efivars.c2
-rw-r--r--drivers/parisc/pdc_stable.c2
-rw-r--r--include/linux/kobject.h4
7 files changed, 14 insertions, 14 deletions
diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
index c8179fc30baa..b97694fa62ec 100644
--- a/arch/s390/kernel/ipl.c
+++ b/arch/s390/kernel/ipl.c
@@ -855,7 +855,7 @@ static int __init ipl_init(void)
855{ 855{
856 int rc; 856 int rc;
857 857
858 ipl_kset = kset_create_and_add("ipl", NULL, &firmware_kset->kobj); 858 ipl_kset = kset_create_and_add("ipl", NULL, firmware_kobj);
859 if (!ipl_kset) 859 if (!ipl_kset)
860 return -ENOMEM; 860 return -ENOMEM;
861 switch (ipl_info.type) { 861 switch (ipl_info.type) {
@@ -974,7 +974,7 @@ static int __init reipl_init(void)
974{ 974{
975 int rc; 975 int rc;
976 976
977 reipl_kset = kset_create_and_add("reipl", NULL, &firmware_kset->kobj); 977 reipl_kset = kset_create_and_add("reipl", NULL, firmware_kobj);
978 if (!reipl_kset) 978 if (!reipl_kset)
979 return -ENOMEM; 979 return -ENOMEM;
980 rc = sysfs_create_file(&reipl_kset->kobj, &reipl_type_attr.attr); 980 rc = sysfs_create_file(&reipl_kset->kobj, &reipl_type_attr.attr);
@@ -1063,7 +1063,7 @@ static int __init dump_init(void)
1063{ 1063{
1064 int rc; 1064 int rc;
1065 1065
1066 dump_kset = kset_create_and_add("dump", NULL, &firmware_kset->kobj); 1066 dump_kset = kset_create_and_add("dump", NULL, firmware_kobj);
1067 if (!dump_kset) 1067 if (!dump_kset)
1068 return -ENOMEM; 1068 return -ENOMEM;
1069 rc = sysfs_create_file(&dump_kset->kobj, &dump_type_attr); 1069 rc = sysfs_create_file(&dump_kset->kobj, &dump_type_attr);
@@ -1086,7 +1086,7 @@ static int __init shutdown_actions_init(void)
1086 int rc; 1086 int rc;
1087 1087
1088 shutdown_actions_kset = kset_create_and_add("shutdown_actions", NULL, 1088 shutdown_actions_kset = kset_create_and_add("shutdown_actions", NULL,
1089 &firmware_kset->kobj); 1089 firmware_kobj);
1090 if (!shutdown_actions_kset) 1090 if (!shutdown_actions_kset)
1091 return -ENOMEM; 1091 return -ENOMEM;
1092 rc = sysfs_create_file(&shutdown_actions_kset->kobj, &on_panic_attr); 1092 rc = sysfs_create_file(&shutdown_actions_kset->kobj, &on_panic_attr);
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index e550da684a47..1b4cf984b081 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -755,7 +755,7 @@ static int __init acpi_init(void)
755 return -ENODEV; 755 return -ENODEV;
756 } 756 }
757 757
758 acpi_kobj = kobject_create_and_add("acpi", &firmware_kset->kobj); 758 acpi_kobj = kobject_create_and_add("acpi", firmware_kobj);
759 if (!acpi_kobj) { 759 if (!acpi_kobj) {
760 printk(KERN_WARNING "%s: kset create error\n", __FUNCTION__); 760 printk(KERN_WARNING "%s: kset create error\n", __FUNCTION__);
761 acpi_kobj = NULL; 761 acpi_kobj = NULL;
diff --git a/drivers/base/firmware.c b/drivers/base/firmware.c
index 9efff481f5dc..113815556809 100644
--- a/drivers/base/firmware.c
+++ b/drivers/base/firmware.c
@@ -15,13 +15,13 @@
15 15
16#include "base.h" 16#include "base.h"
17 17
18struct kset *firmware_kset; 18struct kobject *firmware_kobj;
19EXPORT_SYMBOL_GPL(firmware_kset); 19EXPORT_SYMBOL_GPL(firmware_kobj);
20 20
21int __init firmware_init(void) 21int __init firmware_init(void)
22{ 22{
23 firmware_kset = kset_create_and_add("firmware", NULL, NULL); 23 firmware_kobj = kobject_create_and_add("firmware", NULL);
24 if (!firmware_kset) 24 if (!firmware_kobj)
25 return -ENOMEM; 25 return -ENOMEM;
26 return 0; 26 return 0;
27} 27}
diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index f07f37047cd1..ddcc95793068 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -756,7 +756,7 @@ edd_init(void)
756 return 1; 756 return 1;
757 } 757 }
758 758
759 edd_kset = kset_create_and_add("edd", NULL, &firmware_kset->kobj); 759 edd_kset = kset_create_and_add("edd", NULL, firmware_kobj);
760 if (!edd_kset) 760 if (!edd_kset)
761 return -ENOMEM; 761 return -ENOMEM;
762 762
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index e17cd8133548..d1ad48190afc 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -668,7 +668,7 @@ efivars_init(void)
668 /* 668 /*
669 * For now we'll register the efi subsys within this driver 669 * For now we'll register the efi subsys within this driver
670 */ 670 */
671 efi_kset = kset_create_and_add("efi", NULL, &firmware_kset->kobj); 671 efi_kset = kset_create_and_add("efi", NULL, firmware_kobj);
672 if (!efi_kset) { 672 if (!efi_kset) {
673 printk(KERN_ERR "efivars: Firmware registration failed.\n"); 673 printk(KERN_ERR "efivars: Firmware registration failed.\n");
674 error = -ENOMEM; 674 error = -ENOMEM;
diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
index 444483405abf..ef1a353e5540 100644
--- a/drivers/parisc/pdc_stable.c
+++ b/drivers/parisc/pdc_stable.c
@@ -1059,7 +1059,7 @@ pdc_stable_init(void)
1059 pdcs_osid = (u16)(result >> 16); 1059 pdcs_osid = (u16)(result >> 16);
1060 1060
1061 /* For now we'll register the stable kset within this driver */ 1061 /* For now we'll register the stable kset within this driver */
1062 stable_kset = kset_create_and_add("stable", NULL, &firmware_kset->kobj); 1062 stable_kset = kset_create_and_add("stable", NULL, firmware_kobj);
1063 if (!stable_kset) { 1063 if (!stable_kset) {
1064 rc = -ENOMEM; 1064 rc = -ENOMEM;
1065 goto fail_firmreg; 1065 goto fail_firmreg;
diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index 29841bb5badb..673623f18464 100644
--- a/include/linux/kobject.h
+++ b/include/linux/kobject.h
@@ -210,8 +210,8 @@ extern struct kset *kernel_kset;
210extern struct kobject *hypervisor_kobj; 210extern struct kobject *hypervisor_kobj;
211/* The global /sys/power/ kset for people to chain off of */ 211/* The global /sys/power/ kset for people to chain off of */
212extern struct kset *power_kset; 212extern struct kset *power_kset;
213/* The global /sys/firmware/ kset for people to chain off of */ 213/* The global /sys/firmware/ kobject for people to chain off of */
214extern struct kset *firmware_kset; 214extern struct kobject *firmware_kobj;
215 215
216extern int __must_check subsystem_register(struct kset *); 216extern int __must_check subsystem_register(struct kset *);
217extern void subsystem_unregister(struct kset *); 217extern void subsystem_unregister(struct kset *);