diff options
| author | Wolfram Sang <w.sang@pengutronix.de> | 2010-03-20 10:13:02 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-04-30 12:30:09 -0400 |
| commit | ee58cb2bcda99ae934176ad5ae66f7699d23cd3d (patch) | |
| tree | a75183e45e26437b644b196d515c6f1a0999442c | |
| parent | b36fc07dc3c742bd704c59d85c8cf12585a00e41 (diff) | |
Staging: iio: adc: fix dangling pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/staging/iio/adc/max1363_core.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c index 790d1cc9cdc3..773f1d1d9c6e 100644 --- a/drivers/staging/iio/adc/max1363_core.c +++ b/drivers/staging/iio/adc/max1363_core.c | |||
| @@ -557,6 +557,7 @@ error_put_reg: | |||
| 557 | if (!IS_ERR(st->reg)) | 557 | if (!IS_ERR(st->reg)) |
| 558 | regulator_put(st->reg); | 558 | regulator_put(st->reg); |
| 559 | error_free_st: | 559 | error_free_st: |
| 560 | i2c_set_clientdata(client, NULL); | ||
| 560 | kfree(st); | 561 | kfree(st); |
| 561 | 562 | ||
| 562 | error_ret: | 563 | error_ret: |
| @@ -574,6 +575,7 @@ static int max1363_remove(struct i2c_client *client) | |||
| 574 | regulator_disable(st->reg); | 575 | regulator_disable(st->reg); |
| 575 | regulator_put(st->reg); | 576 | regulator_put(st->reg); |
| 576 | } | 577 | } |
| 578 | i2c_set_clientdata(client, NULL); | ||
| 577 | kfree(st); | 579 | kfree(st); |
| 578 | 580 | ||
| 579 | return 0; | 581 | return 0; |
