diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-15 17:23:31 -0400 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2010-05-15 18:07:01 -0400 |
| commit | d80f2666b5373f195deae57c9f33a5abb8053d37 (patch) | |
| tree | 9746b8e8e644de39568b94250bd7a7857c447585 | |
| parent | abab7ebf8cc12a6bb03d06b103a49e97276168f0 (diff) | |
drivers/mtd: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| -rw-r--r-- | drivers/mtd/mtdconcat.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c index db6de74082ad..7e075621bbf4 100644 --- a/drivers/mtd/mtdconcat.c +++ b/drivers/mtd/mtdconcat.c | |||
| @@ -183,10 +183,9 @@ concat_writev(struct mtd_info *mtd, const struct kvec *vecs, | |||
| 183 | } | 183 | } |
| 184 | 184 | ||
| 185 | /* make a copy of vecs */ | 185 | /* make a copy of vecs */ |
| 186 | vecs_copy = kmalloc(sizeof(struct kvec) * count, GFP_KERNEL); | 186 | vecs_copy = kmemdup(vecs, sizeof(struct kvec) * count, GFP_KERNEL); |
| 187 | if (!vecs_copy) | 187 | if (!vecs_copy) |
| 188 | return -ENOMEM; | 188 | return -ENOMEM; |
| 189 | memcpy(vecs_copy, vecs, sizeof(struct kvec) * count); | ||
| 190 | 189 | ||
| 191 | entry_low = 0; | 190 | entry_low = 0; |
| 192 | for (i = 0; i < concat->num_subdev; i++) { | 191 | for (i = 0; i < concat->num_subdev; i++) { |
