[ALSA] sound/isa/sb/sb_mixer.c double kfree

Modules: SB drivers

snd_ctl_add() already does the free on error.

Coverity bug #957

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

1 files changed, 1 insertions, 3 deletions

diff --git a/sound/isa/sb/sb_mixer.c b/sound/isa/sb/sb_mixer.c
index 1a6ee344dddb..490b1ca5cf58 100644
--- a/sound/isa/sb/sb_mixer.c
+++ b/sound/isa/sb/sb_mixer.c
@@ -453,10 +453,8 @@ int snd_sbmixer_add_ctl(struct snd_sb *chip, const char *name, int index, int ty
         strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
         ctl->id.index = index;
         ctl->private_value = value;
-        if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
-                snd_ctl_free_one(ctl);
+        if ((err = snd_ctl_add(chip->card, ctl)) < 0)
                 return err;
-        }
         return 0;
 }