diff options
| author | Andy Grover <andy.grover@oracle.com> | 2010-03-11 08:50:02 -0500 | 
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-17 00:16:57 -0400 | 
| commit | 97069788d6784ac92d050557a02f6e7bf4d1f53d (patch) | |
| tree | a1749dae883efd89777c031b18285f0570080b89 | |
| parent | 571c02fa81e43ebb4b793f626d6c7bf0fa18902b (diff) | |
RDS: Turn down alarming reconnect messages
RDS's error messages when a connection goes down are a little
extreme. A connection may go down, and it will be re-established,
and everything is fine. This patch links these messages through
rdsdebug(), instead of to printk directly.
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/rds/ib_cm.c | 3 | ||||
| -rw-r--r-- | net/rds/iw_cm.c | 4 | ||||
| -rw-r--r-- | net/rds/rdma_transport.c | 2 | 
3 files changed, 6 insertions, 3 deletions
| diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c index 647cb8ffc39b..e1f124bf03bb 100644 --- a/net/rds/ib_cm.c +++ b/net/rds/ib_cm.c | |||
| @@ -203,9 +203,10 @@ static void rds_ib_qp_event_handler(struct ib_event *event, void *data) | |||
| 203 | rdma_notify(ic->i_cm_id, IB_EVENT_COMM_EST); | 203 | rdma_notify(ic->i_cm_id, IB_EVENT_COMM_EST); | 
| 204 | break; | 204 | break; | 
| 205 | default: | 205 | default: | 
| 206 | rds_ib_conn_error(conn, "RDS/IB: Fatal QP Event %u " | 206 | rdsdebug("Fatal QP Event %u " | 
| 207 | "- connection %pI4->%pI4, reconnecting\n", | 207 | "- connection %pI4->%pI4, reconnecting\n", | 
| 208 | event->event, &conn->c_laddr, &conn->c_faddr); | 208 | event->event, &conn->c_laddr, &conn->c_faddr); | 
| 209 | rds_conn_drop(conn); | ||
| 209 | break; | 210 | break; | 
| 210 | } | 211 | } | 
| 211 | } | 212 | } | 
| diff --git a/net/rds/iw_cm.c b/net/rds/iw_cm.c index 394cf6b4d0aa..6bc638fd252c 100644 --- a/net/rds/iw_cm.c +++ b/net/rds/iw_cm.c | |||
| @@ -156,9 +156,11 @@ static void rds_iw_qp_event_handler(struct ib_event *event, void *data) | |||
| 156 | case IB_EVENT_QP_REQ_ERR: | 156 | case IB_EVENT_QP_REQ_ERR: | 
| 157 | case IB_EVENT_QP_FATAL: | 157 | case IB_EVENT_QP_FATAL: | 
| 158 | default: | 158 | default: | 
| 159 | rds_iw_conn_error(conn, "RDS/IW: Fatal QP Event %u - connection %pI4->%pI4...reconnecting\n", | 159 | rdsdebug("Fatal QP Event %u " | 
| 160 | "- connection %pI4->%pI4, reconnecting\n", | ||
| 160 | event->event, &conn->c_laddr, | 161 | event->event, &conn->c_laddr, | 
| 161 | &conn->c_faddr); | 162 | &conn->c_faddr); | 
| 163 | rds_conn_drop(conn); | ||
| 162 | break; | 164 | break; | 
| 163 | } | 165 | } | 
| 164 | } | 166 | } | 
| diff --git a/net/rds/rdma_transport.c b/net/rds/rdma_transport.c index 31f9c72b8d76..5ea82fc47c3e 100644 --- a/net/rds/rdma_transport.c +++ b/net/rds/rdma_transport.c | |||
| @@ -101,7 +101,7 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id, | |||
| 101 | break; | 101 | break; | 
| 102 | 102 | ||
| 103 | case RDMA_CM_EVENT_DISCONNECTED: | 103 | case RDMA_CM_EVENT_DISCONNECTED: | 
| 104 | printk(KERN_WARNING "RDS/RDMA: DISCONNECT event - dropping connection " | 104 | rdsdebug("DISCONNECT event - dropping connection " | 
| 105 | "%pI4->%pI4\n", &conn->c_laddr, | 105 | "%pI4->%pI4\n", &conn->c_laddr, | 
| 106 | &conn->c_faddr); | 106 | &conn->c_faddr); | 
| 107 | rds_conn_drop(conn); | 107 | rds_conn_drop(conn); | 
