diff options
| author | Felix Beck <felix.beck@de.ibm.com> | 2009-10-06 04:34:10 -0400 |
|---|---|---|
| committer | Martin Schwidefsky <sky@mschwide.boeblingen.de.ibm.com> | 2009-10-06 04:35:09 -0400 |
| commit | 942b7e65c321b72e1d73daee45291300be87c62b (patch) | |
| tree | 694cfa66898f85e559bee6d8e7305d8451943ce9 | |
| parent | 6458abc925e8ade4ad02f4d69b0281f6b3da5e14 (diff) | |
[S390] zcrypt: Improve some comments
Improve the comments for switch cases without a break. This fixes
some warnings of a code checker tool.
Signed-off-by: Felix Beck <felix.beck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
| -rw-r--r-- | drivers/s390/crypto/zcrypt_pcixcc.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/s390/crypto/zcrypt_pcixcc.c b/drivers/s390/crypto/zcrypt_pcixcc.c index 2218cef1749b..5677b40e4ac0 100644 --- a/drivers/s390/crypto/zcrypt_pcixcc.c +++ b/drivers/s390/crypto/zcrypt_pcixcc.c | |||
| @@ -561,7 +561,8 @@ static int convert_response_ica(struct zcrypt_device *zdev, | |||
| 561 | if (msg->cprbx.cprb_ver_id == 0x02) | 561 | if (msg->cprbx.cprb_ver_id == 0x02) |
| 562 | return convert_type86_ica(zdev, reply, | 562 | return convert_type86_ica(zdev, reply, |
| 563 | outputdata, outputdatalength); | 563 | outputdata, outputdatalength); |
| 564 | /* no break, incorrect cprb version is an unknown response */ | 564 | /* Fall through, no break, incorrect cprb version is an unknown |
| 565 | * response */ | ||
| 565 | default: /* Unknown response type, this should NEVER EVER happen */ | 566 | default: /* Unknown response type, this should NEVER EVER happen */ |
| 566 | zdev->online = 0; | 567 | zdev->online = 0; |
| 567 | return -EAGAIN; /* repeat the request on a different device. */ | 568 | return -EAGAIN; /* repeat the request on a different device. */ |
| @@ -587,7 +588,8 @@ static int convert_response_xcrb(struct zcrypt_device *zdev, | |||
| 587 | } | 588 | } |
| 588 | if (msg->cprbx.cprb_ver_id == 0x02) | 589 | if (msg->cprbx.cprb_ver_id == 0x02) |
| 589 | return convert_type86_xcrb(zdev, reply, xcRB); | 590 | return convert_type86_xcrb(zdev, reply, xcRB); |
| 590 | /* no break, incorrect cprb version is an unknown response */ | 591 | /* Fall through, no break, incorrect cprb version is an unknown |
| 592 | * response */ | ||
| 591 | default: /* Unknown response type, this should NEVER EVER happen */ | 593 | default: /* Unknown response type, this should NEVER EVER happen */ |
| 592 | xcRB->status = 0x0008044DL; /* HDD_InvalidParm */ | 594 | xcRB->status = 0x0008044DL; /* HDD_InvalidParm */ |
| 593 | zdev->online = 0; | 595 | zdev->online = 0; |
| @@ -610,7 +612,8 @@ static int convert_response_rng(struct zcrypt_device *zdev, | |||
| 610 | return -EINVAL; | 612 | return -EINVAL; |
| 611 | if (msg->cprbx.cprb_ver_id == 0x02) | 613 | if (msg->cprbx.cprb_ver_id == 0x02) |
| 612 | return convert_type86_rng(zdev, reply, data); | 614 | return convert_type86_rng(zdev, reply, data); |
| 613 | /* no break, incorrect cprb version is an unknown response */ | 615 | /* Fall through, no break, incorrect cprb version is an unknown |
| 616 | * response */ | ||
| 614 | default: /* Unknown response type, this should NEVER EVER happen */ | 617 | default: /* Unknown response type, this should NEVER EVER happen */ |
| 615 | zdev->online = 0; | 618 | zdev->online = 0; |
| 616 | return -EAGAIN; /* repeat the request on a different device. */ | 619 | return -EAGAIN; /* repeat the request on a different device. */ |