diff options
author | Dave Jones <davej@redhat.com> | 2009-11-11 16:57:03 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-11-30 19:39:25 -0500 |
commit | 8c960e49d8beaca7c5b3967cede225bbba36bf43 (patch) | |
tree | 9921405430f94be245edb0db61b1c1c12f3dd8a8 | |
parent | a8a84540eb3fd0493f250dc1c513bef6810a50fd (diff) |
Staging: hv: Fix argument order in incorrect memset invocations in hyperv driver.
Nearly every invocation of memset in drivers/staging/hv/StorVsc.c has
its arguments the wrong way around.
Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/staging/hv/StorVsc.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/hv/StorVsc.c b/drivers/staging/hv/StorVsc.c index 14015c927940..2f7c425896f7 100644 --- a/drivers/staging/hv/StorVsc.c +++ b/drivers/staging/hv/StorVsc.c | |||
@@ -196,7 +196,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
196 | * Now, initiate the vsc/vsp initialization protocol on the open | 196 | * Now, initiate the vsc/vsp initialization protocol on the open |
197 | * channel | 197 | * channel |
198 | */ | 198 | */ |
199 | memset(request, sizeof(struct storvsc_request_extension), 0); | 199 | memset(request, 0, sizeof(struct storvsc_request_extension)); |
200 | request->WaitEvent = osd_WaitEventCreate(); | 200 | request->WaitEvent = osd_WaitEventCreate(); |
201 | 201 | ||
202 | vstorPacket->Operation = VStorOperationBeginInitialization; | 202 | vstorPacket->Operation = VStorOperationBeginInitialization; |
@@ -233,7 +233,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
233 | DPRINT_INFO(STORVSC, "QUERY_PROTOCOL_VERSION_OPERATION..."); | 233 | DPRINT_INFO(STORVSC, "QUERY_PROTOCOL_VERSION_OPERATION..."); |
234 | 234 | ||
235 | /* reuse the packet for version range supported */ | 235 | /* reuse the packet for version range supported */ |
236 | memset(vstorPacket, sizeof(struct vstor_packet), 0); | 236 | memset(vstorPacket, 0, sizeof(struct vstor_packet)); |
237 | vstorPacket->Operation = VStorOperationQueryProtocolVersion; | 237 | vstorPacket->Operation = VStorOperationQueryProtocolVersion; |
238 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; | 238 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; |
239 | 239 | ||
@@ -266,7 +266,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
266 | /* Query channel properties */ | 266 | /* Query channel properties */ |
267 | DPRINT_INFO(STORVSC, "QUERY_PROPERTIES_OPERATION..."); | 267 | DPRINT_INFO(STORVSC, "QUERY_PROPERTIES_OPERATION..."); |
268 | 268 | ||
269 | memset(vstorPacket, sizeof(struct vstor_packet), 0); | 269 | memset(vstorPacket, 0, sizeof(struct vstor_packet)); |
270 | vstorPacket->Operation = VStorOperationQueryProperties; | 270 | vstorPacket->Operation = VStorOperationQueryProperties; |
271 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; | 271 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; |
272 | vstorPacket->StorageChannelProperties.PortNumber = | 272 | vstorPacket->StorageChannelProperties.PortNumber = |
@@ -305,7 +305,7 @@ static int StorVscChannelInit(struct hv_device *Device) | |||
305 | 305 | ||
306 | DPRINT_INFO(STORVSC, "END_INITIALIZATION_OPERATION..."); | 306 | DPRINT_INFO(STORVSC, "END_INITIALIZATION_OPERATION..."); |
307 | 307 | ||
308 | memset(vstorPacket, sizeof(struct vstor_packet), 0); | 308 | memset(vstorPacket, 0, sizeof(struct vstor_packet)); |
309 | vstorPacket->Operation = VStorOperationEndInitialization; | 309 | vstorPacket->Operation = VStorOperationEndInitialization; |
310 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; | 310 | vstorPacket->Flags = REQUEST_COMPLETION_FLAG; |
311 | 311 | ||
@@ -508,7 +508,7 @@ static int StorVscConnectToVsp(struct hv_device *Device) | |||
508 | int ret; | 508 | int ret; |
509 | 509 | ||
510 | storDriver = (struct storvsc_driver_object *)Device->Driver; | 510 | storDriver = (struct storvsc_driver_object *)Device->Driver; |
511 | memset(&props, sizeof(struct vmstorage_channel_properties), 0); | 511 | memset(&props, 0, sizeof(struct vmstorage_channel_properties)); |
512 | 512 | ||
513 | /* Open the channel */ | 513 | /* Open the channel */ |
514 | ret = Device->Driver->VmbusChannelInterface.Open(Device, | 514 | ret = Device->Driver->VmbusChannelInterface.Open(Device, |