diff options
author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-02-28 17:08:54 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-02-28 17:08:54 -0500 |
commit | 7e0218099832d954d107f48de9e81bd521e16f24 (patch) | |
tree | 57d436b98a42d7eb977a8f6d031de1e2e8ae5100 | |
parent | 1e15dc981deb39056fa846fe55e1a1dbb175a98e (diff) |
[LLC]: Use proc_create() to setup ->proc_fops first
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/llc/llc_proc.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/net/llc/llc_proc.c b/net/llc/llc_proc.c index cb34bc0518e8..48212c0a961c 100644 --- a/net/llc/llc_proc.c +++ b/net/llc/llc_proc.c | |||
@@ -239,18 +239,14 @@ int __init llc_proc_init(void) | |||
239 | goto out; | 239 | goto out; |
240 | llc_proc_dir->owner = THIS_MODULE; | 240 | llc_proc_dir->owner = THIS_MODULE; |
241 | 241 | ||
242 | p = create_proc_entry("socket", S_IRUGO, llc_proc_dir); | 242 | p = proc_create("socket", S_IRUGO, llc_proc_dir, &llc_seq_socket_fops); |
243 | if (!p) | 243 | if (!p) |
244 | goto out_socket; | 244 | goto out_socket; |
245 | 245 | ||
246 | p->proc_fops = &llc_seq_socket_fops; | 246 | p = proc_create("core", S_IRUGO, llc_proc_dir, &llc_seq_core_fops); |
247 | |||
248 | p = create_proc_entry("core", S_IRUGO, llc_proc_dir); | ||
249 | if (!p) | 247 | if (!p) |
250 | goto out_core; | 248 | goto out_core; |
251 | 249 | ||
252 | p->proc_fops = &llc_seq_core_fops; | ||
253 | |||
254 | rc = 0; | 250 | rc = 0; |
255 | out: | 251 | out: |
256 | return rc; | 252 | return rc; |