aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlan Stern <stern@rowland.harvard.edu>2007-01-08 11:12:32 -0500
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>2007-02-16 12:22:55 -0500
commit7c9d6f16f50d3aeb780e4f103a1ba8b35d9ae803 (patch)
tree4e1920eff9a26682e35ae7fc31f01411ab8a0289
parent74feb53e8b5020e790e12c6331cbe885d276cc60 (diff)
[SCSI] SCSI core: better initialization for sdev->scsi_level
This patch will affect the CDB in INQUIRY commands sent to LUNs above 0 when LUN-0 reports a scsi_level of 0; the LUN bits will no longer be set in the second byte of the CDB. This is as it should be. Nevertheless, it's possible that some wacky device might be adversely affected. I doubt anyone will complain... Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r--drivers/scsi/scsi_scan.c1
-rw-r--r--drivers/scsi/scsi_sysfs.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 7757e558d523..6905ffd135b3 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -385,6 +385,7 @@ static struct scsi_target *scsi_alloc_target(struct device *parent,
385 INIT_LIST_HEAD(&starget->siblings); 385 INIT_LIST_HEAD(&starget->siblings);
386 INIT_LIST_HEAD(&starget->devices); 386 INIT_LIST_HEAD(&starget->devices);
387 starget->state = STARGET_RUNNING; 387 starget->state = STARGET_RUNNING;
388 starget->scsi_level = SCSI_2;
388 retry: 389 retry:
389 spin_lock_irqsave(shost->host_lock, flags); 390 spin_lock_irqsave(shost->host_lock, flags);
390 391
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 259c90cfa367..c275dcac3f18 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -922,7 +922,7 @@ void scsi_sysfs_device_initialize(struct scsi_device *sdev)
922 snprintf(sdev->sdev_classdev.class_id, BUS_ID_SIZE, 922 snprintf(sdev->sdev_classdev.class_id, BUS_ID_SIZE,
923 "%d:%d:%d:%d", sdev->host->host_no, 923 "%d:%d:%d:%d", sdev->host->host_no,
924 sdev->channel, sdev->id, sdev->lun); 924 sdev->channel, sdev->id, sdev->lun);
925 sdev->scsi_level = SCSI_2; 925 sdev->scsi_level = starget->scsi_level;
926 transport_setup_device(&sdev->sdev_gendev); 926 transport_setup_device(&sdev->sdev_gendev);
927 spin_lock_irqsave(shost->host_lock, flags); 927 spin_lock_irqsave(shost->host_lock, flags);
928 list_add_tail(&sdev->same_target_siblings, &starget->devices); 928 list_add_tail(&sdev->same_target_siblings, &starget->devices);