diff options
| author | Ahmed S. Darwish <darwish.07@gmail.com> | 2008-02-17 17:59:54 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-02-19 10:18:34 -0500 |
| commit | 7c6357da1185d286adaa4452d829ac9b27c4d12f (patch) | |
| tree | 083ea8780740a262fb55616b05ec7055f17fb73f | |
| parent | 3f85d63ea4ff922f6abdb509f4aaf6993b3273a3 (diff) | |
x86: i8259A: remove redundant irq_descinitialization
Remove redundant irq_desc[NR_IRQS] element initialization in
init_ISA_irqs(). irq_desc[NR_IRQS] is already statically
initialized with the same values in kernel/irq/handle.c .
besides the clean-up value this also saves some space:
text data bss dec hex filename
1389 356 14 1759 6df i8259_32.o.before
1325 356 14 1695 69f i8259_32.o.after
Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
| -rw-r--r-- | arch/x86/kernel/i8259_32.c | 25 |
1 files changed, 6 insertions, 19 deletions
diff --git a/arch/x86/kernel/i8259_32.c b/arch/x86/kernel/i8259_32.c index 2d25b77102fe..fe631967d625 100644 --- a/arch/x86/kernel/i8259_32.c +++ b/arch/x86/kernel/i8259_32.c | |||
| @@ -26,8 +26,6 @@ | |||
| 26 | * present in the majority of PC/AT boxes. | 26 | * present in the majority of PC/AT boxes. |
| 27 | * plus some generic x86 specific things if generic specifics makes | 27 | * plus some generic x86 specific things if generic specifics makes |
| 28 | * any sense at all. | 28 | * any sense at all. |
| 29 | * this file should become arch/i386/kernel/irq.c when the old irq.c | ||
| 30 | * moves to arch independent land | ||
| 31 | */ | 29 | */ |
| 32 | 30 | ||
| 33 | static int i8259A_auto_eoi; | 31 | static int i8259A_auto_eoi; |
| @@ -362,23 +360,12 @@ void __init init_ISA_irqs (void) | |||
| 362 | #endif | 360 | #endif |
| 363 | init_8259A(0); | 361 | init_8259A(0); |
| 364 | 362 | ||
| 365 | for (i = 0; i < NR_IRQS; i++) { | 363 | /* |
| 366 | irq_desc[i].status = IRQ_DISABLED; | 364 | * 16 old-style INTA-cycle interrupts: |
| 367 | irq_desc[i].action = NULL; | 365 | */ |
| 368 | irq_desc[i].depth = 1; | 366 | for (i = 0; i < 16; i++) { |
| 369 | 367 | set_irq_chip_and_handler_name(i, &i8259A_chip, | |
| 370 | if (i < 16) { | 368 | handle_level_irq, "XT"); |
| 371 | /* | ||
| 372 | * 16 old-style INTA-cycle interrupts: | ||
| 373 | */ | ||
| 374 | set_irq_chip_and_handler_name(i, &i8259A_chip, | ||
| 375 | handle_level_irq, "XT"); | ||
| 376 | } else { | ||
| 377 | /* | ||
| 378 | * 'high' PCI IRQs filled in on demand | ||
| 379 | */ | ||
| 380 | irq_desc[i].chip = &no_irq_chip; | ||
| 381 | } | ||
| 382 | } | 369 | } |
| 383 | } | 370 | } |
| 384 | 371 | ||
