aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2006-03-22 01:48:34 -0500
committerMauro Carvalho Chehab <mchehab@infradead.org>2006-03-23 09:24:28 -0500
commit5a313c59bcc5062fc56088d5ff9289828c4b6626 (patch)
tree689cfceb1a7dbc8a80ef9e93f5efde1156a80ffe
parent2467a670ee24631b05e91971286730e71f6a6af0 (diff)
V4L/DVB (3568j): adv7175: Drop unused encoder dump command
Drop support for the ENCODER_DUMP command in the adv7175 driver. ENCODER_DUMP was never actually defined as far as I can see, so the code was ifdef'd out, and I suspect it was never used, not even once, as it includes an obvious array overrun. The register values of this specific chip can be dumped in a generic way using the i2c-dev driver and the "i2cdump" user-space tool if it is ever really needed. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
-rw-r--r--drivers/media/video/adv7175.c26
1 files changed, 0 insertions, 26 deletions
diff --git a/drivers/media/video/adv7175.c b/drivers/media/video/adv7175.c
index 245f94265758..ca86de0c2805 100644
--- a/drivers/media/video/adv7175.c
+++ b/drivers/media/video/adv7175.c
@@ -165,24 +165,6 @@ set_subcarrier_freq (struct i2c_client *client,
165 adv7175_write(client, 0x05, 0x25); 165 adv7175_write(client, 0x05, 0x25);
166} 166}
167 167
168#ifdef ENCODER_DUMP
169static void
170dump (struct i2c_client *client)
171{
172 struct adv7175 *encoder = i2c_get_clientdata(client);
173 int i, j;
174
175 printk(KERN_INFO "%s: registry dump\n", I2C_NAME(client));
176 for (i = 0; i < 182 / 8; i++) {
177 printk("%s: 0x%02x -", I2C_NAME(client), i * 8);
178 for (j = 0; j < 8; j++) {
179 printk(" 0x%02x", encoder->reg[i * 8 + j]);
180 }
181 printk("\n");
182 }
183}
184#endif
185
186/* ----------------------------------------------------------------------- */ 168/* ----------------------------------------------------------------------- */
187// Output filter: S-Video Composite 169// Output filter: S-Video Composite
188 170
@@ -401,14 +383,6 @@ adv7175_command (struct i2c_client *client,
401 } 383 }
402 break; 384 break;
403 385
404#ifdef ENCODER_DUMP
405 case ENCODER_DUMP:
406 {
407 dump(client);
408 }
409 break;
410#endif
411
412 default: 386 default:
413 return -EINVAL; 387 return -EINVAL;
414 } 388 }