diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2009-06-23 15:36:08 -0400 |
|---|---|---|
| committer | Robert Richter <robert.richter@amd.com> | 2009-08-04 10:02:01 -0400 |
| commit | 4680e64a88c4ce2c4e736dade99233e3def13fa7 (patch) | |
| tree | 0577ed4d742e0e0adc882aef4e9a9106ec6c4a14 | |
| parent | 54a0bf3c2cad3fd118ea725f26a493aece6ea01d (diff) | |
arch/x86/oprofile/op_model_amd.c: fix op_amd_handle_ibs() return type
arch/x86/oprofile/op_model_amd.c: In function 'op_amd_handle_ibs':
arch/x86/oprofile/op_model_amd.c:217: warning: no return statement in function returning non-void
Fix this by making op_amd_handle_ibs() return void.
Cc: Robert Richter <robert.richter@amd.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Robert Richter <robert.richter@amd.com>
| -rw-r--r-- | arch/x86/oprofile/op_model_amd.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/arch/x86/oprofile/op_model_amd.c b/arch/x86/oprofile/op_model_amd.c index 37d19c768d5f..39686c29f03a 100644 --- a/arch/x86/oprofile/op_model_amd.c +++ b/arch/x86/oprofile/op_model_amd.c | |||
| @@ -187,7 +187,7 @@ static void op_amd_setup_ctrs(struct op_x86_model_spec const *model, | |||
| 187 | 187 | ||
| 188 | #ifdef CONFIG_OPROFILE_IBS | 188 | #ifdef CONFIG_OPROFILE_IBS |
| 189 | 189 | ||
| 190 | static inline int | 190 | static inline void |
| 191 | op_amd_handle_ibs(struct pt_regs * const regs, | 191 | op_amd_handle_ibs(struct pt_regs * const regs, |
| 192 | struct op_msrs const * const msrs) | 192 | struct op_msrs const * const msrs) |
| 193 | { | 193 | { |
| @@ -195,7 +195,7 @@ op_amd_handle_ibs(struct pt_regs * const regs, | |||
| 195 | struct op_entry entry; | 195 | struct op_entry entry; |
| 196 | 196 | ||
| 197 | if (!has_ibs) | 197 | if (!has_ibs) |
| 198 | return 1; | 198 | return; |
| 199 | 199 | ||
| 200 | if (ibs_config.fetch_enabled) { | 200 | if (ibs_config.fetch_enabled) { |
| 201 | rdmsrl(MSR_AMD64_IBSFETCHCTL, ctl); | 201 | rdmsrl(MSR_AMD64_IBSFETCHCTL, ctl); |
| @@ -241,8 +241,6 @@ op_amd_handle_ibs(struct pt_regs * const regs, | |||
| 241 | wrmsrl(MSR_AMD64_IBSOPCTL, ctl); | 241 | wrmsrl(MSR_AMD64_IBSOPCTL, ctl); |
| 242 | } | 242 | } |
| 243 | } | 243 | } |
| 244 | |||
| 245 | return 1; | ||
| 246 | } | 244 | } |
| 247 | 245 | ||
| 248 | static inline void op_amd_start_ibs(void) | 246 | static inline void op_amd_start_ibs(void) |
| @@ -276,7 +274,7 @@ static void op_amd_stop_ibs(void) | |||
| 276 | 274 | ||
| 277 | #else | 275 | #else |
| 278 | 276 | ||
| 279 | static inline int op_amd_handle_ibs(struct pt_regs * const regs, | 277 | static inline void op_amd_handle_ibs(struct pt_regs * const regs, |
| 280 | struct op_msrs const * const msrs) { } | 278 | struct op_msrs const * const msrs) { } |
| 281 | static inline void op_amd_start_ibs(void) { } | 279 | static inline void op_amd_start_ibs(void) { } |
| 282 | static inline void op_amd_stop_ibs(void) { } | 280 | static inline void op_amd_stop_ibs(void) { } |
