diff options
| author | Joe Perches <joe@perches.com> | 2010-03-26 16:16:59 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-31 02:02:27 -0400 |
| commit | 2c73e1fe94b1962ae5df7618519c18526e9d9072 (patch) | |
| tree | 4997c483a1a3c50a3afc92c093324e74a8859a2d | |
| parent | c041076a9f79a7cf28e808f73cc76f24cbf97093 (diff) | |
e1000e: typo corrections
Here are the other miscellaneous corrections
done by an earlier larger suggested patch now
made unnecessary by a less invasive change.
Correct a few missing newlines from logging
messages and a typo fix. Fix speed/duplex
logging message.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/e1000e/82571.c | 2 | ||||
| -rw-r--r-- | drivers/net/e1000e/ich8lan.c | 6 | ||||
| -rw-r--r-- | drivers/net/e1000e/lib.c | 21 |
3 files changed, 13 insertions, 16 deletions
diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c index 712ccc66ba25..4b0016d69530 100644 --- a/drivers/net/e1000e/82571.c +++ b/drivers/net/e1000e/82571.c | |||
| @@ -323,7 +323,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter) | |||
| 323 | } | 323 | } |
| 324 | 324 | ||
| 325 | /* | 325 | /* |
| 326 | * Initialze device specific counter of SMBI acquisition | 326 | * Initialize device specific counter of SMBI acquisition |
| 327 | * timeouts. | 327 | * timeouts. |
| 328 | */ | 328 | */ |
| 329 | hw->dev_spec.e82571.smb_counter = 0; | 329 | hw->dev_spec.e82571.smb_counter = 0; |
diff --git a/drivers/net/e1000e/ich8lan.c b/drivers/net/e1000e/ich8lan.c index 8b5e157e9c87..5059c22155d9 100644 --- a/drivers/net/e1000e/ich8lan.c +++ b/drivers/net/e1000e/ich8lan.c | |||
| @@ -1622,7 +1622,7 @@ static s32 e1000_flash_cycle_init_ich8lan(struct e1000_hw *hw) | |||
| 1622 | /* Check if the flash descriptor is valid */ | 1622 | /* Check if the flash descriptor is valid */ |
| 1623 | if (hsfsts.hsf_status.fldesvalid == 0) { | 1623 | if (hsfsts.hsf_status.fldesvalid == 0) { |
| 1624 | e_dbg("Flash descriptor invalid. " | 1624 | e_dbg("Flash descriptor invalid. " |
| 1625 | "SW Sequencing must be used."); | 1625 | "SW Sequencing must be used.\n"); |
| 1626 | return -E1000_ERR_NVM; | 1626 | return -E1000_ERR_NVM; |
| 1627 | } | 1627 | } |
| 1628 | 1628 | ||
| @@ -1671,7 +1671,7 @@ static s32 e1000_flash_cycle_init_ich8lan(struct e1000_hw *hw) | |||
| 1671 | hsfsts.hsf_status.flcdone = 1; | 1671 | hsfsts.hsf_status.flcdone = 1; |
| 1672 | ew16flash(ICH_FLASH_HSFSTS, hsfsts.regval); | 1672 | ew16flash(ICH_FLASH_HSFSTS, hsfsts.regval); |
| 1673 | } else { | 1673 | } else { |
| 1674 | e_dbg("Flash controller busy, cannot get access"); | 1674 | e_dbg("Flash controller busy, cannot get access\n"); |
| 1675 | } | 1675 | } |
| 1676 | } | 1676 | } |
| 1677 | 1677 | ||
| @@ -1822,7 +1822,7 @@ static s32 e1000_read_flash_data_ich8lan(struct e1000_hw *hw, u32 offset, | |||
| 1822 | continue; | 1822 | continue; |
| 1823 | } else if (hsfsts.hsf_status.flcdone == 0) { | 1823 | } else if (hsfsts.hsf_status.flcdone == 0) { |
| 1824 | e_dbg("Timeout error - flash cycle " | 1824 | e_dbg("Timeout error - flash cycle " |
| 1825 | "did not complete."); | 1825 | "did not complete.\n"); |
| 1826 | break; | 1826 | break; |
| 1827 | } | 1827 | } |
| 1828 | } | 1828 | } |
diff --git a/drivers/net/e1000e/lib.c b/drivers/net/e1000e/lib.c index a8b2c0de27c4..b0d2a60aa490 100644 --- a/drivers/net/e1000e/lib.c +++ b/drivers/net/e1000e/lib.c | |||
| @@ -1262,24 +1262,21 @@ s32 e1000e_get_speed_and_duplex_copper(struct e1000_hw *hw, u16 *speed, u16 *dup | |||
| 1262 | u32 status; | 1262 | u32 status; |
| 1263 | 1263 | ||
| 1264 | status = er32(STATUS); | 1264 | status = er32(STATUS); |
| 1265 | if (status & E1000_STATUS_SPEED_1000) { | 1265 | if (status & E1000_STATUS_SPEED_1000) |
| 1266 | *speed = SPEED_1000; | 1266 | *speed = SPEED_1000; |
| 1267 | e_dbg("1000 Mbs, "); | 1267 | else if (status & E1000_STATUS_SPEED_100) |
| 1268 | } else if (status & E1000_STATUS_SPEED_100) { | ||
| 1269 | *speed = SPEED_100; | 1268 | *speed = SPEED_100; |
| 1270 | e_dbg("100 Mbs, "); | 1269 | else |
| 1271 | } else { | ||
| 1272 | *speed = SPEED_10; | 1270 | *speed = SPEED_10; |
| 1273 | e_dbg("10 Mbs, "); | ||
| 1274 | } | ||
| 1275 | 1271 | ||
| 1276 | if (status & E1000_STATUS_FD) { | 1272 | if (status & E1000_STATUS_FD) |
| 1277 | *duplex = FULL_DUPLEX; | 1273 | *duplex = FULL_DUPLEX; |
| 1278 | e_dbg("Full Duplex\n"); | 1274 | else |
| 1279 | } else { | ||
| 1280 | *duplex = HALF_DUPLEX; | 1275 | *duplex = HALF_DUPLEX; |
| 1281 | e_dbg("Half Duplex\n"); | 1276 | |
| 1282 | } | 1277 | e_dbg("%u Mbps, %s Duplex\n", |
| 1278 | *speed == SPEED_1000 ? 1000 : *speed == SPEED_100 ? 100 : 10, | ||
| 1279 | *duplex == FULL_DUPLEX ? "Full" : "Half"); | ||
| 1283 | 1280 | ||
| 1284 | return 0; | 1281 | return 0; |
| 1285 | } | 1282 | } |
