diff options
| author | Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> | 2010-08-18 08:11:11 -0400 |
|---|---|---|
| committer | Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> | 2010-08-18 11:11:06 -0400 |
| commit | 1cb0c924fa2d616e5e3b5bc62d97191aac9ff442 (patch) | |
| tree | 199a9ffc425033d27620e70d8ffd44a9e44ad931 | |
| parent | 3b89f56783a4ef796190ef1192c25e72e0b986b6 (diff) | |
nilfs2: wait for discard to finish
nilfs_discard_segment() doesn't wait for completion of discard
requests. This specifies BLKDEV_IFL_WAIT flag when calling
blkdev_issue_discard() in order to fix the sync failure.
Reported-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | fs/nilfs2/the_nilfs.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index 6af1c0073e9e..4317f177ea7c 100644 --- a/fs/nilfs2/the_nilfs.c +++ b/fs/nilfs2/the_nilfs.c | |||
| @@ -775,6 +775,7 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump, | |||
| 775 | start * sects_per_block, | 775 | start * sects_per_block, |
| 776 | nblocks * sects_per_block, | 776 | nblocks * sects_per_block, |
| 777 | GFP_NOFS, | 777 | GFP_NOFS, |
| 778 | BLKDEV_IFL_WAIT | | ||
| 778 | BLKDEV_IFL_BARRIER); | 779 | BLKDEV_IFL_BARRIER); |
| 779 | if (ret < 0) | 780 | if (ret < 0) |
| 780 | return ret; | 781 | return ret; |
| @@ -785,7 +786,8 @@ int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump, | |||
| 785 | ret = blkdev_issue_discard(nilfs->ns_bdev, | 786 | ret = blkdev_issue_discard(nilfs->ns_bdev, |
| 786 | start * sects_per_block, | 787 | start * sects_per_block, |
| 787 | nblocks * sects_per_block, | 788 | nblocks * sects_per_block, |
| 788 | GFP_NOFS, BLKDEV_IFL_BARRIER); | 789 | GFP_NOFS, |
| 790 | BLKDEV_IFL_WAIT | BLKDEV_IFL_BARRIER); | ||
| 789 | return ret; | 791 | return ret; |
| 790 | } | 792 | } |
| 791 | 793 | ||
