diff options
| author | Jarkko Nikula <jhnikula@gmail.com> | 2010-03-26 10:07:25 -0400 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2010-03-26 10:26:38 -0400 |
| commit | 0f17014b340b98465fcf0de4c0d6c84a002ec53b (patch) | |
| tree | c673482b4147cb5cbb9a180496569482e291ccbf | |
| parent | e1f7f02b45cf33a774d56e505ce1718af9392f5e (diff) | |
ALSA: pcm_lib - fix xrun functionality
The commit 4d96eb255c53ab5e39b37fd4d484ea3dc39ab456 broke the interrupt
time xrun functionality (stream stop etc.) if the CONFIG_SND_PCM_XRUN_DEBUG
is not set. This is because the xrun() is null defined without it.
Fix this by letting the function xrun() to be always defined as it was
before.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/core/pcm_lib.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index b546ac2660f9..a2ff86189d2a 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c | |||
| @@ -148,6 +148,9 @@ static void pcm_debug_name(struct snd_pcm_substream *substream, | |||
| 148 | 148 | ||
| 149 | #define xrun_debug(substream, mask) \ | 149 | #define xrun_debug(substream, mask) \ |
| 150 | ((substream)->pstr->xrun_debug & (mask)) | 150 | ((substream)->pstr->xrun_debug & (mask)) |
| 151 | #else | ||
| 152 | #define xrun_debug(substream, mask) 0 | ||
| 153 | #endif | ||
| 151 | 154 | ||
| 152 | #define dump_stack_on_xrun(substream) do { \ | 155 | #define dump_stack_on_xrun(substream) do { \ |
| 153 | if (xrun_debug(substream, XRUN_DEBUG_STACK)) \ | 156 | if (xrun_debug(substream, XRUN_DEBUG_STACK)) \ |
| @@ -169,6 +172,7 @@ static void xrun(struct snd_pcm_substream *substream) | |||
| 169 | } | 172 | } |
| 170 | } | 173 | } |
| 171 | 174 | ||
| 175 | #ifdef CONFIG_SND_PCM_XRUN_DEBUG | ||
| 172 | #define hw_ptr_error(substream, fmt, args...) \ | 176 | #define hw_ptr_error(substream, fmt, args...) \ |
| 173 | do { \ | 177 | do { \ |
| 174 | if (xrun_debug(substream, XRUN_DEBUG_BASIC)) { \ | 178 | if (xrun_debug(substream, XRUN_DEBUG_BASIC)) { \ |
| @@ -255,8 +259,6 @@ static void xrun_log_show(struct snd_pcm_substream *substream) | |||
| 255 | 259 | ||
| 256 | #else /* ! CONFIG_SND_PCM_XRUN_DEBUG */ | 260 | #else /* ! CONFIG_SND_PCM_XRUN_DEBUG */ |
| 257 | 261 | ||
| 258 | #define xrun_debug(substream, mask) 0 | ||
| 259 | #define xrun(substream) do { } while (0) | ||
| 260 | #define hw_ptr_error(substream, fmt, args...) do { } while (0) | 262 | #define hw_ptr_error(substream, fmt, args...) do { } while (0) |
| 261 | #define xrun_log(substream, pos) do { } while (0) | 263 | #define xrun_log(substream, pos) do { } while (0) |
| 262 | #define xrun_log_show(substream) do { } while (0) | 264 | #define xrun_log_show(substream) do { } while (0) |
