diff options
author | Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> | 2011-07-11 15:28:54 -0400 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2011-07-24 04:50:34 -0400 |
commit | fce92dce79dbf5fff39c7ac2fb149729d79b7a39 (patch) | |
tree | 455461b843f5f94356786ea0e21132740458588a | |
parent | c37079586f317d7e7f1a70d36f0e5177691c89c2 (diff) |
KVM: MMU: filter out the mmio pfn from the fault pfn
If the page fault is caused by mmio, the gfn can not be found in memslots, and
'bad_pfn' is returned on gfn_to_hva path, so we can use 'bad_pfn' to identify
the mmio page fault.
And, to clarify the meaning of mmio pfn, we return fault page instead of bad
page when the gfn is not allowd to prefetch
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
-rw-r--r-- | arch/x86/kvm/mmu.c | 4 | ||||
-rw-r--r-- | include/linux/kvm_host.h | 5 | ||||
-rw-r--r-- | virt/kvm/kvm_main.c | 16 |
3 files changed, 21 insertions, 4 deletions
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 5334b4e9ecc7..96a7ed4e6837 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c | |||
@@ -2085,8 +2085,8 @@ static pfn_t pte_prefetch_gfn_to_pfn(struct kvm_vcpu *vcpu, gfn_t gfn, | |||
2085 | 2085 | ||
2086 | slot = gfn_to_memslot_dirty_bitmap(vcpu, gfn, no_dirty_log); | 2086 | slot = gfn_to_memslot_dirty_bitmap(vcpu, gfn, no_dirty_log); |
2087 | if (!slot) { | 2087 | if (!slot) { |
2088 | get_page(bad_page); | 2088 | get_page(fault_page); |
2089 | return page_to_pfn(bad_page); | 2089 | return page_to_pfn(fault_page); |
2090 | } | 2090 | } |
2091 | 2091 | ||
2092 | hva = gfn_to_hva_memslot(slot, gfn); | 2092 | hva = gfn_to_hva_memslot(slot, gfn); |
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index c8e023902f79..eabb21a30c34 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h | |||
@@ -327,12 +327,17 @@ static inline struct kvm_memslots *kvm_memslots(struct kvm *kvm) | |||
327 | static inline int is_error_hpa(hpa_t hpa) { return hpa >> HPA_MSB; } | 327 | static inline int is_error_hpa(hpa_t hpa) { return hpa >> HPA_MSB; } |
328 | 328 | ||
329 | extern struct page *bad_page; | 329 | extern struct page *bad_page; |
330 | extern struct page *fault_page; | ||
331 | |||
330 | extern pfn_t bad_pfn; | 332 | extern pfn_t bad_pfn; |
333 | extern pfn_t fault_pfn; | ||
331 | 334 | ||
332 | int is_error_page(struct page *page); | 335 | int is_error_page(struct page *page); |
333 | int is_error_pfn(pfn_t pfn); | 336 | int is_error_pfn(pfn_t pfn); |
334 | int is_hwpoison_pfn(pfn_t pfn); | 337 | int is_hwpoison_pfn(pfn_t pfn); |
335 | int is_fault_pfn(pfn_t pfn); | 338 | int is_fault_pfn(pfn_t pfn); |
339 | int is_noslot_pfn(pfn_t pfn); | ||
340 | int is_invalid_pfn(pfn_t pfn); | ||
336 | int kvm_is_error_hva(unsigned long addr); | 341 | int kvm_is_error_hva(unsigned long addr); |
337 | int kvm_set_memory_region(struct kvm *kvm, | 342 | int kvm_set_memory_region(struct kvm *kvm, |
338 | struct kvm_userspace_memory_region *mem, | 343 | struct kvm_userspace_memory_region *mem, |
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index d5ef9ebcaff7..56f3c704fd74 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c | |||
@@ -101,8 +101,8 @@ static bool largepages_enabled = true; | |||
101 | static struct page *hwpoison_page; | 101 | static struct page *hwpoison_page; |
102 | static pfn_t hwpoison_pfn; | 102 | static pfn_t hwpoison_pfn; |
103 | 103 | ||
104 | static struct page *fault_page; | 104 | struct page *fault_page; |
105 | static pfn_t fault_pfn; | 105 | pfn_t fault_pfn; |
106 | 106 | ||
107 | inline int kvm_is_mmio_pfn(pfn_t pfn) | 107 | inline int kvm_is_mmio_pfn(pfn_t pfn) |
108 | { | 108 | { |
@@ -931,6 +931,18 @@ int is_fault_pfn(pfn_t pfn) | |||
931 | } | 931 | } |
932 | EXPORT_SYMBOL_GPL(is_fault_pfn); | 932 | EXPORT_SYMBOL_GPL(is_fault_pfn); |
933 | 933 | ||
934 | int is_noslot_pfn(pfn_t pfn) | ||
935 | { | ||
936 | return pfn == bad_pfn; | ||
937 | } | ||
938 | EXPORT_SYMBOL_GPL(is_noslot_pfn); | ||
939 | |||
940 | int is_invalid_pfn(pfn_t pfn) | ||
941 | { | ||
942 | return pfn == hwpoison_pfn || pfn == fault_pfn; | ||
943 | } | ||
944 | EXPORT_SYMBOL_GPL(is_invalid_pfn); | ||
945 | |||
934 | static inline unsigned long bad_hva(void) | 946 | static inline unsigned long bad_hva(void) |
935 | { | 947 | { |
936 | return PAGE_OFFSET; | 948 | return PAGE_OFFSET; |