diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2012-07-13 04:09:33 -0400 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@linux.intel.com> | 2012-07-16 02:33:07 -0400 |
| commit | f8609c2b528331c38293bb8082a91701256d3fc1 (patch) | |
| tree | 912e86414141bd89a4167fe86d2b4322b5971860 | |
| parent | 93aad1bcc591c5138a5858a9cde637002e09ab4e (diff) | |
dw_dmac: use 'u32' for LLI structure members, not dma_addr_t
Use 'u32' for the LLI structure members, which are defined by hardware to be
32-bit. dma_addr_t is much more vague about its actual size.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
| -rw-r--r-- | drivers/dma/dw_dmac.c | 7 | ||||
| -rw-r--r-- | drivers/dma/dw_dmac_regs.h | 6 |
2 files changed, 5 insertions, 8 deletions
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 600634982b4c..57beb5c8e3fd 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c | |||
| @@ -414,11 +414,8 @@ static void dwc_scan_descriptors(struct dw_dma *dw, struct dw_dma_chan *dwc) | |||
| 414 | static inline void dwc_dump_lli(struct dw_dma_chan *dwc, struct dw_lli *lli) | 414 | static inline void dwc_dump_lli(struct dw_dma_chan *dwc, struct dw_lli *lli) |
| 415 | { | 415 | { |
| 416 | dev_printk(KERN_CRIT, chan2dev(&dwc->chan), | 416 | dev_printk(KERN_CRIT, chan2dev(&dwc->chan), |
| 417 | " desc: s0x%llx d0x%llx l0x%llx c0x%x:%x\n", | 417 | " desc: s0x%x d0x%x l0x%x c0x%x:%x\n", |
| 418 | (unsigned long long)lli->sar, | 418 | lli->sar, lli->dar, lli->llp, lli->ctlhi, lli->ctllo); |
| 419 | (unsigned long long)lli->dar, | ||
| 420 | (unsigned long long)lli->llp, | ||
| 421 | lli->ctlhi, lli->ctllo); | ||
| 422 | } | 419 | } |
| 423 | 420 | ||
| 424 | static void dwc_handle_error(struct dw_dma *dw, struct dw_dma_chan *dwc) | 421 | static void dwc_handle_error(struct dw_dma *dw, struct dw_dma_chan *dwc) |
diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw_dmac_regs.h index e248481ad5f1..50830bee087a 100644 --- a/drivers/dma/dw_dmac_regs.h +++ b/drivers/dma/dw_dmac_regs.h | |||
| @@ -219,9 +219,9 @@ static inline struct dw_dma *to_dw_dma(struct dma_device *ddev) | |||
| 219 | /* LLI == Linked List Item; a.k.a. DMA block descriptor */ | 219 | /* LLI == Linked List Item; a.k.a. DMA block descriptor */ |
| 220 | struct dw_lli { | 220 | struct dw_lli { |
| 221 | /* values that are not changed by hardware */ | 221 | /* values that are not changed by hardware */ |
| 222 | dma_addr_t sar; | 222 | u32 sar; |
| 223 | dma_addr_t dar; | 223 | u32 dar; |
| 224 | dma_addr_t llp; /* chain to next lli */ | 224 | u32 llp; /* chain to next lli */ |
| 225 | u32 ctllo; | 225 | u32 ctllo; |
| 226 | /* values that may get written back: */ | 226 | /* values that may get written back: */ |
| 227 | u32 ctlhi; | 227 | u32 ctlhi; |
