diff options
| author | Chris Mason <clm@fb.com> | 2014-08-20 10:15:33 -0400 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-08-21 10:55:31 -0400 |
| commit | f6dc45c7a93a011dff6eb9b2ffda59c390c7705a (patch) | |
| tree | 87b8c5b7982c6063f43015079efa172f1c4caf27 | |
| parent | 38c1c2e44bacb37efd68b90b3f70386a8ee370ee (diff) | |
Btrfs: fix filemap_flush call in btrfs_file_release
We should only be flushing on close if the file was flagged as needing
it during truncate. I broke this with my ordered data vs transaction
commit deadlock fix.
Thanks to Miao Xie for catching this.
Signed-off-by: Chris Mason <clm@fb.com>
Reported-by: Miao Xie <miaox@cn.fujitsu.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
| -rw-r--r-- | fs/btrfs/file.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index f15c13f97018..36861b7a6757 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c | |||
| @@ -1840,7 +1840,15 @@ int btrfs_release_file(struct inode *inode, struct file *filp) | |||
| 1840 | { | 1840 | { |
| 1841 | if (filp->private_data) | 1841 | if (filp->private_data) |
| 1842 | btrfs_ioctl_trans_end(filp); | 1842 | btrfs_ioctl_trans_end(filp); |
| 1843 | filemap_flush(inode->i_mapping); | 1843 | /* |
| 1844 | * ordered_data_close is set by settattr when we are about to truncate | ||
| 1845 | * a file from a non-zero size to a zero size. This tries to | ||
| 1846 | * flush down new bytes that may have been written if the | ||
| 1847 | * application were using truncate to replace a file in place. | ||
| 1848 | */ | ||
| 1849 | if (test_and_clear_bit(BTRFS_INODE_ORDERED_DATA_CLOSE, | ||
| 1850 | &BTRFS_I(inode)->runtime_flags)) | ||
| 1851 | filemap_flush(inode->i_mapping); | ||
| 1844 | return 0; | 1852 | return 0; |
| 1845 | } | 1853 | } |
| 1846 | 1854 | ||
