diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2009-05-08 12:52:24 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-05-08 14:36:59 -0400 |
commit | f370e1e2f195ec1e6420e26fc83e0319595db578 (patch) | |
tree | 08276ee556bbc91d4d5f3ccee05d930efbca77ef | |
parent | a85f61abe11a46553c4562e74edb27ebc782aeb7 (diff) |
perf_counter: add PERF_RECORD_CPU
Allow recording the CPU number the event was generated on.
RFC: this leaves a u32 as reserved, should we fill in the
node_id() there, or leave this open for future extention,
as userspace can already easily do the cpu->node mapping
if needed.
[ Impact: extend perfcounter output record format ]
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
LKML-Reference: <20090508170029.008627711@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | include/linux/perf_counter.h | 2 | ||||
-rw-r--r-- | kernel/perf_counter.c | 13 |
2 files changed, 15 insertions, 0 deletions
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h index 0e6303d36c66..614f921d616a 100644 --- a/include/linux/perf_counter.h +++ b/include/linux/perf_counter.h | |||
@@ -105,6 +105,7 @@ enum perf_counter_record_format { | |||
105 | PERF_RECORD_GROUP = 1U << 4, | 105 | PERF_RECORD_GROUP = 1U << 4, |
106 | PERF_RECORD_CALLCHAIN = 1U << 5, | 106 | PERF_RECORD_CALLCHAIN = 1U << 5, |
107 | PERF_RECORD_CONFIG = 1U << 6, | 107 | PERF_RECORD_CONFIG = 1U << 6, |
108 | PERF_RECORD_CPU = 1U << 7, | ||
108 | }; | 109 | }; |
109 | 110 | ||
110 | /* | 111 | /* |
@@ -260,6 +261,7 @@ enum perf_event_type { | |||
260 | * { u64 time; } && PERF_RECORD_TIME | 261 | * { u64 time; } && PERF_RECORD_TIME |
261 | * { u64 addr; } && PERF_RECORD_ADDR | 262 | * { u64 addr; } && PERF_RECORD_ADDR |
262 | * { u64 config; } && PERF_RECORD_CONFIG | 263 | * { u64 config; } && PERF_RECORD_CONFIG |
264 | * { u32 cpu, res; } && PERF_RECORD_CPU | ||
263 | * | 265 | * |
264 | * { u64 nr; | 266 | * { u64 nr; |
265 | * { u64 event, val; } cnt[nr]; } && PERF_RECORD_GROUP | 267 | * { u64 event, val; } cnt[nr]; } && PERF_RECORD_GROUP |
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c index c615f52aa408..d850a1fb8d4c 100644 --- a/kernel/perf_counter.c +++ b/kernel/perf_counter.c | |||
@@ -1956,6 +1956,9 @@ static void perf_counter_output(struct perf_counter *counter, | |||
1956 | struct perf_callchain_entry *callchain = NULL; | 1956 | struct perf_callchain_entry *callchain = NULL; |
1957 | int callchain_size = 0; | 1957 | int callchain_size = 0; |
1958 | u64 time; | 1958 | u64 time; |
1959 | struct { | ||
1960 | u32 cpu, reserved; | ||
1961 | } cpu_entry; | ||
1959 | 1962 | ||
1960 | header.type = 0; | 1963 | header.type = 0; |
1961 | header.size = sizeof(header); | 1964 | header.size = sizeof(header); |
@@ -1999,6 +2002,13 @@ static void perf_counter_output(struct perf_counter *counter, | |||
1999 | header.size += sizeof(u64); | 2002 | header.size += sizeof(u64); |
2000 | } | 2003 | } |
2001 | 2004 | ||
2005 | if (record_type & PERF_RECORD_CPU) { | ||
2006 | header.type |= PERF_RECORD_CPU; | ||
2007 | header.size += sizeof(cpu_entry); | ||
2008 | |||
2009 | cpu_entry.cpu = raw_smp_processor_id(); | ||
2010 | } | ||
2011 | |||
2002 | if (record_type & PERF_RECORD_GROUP) { | 2012 | if (record_type & PERF_RECORD_GROUP) { |
2003 | header.type |= PERF_RECORD_GROUP; | 2013 | header.type |= PERF_RECORD_GROUP; |
2004 | header.size += sizeof(u64) + | 2014 | header.size += sizeof(u64) + |
@@ -2037,6 +2047,9 @@ static void perf_counter_output(struct perf_counter *counter, | |||
2037 | if (record_type & PERF_RECORD_CONFIG) | 2047 | if (record_type & PERF_RECORD_CONFIG) |
2038 | perf_output_put(&handle, counter->hw_event.config); | 2048 | perf_output_put(&handle, counter->hw_event.config); |
2039 | 2049 | ||
2050 | if (record_type & PERF_RECORD_CPU) | ||
2051 | perf_output_put(&handle, cpu_entry); | ||
2052 | |||
2040 | /* | 2053 | /* |
2041 | * XXX PERF_RECORD_GROUP vs inherited counters seems difficult. | 2054 | * XXX PERF_RECORD_GROUP vs inherited counters seems difficult. |
2042 | */ | 2055 | */ |