diff options
| author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2012-06-13 09:24:45 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2012-07-24 07:53:00 -0400 |
| commit | ee08d1284ea9235b29bd2d9b7493b4b4cf3da09c (patch) | |
| tree | 246ef814eb461eb1485b33ad3238d505d0633b28 | |
| parent | 28a33cbc24e4256c143dce96c7d93bf423229f92 (diff) | |
sched/x86: Remove broken power estimation
The x86 sched power implementation has been broken forever and gets in
the way of other stuff, remove it.
[ For archaeological interest, fixing this code would require dealing
with the cross-cpu calling of these functions and more importantly, we
need to filter idle time out of the a/m-perf stuff because the ratio
will go down to 0 when idle, giving a 0 capacity which is not what
we'd want. ]
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Link: http://lkml.kernel.org/r/1339594110.8980.38.camel@twins
Signed-off-by: Ingo Molnar <mingo@kernel.org>
| -rw-r--r-- | arch/x86/kernel/cpu/Makefile | 2 | ||||
| -rw-r--r-- | arch/x86/kernel/cpu/sched.c | 55 |
2 files changed, 1 insertions, 56 deletions
diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile index 6ab6aa2fdfdd..c5981267a60c 100644 --- a/arch/x86/kernel/cpu/Makefile +++ b/arch/x86/kernel/cpu/Makefile | |||
| @@ -14,7 +14,7 @@ CFLAGS_common.o := $(nostackp) | |||
| 14 | 14 | ||
| 15 | obj-y := intel_cacheinfo.o scattered.o topology.o | 15 | obj-y := intel_cacheinfo.o scattered.o topology.o |
| 16 | obj-y += proc.o capflags.o powerflags.o common.o | 16 | obj-y += proc.o capflags.o powerflags.o common.o |
| 17 | obj-y += vmware.o hypervisor.o sched.o mshyperv.o | 17 | obj-y += vmware.o hypervisor.o mshyperv.o |
| 18 | obj-y += rdrand.o | 18 | obj-y += rdrand.o |
| 19 | obj-y += match.o | 19 | obj-y += match.o |
| 20 | 20 | ||
diff --git a/arch/x86/kernel/cpu/sched.c b/arch/x86/kernel/cpu/sched.c deleted file mode 100644 index a640ae5ad201..000000000000 --- a/arch/x86/kernel/cpu/sched.c +++ /dev/null | |||
| @@ -1,55 +0,0 @@ | |||
| 1 | #include <linux/sched.h> | ||
| 2 | #include <linux/math64.h> | ||
| 3 | #include <linux/percpu.h> | ||
| 4 | #include <linux/irqflags.h> | ||
| 5 | |||
| 6 | #include <asm/cpufeature.h> | ||
| 7 | #include <asm/processor.h> | ||
| 8 | |||
| 9 | #ifdef CONFIG_SMP | ||
| 10 | |||
| 11 | static DEFINE_PER_CPU(struct aperfmperf, old_perf_sched); | ||
| 12 | |||
| 13 | static unsigned long scale_aperfmperf(void) | ||
| 14 | { | ||
| 15 | struct aperfmperf val, *old = &__get_cpu_var(old_perf_sched); | ||
| 16 | unsigned long ratio, flags; | ||
| 17 | |||
| 18 | local_irq_save(flags); | ||
| 19 | get_aperfmperf(&val); | ||
| 20 | local_irq_restore(flags); | ||
| 21 | |||
| 22 | ratio = calc_aperfmperf_ratio(old, &val); | ||
| 23 | *old = val; | ||
| 24 | |||
| 25 | return ratio; | ||
| 26 | } | ||
| 27 | |||
| 28 | unsigned long arch_scale_freq_power(struct sched_domain *sd, int cpu) | ||
| 29 | { | ||
| 30 | /* | ||
| 31 | * do aperf/mperf on the cpu level because it includes things | ||
| 32 | * like turbo mode, which are relevant to full cores. | ||
| 33 | */ | ||
| 34 | if (boot_cpu_has(X86_FEATURE_APERFMPERF)) | ||
| 35 | return scale_aperfmperf(); | ||
| 36 | |||
| 37 | /* | ||
| 38 | * maybe have something cpufreq here | ||
| 39 | */ | ||
| 40 | |||
| 41 | return default_scale_freq_power(sd, cpu); | ||
| 42 | } | ||
| 43 | |||
| 44 | unsigned long arch_scale_smt_power(struct sched_domain *sd, int cpu) | ||
| 45 | { | ||
| 46 | /* | ||
| 47 | * aperf/mperf already includes the smt gain | ||
| 48 | */ | ||
| 49 | if (boot_cpu_has(X86_FEATURE_APERFMPERF)) | ||
| 50 | return SCHED_LOAD_SCALE; | ||
| 51 | |||
| 52 | return default_scale_smt_power(sd, cpu); | ||
| 53 | } | ||
| 54 | |||
| 55 | #endif | ||
