diff options
author | Vaibhav Hiremath <hvaibhav@ti.com> | 2012-07-05 11:05:15 -0400 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2012-07-05 11:05:15 -0400 |
commit | ecc46cfdad7499a21296f0757059c4965f1fbc98 (patch) | |
tree | c040dbcf69fc66b809893bfd4963fb72904be757 | |
parent | 971b8a9c3eeb798f6201299728fdbb04ebb681c6 (diff) |
ARM: OMAP2+: Remove unnecessary ifdef around __omap2_set_globals
The function __omap2_set_globals() can be common across all
platforms/architectures, even in case of omap4, internally it
calls same set of functions as in __omap2_set_globals() function
(except for sdrc).
This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle sdrc,
so that we can reuse same function across omap2/3/4...
Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
-rw-r--r-- | arch/arm/mach-omap2/Kconfig | 8 | ||||
-rw-r--r-- | arch/arm/mach-omap2/Makefile | 3 | ||||
-rw-r--r-- | arch/arm/mach-omap2/common.c | 8 | ||||
-rw-r--r-- | arch/arm/mach-omap2/common.h | 5 |
4 files changed, 16 insertions, 8 deletions
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 3649a34db00d..6c934778357b 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig | |||
@@ -21,12 +21,16 @@ config ARCH_OMAP2PLUS_TYPICAL | |||
21 | help | 21 | help |
22 | Compile a kernel suitable for booting most boards | 22 | Compile a kernel suitable for booting most boards |
23 | 23 | ||
24 | config SOC_HAS_OMAP2_SDRC | ||
25 | bool "OMAP2 SDRAM Controller support" | ||
26 | |||
24 | config ARCH_OMAP2 | 27 | config ARCH_OMAP2 |
25 | bool "TI OMAP2" | 28 | bool "TI OMAP2" |
26 | depends on ARCH_OMAP2PLUS | 29 | depends on ARCH_OMAP2PLUS |
27 | default y | 30 | default y |
28 | select CPU_V6 | 31 | select CPU_V6 |
29 | select MULTI_IRQ_HANDLER | 32 | select MULTI_IRQ_HANDLER |
33 | select SOC_HAS_OMAP2_SDRC | ||
30 | 34 | ||
31 | config ARCH_OMAP3 | 35 | config ARCH_OMAP3 |
32 | bool "TI OMAP3" | 36 | bool "TI OMAP3" |
@@ -38,6 +42,7 @@ config ARCH_OMAP3 | |||
38 | select PM_OPP if PM | 42 | select PM_OPP if PM |
39 | select ARM_CPU_SUSPEND if PM | 43 | select ARM_CPU_SUSPEND if PM |
40 | select MULTI_IRQ_HANDLER | 44 | select MULTI_IRQ_HANDLER |
45 | select SOC_HAS_OMAP2_SDRC | ||
41 | 46 | ||
42 | config ARCH_OMAP4 | 47 | config ARCH_OMAP4 |
43 | bool "TI OMAP4" | 48 | bool "TI OMAP4" |
@@ -64,16 +69,19 @@ config SOC_OMAP2420 | |||
64 | depends on ARCH_OMAP2 | 69 | depends on ARCH_OMAP2 |
65 | default y | 70 | default y |
66 | select OMAP_DM_TIMER | 71 | select OMAP_DM_TIMER |
72 | select SOC_HAS_OMAP2_SDRC | ||
67 | 73 | ||
68 | config SOC_OMAP2430 | 74 | config SOC_OMAP2430 |
69 | bool "OMAP2430 support" | 75 | bool "OMAP2430 support" |
70 | depends on ARCH_OMAP2 | 76 | depends on ARCH_OMAP2 |
71 | default y | 77 | default y |
78 | select SOC_HAS_OMAP2_SDRC | ||
72 | 79 | ||
73 | config SOC_OMAP3430 | 80 | config SOC_OMAP3430 |
74 | bool "OMAP3430 support" | 81 | bool "OMAP3430 support" |
75 | depends on ARCH_OMAP3 | 82 | depends on ARCH_OMAP3 |
76 | default y | 83 | default y |
84 | select SOC_HAS_OMAP2_SDRC | ||
77 | 85 | ||
78 | config SOC_TI81XX | 86 | config SOC_TI81XX |
79 | bool "TI81XX support" | 87 | bool "TI81XX support" |
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 846d44547fd3..240f1969f2ad 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile | |||
@@ -6,7 +6,7 @@ | |||
6 | obj-y := id.o io.o control.o mux.o devices.o serial.o gpmc.o timer.o pm.o \ | 6 | obj-y := id.o io.o control.o mux.o devices.o serial.o gpmc.o timer.o pm.o \ |
7 | common.o gpio.o dma.o wd_timer.o display.o i2c.o hdq1w.o | 7 | common.o gpio.o dma.o wd_timer.o display.o i2c.o hdq1w.o |
8 | 8 | ||
9 | omap-2-3-common = irq.o sdrc.o | 9 | omap-2-3-common = irq.o |
10 | hwmod-common = omap_hwmod.o \ | 10 | hwmod-common = omap_hwmod.o \ |
11 | omap_hwmod_common_data.o | 11 | omap_hwmod_common_data.o |
12 | clock-common = clock.o clock_common_data.o \ | 12 | clock-common = clock.o clock_common_data.o \ |
@@ -23,6 +23,7 @@ obj-y += mcbsp.o | |||
23 | endif | 23 | endif |
24 | 24 | ||
25 | obj-$(CONFIG_TWL4030_CORE) += omap_twl.o | 25 | obj-$(CONFIG_TWL4030_CORE) += omap_twl.o |
26 | obj-$(CONFIG_SOC_HAS_OMAP2_SDRC) += sdrc.o | ||
26 | 27 | ||
27 | # SMP support ONLY available for OMAP4 | 28 | # SMP support ONLY available for OMAP4 |
28 | 29 | ||
diff --git a/arch/arm/mach-omap2/common.c b/arch/arm/mach-omap2/common.c index a7aa538e681d..73d2a0b9ca04 100644 --- a/arch/arm/mach-omap2/common.c +++ b/arch/arm/mach-omap2/common.c | |||
@@ -29,8 +29,6 @@ | |||
29 | 29 | ||
30 | /* Global address base setup code */ | 30 | /* Global address base setup code */ |
31 | 31 | ||
32 | #if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3) | ||
33 | |||
34 | static void __init __omap2_set_globals(struct omap_globals *omap2_globals) | 32 | static void __init __omap2_set_globals(struct omap_globals *omap2_globals) |
35 | { | 33 | { |
36 | omap2_set_globals_tap(omap2_globals); | 34 | omap2_set_globals_tap(omap2_globals); |
@@ -39,8 +37,6 @@ static void __init __omap2_set_globals(struct omap_globals *omap2_globals) | |||
39 | omap2_set_globals_prcm(omap2_globals); | 37 | omap2_set_globals_prcm(omap2_globals); |
40 | } | 38 | } |
41 | 39 | ||
42 | #endif | ||
43 | |||
44 | #if defined(CONFIG_SOC_OMAP2420) | 40 | #if defined(CONFIG_SOC_OMAP2420) |
45 | 41 | ||
46 | static struct omap_globals omap242x_globals = { | 42 | static struct omap_globals omap242x_globals = { |
@@ -173,9 +169,7 @@ static struct omap_globals omap4_globals = { | |||
173 | 169 | ||
174 | void __init omap2_set_globals_443x(void) | 170 | void __init omap2_set_globals_443x(void) |
175 | { | 171 | { |
176 | omap2_set_globals_tap(&omap4_globals); | 172 | __omap2_set_globals(&omap4_globals); |
177 | omap2_set_globals_control(&omap4_globals); | ||
178 | omap2_set_globals_prcm(&omap4_globals); | ||
179 | } | 173 | } |
180 | 174 | ||
181 | void __init omap4_map_io(void) | 175 | void __init omap4_map_io(void) |
diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h index 5d99c1b2cb48..404f172d95a8 100644 --- a/arch/arm/mach-omap2/common.h +++ b/arch/arm/mach-omap2/common.h | |||
@@ -174,7 +174,12 @@ void omap2_set_globals_am33xx(void); | |||
174 | 174 | ||
175 | /* These get called from omap2_set_globals_xxxx(), do not call these */ | 175 | /* These get called from omap2_set_globals_xxxx(), do not call these */ |
176 | void omap2_set_globals_tap(struct omap_globals *); | 176 | void omap2_set_globals_tap(struct omap_globals *); |
177 | #if defined(CONFIG_SOC_HAS_OMAP2_SDRC) | ||
177 | void omap2_set_globals_sdrc(struct omap_globals *); | 178 | void omap2_set_globals_sdrc(struct omap_globals *); |
179 | #else | ||
180 | static inline void omap2_set_globals_sdrc(struct omap_globals *omap2_globals) | ||
181 | { } | ||
182 | #endif | ||
178 | void omap2_set_globals_control(struct omap_globals *); | 183 | void omap2_set_globals_control(struct omap_globals *); |
179 | void omap2_set_globals_prcm(struct omap_globals *); | 184 | void omap2_set_globals_prcm(struct omap_globals *); |
180 | 185 | ||