diff options
author | Namhyung Kim <namhyung@kernel.org> | 2013-11-18 00:34:52 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-11-27 12:58:35 -0500 |
commit | e944d3d7d151eea149c62310eaff7b92c7732f58 (patch) | |
tree | 37ef322194b1a9b962d3768cf74a1407cad01de2 | |
parent | a8b4c7014cadfdacd4e1f4c963128593be6f20de (diff) |
perf script: Move evname print code to process_event()
The print_sample_start() will be reused by other printing routine for
internal events like COMM, FORK and EXIT from next patch. And because
they're not tied to a specific event, move the evname print code to its
caller.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1384752894-10974-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-script.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index baf17989a216..b392770766dd 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c | |||
@@ -288,7 +288,6 @@ static void print_sample_start(struct perf_sample *sample, | |||
288 | struct perf_evsel *evsel) | 288 | struct perf_evsel *evsel) |
289 | { | 289 | { |
290 | struct perf_event_attr *attr = &evsel->attr; | 290 | struct perf_event_attr *attr = &evsel->attr; |
291 | const char *evname = NULL; | ||
292 | unsigned long secs; | 291 | unsigned long secs; |
293 | unsigned long usecs; | 292 | unsigned long usecs; |
294 | unsigned long long nsecs; | 293 | unsigned long long nsecs; |
@@ -323,11 +322,6 @@ static void print_sample_start(struct perf_sample *sample, | |||
323 | usecs = nsecs / NSECS_PER_USEC; | 322 | usecs = nsecs / NSECS_PER_USEC; |
324 | printf("%5lu.%06lu: ", secs, usecs); | 323 | printf("%5lu.%06lu: ", secs, usecs); |
325 | } | 324 | } |
326 | |||
327 | if (PRINT_FIELD(EVNAME)) { | ||
328 | evname = perf_evsel__name(evsel); | ||
329 | printf("%s: ", evname ? evname : "[unknown]"); | ||
330 | } | ||
331 | } | 325 | } |
332 | 326 | ||
333 | static bool is_bts_event(struct perf_event_attr *attr) | 327 | static bool is_bts_event(struct perf_event_attr *attr) |
@@ -434,6 +428,11 @@ static void process_event(union perf_event *event, struct perf_sample *sample, | |||
434 | 428 | ||
435 | print_sample_start(sample, thread, evsel); | 429 | print_sample_start(sample, thread, evsel); |
436 | 430 | ||
431 | if (PRINT_FIELD(EVNAME)) { | ||
432 | const char *evname = perf_evsel__name(evsel); | ||
433 | printf("%s: ", evname ? evname : "[unknown]"); | ||
434 | } | ||
435 | |||
437 | if (is_bts_event(attr)) { | 436 | if (is_bts_event(attr)) { |
438 | print_sample_bts(event, sample, evsel, machine, thread); | 437 | print_sample_bts(event, sample, evsel, machine, thread); |
439 | return; | 438 | return; |