diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-08-14 01:58:15 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-08-15 17:49:00 -0400 |
commit | e36c92fd63bb4773e6f4bc38ecee11a609ded1cf (patch) | |
tree | 3ed46009422b64c40d354acdc63cbca6646baa56 | |
parent | 5359805193dc83e1aab2f8e230d57c649363c5c5 (diff) |
[media] em28xx: use after free in em28xx_v4l2_close()
We need to move the unlock before the kfree(dev);
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/usb/em28xx/em28xx-video.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c index ecb23df7f16e..78d6ebd712b9 100644 --- a/drivers/media/usb/em28xx/em28xx-video.c +++ b/drivers/media/usb/em28xx/em28xx-video.c | |||
@@ -2264,9 +2264,9 @@ static int em28xx_v4l2_close(struct file *filp) | |||
2264 | if (dev->state & DEV_DISCONNECTED) { | 2264 | if (dev->state & DEV_DISCONNECTED) { |
2265 | em28xx_release_resources(dev); | 2265 | em28xx_release_resources(dev); |
2266 | kfree(dev->alt_max_pkt_size); | 2266 | kfree(dev->alt_max_pkt_size); |
2267 | mutex_unlock(&dev->lock); | ||
2267 | kfree(dev); | 2268 | kfree(dev); |
2268 | kfree(fh); | 2269 | kfree(fh); |
2269 | mutex_unlock(&dev->lock); | ||
2270 | return 0; | 2270 | return 0; |
2271 | } | 2271 | } |
2272 | 2272 | ||