diff options
author | Johannes Berg <johannes.berg@intel.com> | 2014-10-22 05:22:56 -0400 |
---|---|---|
committer | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2014-12-28 03:17:40 -0500 |
commit | e32ec12fd11fbccc1cb4656e34f35ad457e19e29 (patch) | |
tree | 035ee3ce7872558c00f16ab45b54fa00a04cfc64 | |
parent | 70e71ca0af244f48a5dcf56dc435243792e3a495 (diff) |
iwlwifi: remove MODULE_VERSION
The module version "in-tree:" or "in-tree:d" is useless; there
should be better (functional) ways to detect whether debugging
is enabled and other than that the version says nothing.
Therefore remove the driver version completely.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
-rw-r--r-- | drivers/net/wireless/iwlwifi/dvm/main.c | 14 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-drv.c | 15 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-drv.h | 1 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/mvm/ops.c | 7 |
4 files changed, 1 insertions, 36 deletions
diff --git a/drivers/net/wireless/iwlwifi/dvm/main.c b/drivers/net/wireless/iwlwifi/dvm/main.c index 0b7f46f0b079..fcdc128298ea 100644 --- a/drivers/net/wireless/iwlwifi/dvm/main.c +++ b/drivers/net/wireless/iwlwifi/dvm/main.c | |||
@@ -64,22 +64,8 @@ | |||
64 | * | 64 | * |
65 | ******************************************************************************/ | 65 | ******************************************************************************/ |
66 | 66 | ||
67 | /* | ||
68 | * module name, copyright, version, etc. | ||
69 | */ | ||
70 | #define DRV_DESCRIPTION "Intel(R) Wireless WiFi Link AGN driver for Linux" | 67 | #define DRV_DESCRIPTION "Intel(R) Wireless WiFi Link AGN driver for Linux" |
71 | |||
72 | #ifdef CONFIG_IWLWIFI_DEBUG | ||
73 | #define VD "d" | ||
74 | #else | ||
75 | #define VD | ||
76 | #endif | ||
77 | |||
78 | #define DRV_VERSION IWLWIFI_VERSION VD | ||
79 | |||
80 | |||
81 | MODULE_DESCRIPTION(DRV_DESCRIPTION); | 68 | MODULE_DESCRIPTION(DRV_DESCRIPTION); |
82 | MODULE_VERSION(DRV_VERSION); | ||
83 | MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR); | 69 | MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR); |
84 | MODULE_LICENSE("GPL"); | 70 | MODULE_LICENSE("GPL"); |
85 | 71 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.c b/drivers/net/wireless/iwlwifi/iwl-drv.c index 38de1513e4de..36ae19134d11 100644 --- a/drivers/net/wireless/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/iwlwifi/iwl-drv.c | |||
@@ -84,21 +84,8 @@ | |||
84 | * | 84 | * |
85 | ******************************************************************************/ | 85 | ******************************************************************************/ |
86 | 86 | ||
87 | /* | ||
88 | * module name, copyright, version, etc. | ||
89 | */ | ||
90 | #define DRV_DESCRIPTION "Intel(R) Wireless WiFi driver for Linux" | 87 | #define DRV_DESCRIPTION "Intel(R) Wireless WiFi driver for Linux" |
91 | |||
92 | #ifdef CONFIG_IWLWIFI_DEBUG | ||
93 | #define VD "d" | ||
94 | #else | ||
95 | #define VD | ||
96 | #endif | ||
97 | |||
98 | #define DRV_VERSION IWLWIFI_VERSION VD | ||
99 | |||
100 | MODULE_DESCRIPTION(DRV_DESCRIPTION); | 88 | MODULE_DESCRIPTION(DRV_DESCRIPTION); |
101 | MODULE_VERSION(DRV_VERSION); | ||
102 | MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR); | 89 | MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR); |
103 | MODULE_LICENSE("GPL"); | 90 | MODULE_LICENSE("GPL"); |
104 | 91 | ||
@@ -1492,7 +1479,7 @@ static int __init iwl_drv_init(void) | |||
1492 | for (i = 0; i < ARRAY_SIZE(iwlwifi_opmode_table); i++) | 1479 | for (i = 0; i < ARRAY_SIZE(iwlwifi_opmode_table); i++) |
1493 | INIT_LIST_HEAD(&iwlwifi_opmode_table[i].drv); | 1480 | INIT_LIST_HEAD(&iwlwifi_opmode_table[i].drv); |
1494 | 1481 | ||
1495 | pr_info(DRV_DESCRIPTION ", " DRV_VERSION "\n"); | 1482 | pr_info(DRV_DESCRIPTION "\n"); |
1496 | pr_info(DRV_COPYRIGHT "\n"); | 1483 | pr_info(DRV_COPYRIGHT "\n"); |
1497 | 1484 | ||
1498 | #ifdef CONFIG_IWLWIFI_DEBUGFS | 1485 | #ifdef CONFIG_IWLWIFI_DEBUGFS |
diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.h b/drivers/net/wireless/iwlwifi/iwl-drv.h index be4f8972241a..adf522c756e6 100644 --- a/drivers/net/wireless/iwlwifi/iwl-drv.h +++ b/drivers/net/wireless/iwlwifi/iwl-drv.h | |||
@@ -68,7 +68,6 @@ | |||
68 | 68 | ||
69 | /* for all modules */ | 69 | /* for all modules */ |
70 | #define DRV_NAME "iwlwifi" | 70 | #define DRV_NAME "iwlwifi" |
71 | #define IWLWIFI_VERSION "in-tree:" | ||
72 | #define DRV_COPYRIGHT "Copyright(c) 2003- 2014 Intel Corporation" | 71 | #define DRV_COPYRIGHT "Copyright(c) 2003- 2014 Intel Corporation" |
73 | #define DRV_AUTHOR "<ilw@linux.intel.com>" | 72 | #define DRV_AUTHOR "<ilw@linux.intel.com>" |
74 | 73 | ||
diff --git a/drivers/net/wireless/iwlwifi/mvm/ops.c b/drivers/net/wireless/iwlwifi/mvm/ops.c index 97dfba50c682..552a776962af 100644 --- a/drivers/net/wireless/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/iwlwifi/mvm/ops.c | |||
@@ -84,15 +84,8 @@ | |||
84 | #include "time-event.h" | 84 | #include "time-event.h" |
85 | #include "iwl-fw-error-dump.h" | 85 | #include "iwl-fw-error-dump.h" |
86 | 86 | ||
87 | /* | ||
88 | * module name, copyright, version, etc. | ||
89 | */ | ||
90 | #define DRV_DESCRIPTION "The new Intel(R) wireless AGN driver for Linux" | 87 | #define DRV_DESCRIPTION "The new Intel(R) wireless AGN driver for Linux" |
91 | |||
92 | #define DRV_VERSION IWLWIFI_VERSION | ||
93 | |||
94 | MODULE_DESCRIPTION(DRV_DESCRIPTION); | 88 | MODULE_DESCRIPTION(DRV_DESCRIPTION); |
95 | MODULE_VERSION(DRV_VERSION); | ||
96 | MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR); | 89 | MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR); |
97 | MODULE_LICENSE("GPL"); | 90 | MODULE_LICENSE("GPL"); |
98 | 91 | ||