aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBorislav Petkov <bp@suse.de>2013-03-20 10:07:24 -0400
committerH. Peter Anvin <hpa@zytor.com>2013-04-02 13:12:52 -0400
commite2604b49e8a8827e8bc5b61bc0c5a889e028fdad (patch)
tree43f39236ba314d50e31c02364dcd6c88e7c6cb10
parent65fc985b37dc241c4db7cd32adcbc989193fe3c8 (diff)
x86, cpu: Convert F00F bug detection
... to using the new facility and drop the cpuinfo_x86 member. Signed-off-by: Borislav Petkov <bp@suse.de> Link: http://lkml.kernel.org/r/1363788448-31325-3-git-send-email-bp@alien8.de Signed-off-by: H. Peter Anvin <hpa@zytor.com>
-rw-r--r--arch/x86/include/asm/cpufeature.h2
-rw-r--r--arch/x86/include/asm/processor.h1
-rw-r--r--arch/x86/kernel/cpu/intel.c4
-rw-r--r--arch/x86/kernel/cpu/proc.c2
-rw-r--r--arch/x86/mm/fault.c2
5 files changed, 6 insertions, 5 deletions
diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index 16190abd8905..c0ad7e75815c 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -222,6 +222,8 @@
222 */ 222 */
223#define X86_BUG(x) (NCAPINTS*32 + (x)) 223#define X86_BUG(x) (NCAPINTS*32 + (x))
224 224
225#define X86_BUG_F00F X86_BUG(0) /* Intel F00F */
226
225#if defined(__KERNEL__) && !defined(__ASSEMBLY__) 227#if defined(__KERNEL__) && !defined(__ASSEMBLY__)
226 228
227#include <asm/asm.h> 229#include <asm/asm.h>
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 23c8081d3870..1e55e2d543b5 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -92,7 +92,6 @@ struct cpuinfo_x86 {
92 char hard_math; 92 char hard_math;
93 char rfu; 93 char rfu;
94 char fdiv_bug; 94 char fdiv_bug;
95 char f00f_bug;
96 char coma_bug; 95 char coma_bug;
97 char pad0; 96 char pad0;
98#else 97#else
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 1905ce98bee0..1acdd42d86d1 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -209,11 +209,11 @@ static void __cpuinit intel_workarounds(struct cpuinfo_x86 *c)
209 * system. 209 * system.
210 * Note that the workaround only should be initialized once... 210 * Note that the workaround only should be initialized once...
211 */ 211 */
212 c->f00f_bug = 0; 212 clear_cpu_bug(c, X86_BUG_F00F);
213 if (!paravirt_enabled() && c->x86 == 5) { 213 if (!paravirt_enabled() && c->x86 == 5) {
214 static int f00f_workaround_enabled; 214 static int f00f_workaround_enabled;
215 215
216 c->f00f_bug = 1; 216 set_cpu_bug(c, X86_BUG_F00F);
217 if (!f00f_workaround_enabled) { 217 if (!f00f_workaround_enabled) {
218 trap_init_f00f_bug(); 218 trap_init_f00f_bug();
219 printk(KERN_NOTICE "Intel Pentium with F0 0F bug - workaround enabled.\n"); 219 printk(KERN_NOTICE "Intel Pentium with F0 0F bug - workaround enabled.\n");
diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index e280253f6f94..2d60b2bec01c 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -35,7 +35,7 @@ static void show_cpuinfo_misc(struct seq_file *m, struct cpuinfo_x86 *c)
35 "cpuid level\t: %d\n" 35 "cpuid level\t: %d\n"
36 "wp\t\t: %s\n", 36 "wp\t\t: %s\n",
37 c->fdiv_bug ? "yes" : "no", 37 c->fdiv_bug ? "yes" : "no",
38 c->f00f_bug ? "yes" : "no", 38 static_cpu_has_bug(X86_BUG_F00F) ? "yes" : "no",
39 c->coma_bug ? "yes" : "no", 39 c->coma_bug ? "yes" : "no",
40 c->hard_math ? "yes" : "no", 40 c->hard_math ? "yes" : "no",
41 c->hard_math ? "yes" : "no", 41 c->hard_math ? "yes" : "no",
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 2b97525246d4..a1ce1facbacc 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -555,7 +555,7 @@ static int is_f00f_bug(struct pt_regs *regs, unsigned long address)
555 /* 555 /*
556 * Pentium F0 0F C7 C8 bug workaround: 556 * Pentium F0 0F C7 C8 bug workaround:
557 */ 557 */
558 if (boot_cpu_data.f00f_bug) { 558 if (boot_cpu_has_bug(X86_BUG_F00F)) {
559 nr = (address - idt_descr.address) >> 3; 559 nr = (address - idt_descr.address) >> 3;
560 560
561 if (nr == 6) { 561 if (nr == 6) {