diff options
author | Sasha Levin <sasha.levin@oracle.com> | 2015-05-28 18:44:29 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-05-28 21:25:18 -0400 |
commit | dcbff39da3d815f08750552fdd04f96b51751129 (patch) | |
tree | c0d971b56e84d751880b9879400be91c405e818b | |
parent | cd4e6c91a114a23b0b8d61d460a2d1d14e3b45f4 (diff) |
fs, omfs: add NULL terminator in the end up the token list
match_token() expects a NULL terminator at the end of the token list so
that it would know where to stop. Not having one causes it to overrun
to invalid memory.
In practice, passing a mount option that omfs didn't recognize would
sometimes panic the system.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | fs/omfs/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index 138321b0c6c2..70d4191cf33d 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c | |||
@@ -359,7 +359,7 @@ nomem: | |||
359 | } | 359 | } |
360 | 360 | ||
361 | enum { | 361 | enum { |
362 | Opt_uid, Opt_gid, Opt_umask, Opt_dmask, Opt_fmask | 362 | Opt_uid, Opt_gid, Opt_umask, Opt_dmask, Opt_fmask, Opt_err |
363 | }; | 363 | }; |
364 | 364 | ||
365 | static const match_table_t tokens = { | 365 | static const match_table_t tokens = { |
@@ -368,6 +368,7 @@ static const match_table_t tokens = { | |||
368 | {Opt_umask, "umask=%o"}, | 368 | {Opt_umask, "umask=%o"}, |
369 | {Opt_dmask, "dmask=%o"}, | 369 | {Opt_dmask, "dmask=%o"}, |
370 | {Opt_fmask, "fmask=%o"}, | 370 | {Opt_fmask, "fmask=%o"}, |
371 | {Opt_err, NULL}, | ||
371 | }; | 372 | }; |
372 | 373 | ||
373 | static int parse_options(char *options, struct omfs_sb_info *sbi) | 374 | static int parse_options(char *options, struct omfs_sb_info *sbi) |