diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-05 04:43:37 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-22 09:39:39 -0400 |
commit | dcb1ee57780f2f772015ce9f80b2adc671257228 (patch) | |
tree | 88bcb8614d942878800e0487de381ad903d888c7 | |
parent | e39a52da87fc49eeb0a91e7db3c30bd61e87bdb7 (diff) |
drm/bochs: Remove unnecessary NULL check in bo_unref
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.
Spotted by coverity.
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/bochs/bochs_mm.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c index f488be55d650..4a239e931aff 100644 --- a/drivers/gpu/drm/bochs/bochs_mm.c +++ b/drivers/gpu/drm/bochs/bochs_mm.c | |||
@@ -434,9 +434,7 @@ static void bochs_bo_unref(struct bochs_bo **bo) | |||
434 | 434 | ||
435 | tbo = &((*bo)->bo); | 435 | tbo = &((*bo)->bo); |
436 | ttm_bo_unref(&tbo); | 436 | ttm_bo_unref(&tbo); |
437 | if (tbo == NULL) | 437 | *bo = NULL; |
438 | *bo = NULL; | ||
439 | |||
440 | } | 438 | } |
441 | 439 | ||
442 | void bochs_gem_free_object(struct drm_gem_object *obj) | 440 | void bochs_gem_free_object(struct drm_gem_object *obj) |