diff options
| author | Guennadi Liakhovetski <g.liakhovetski@gmx.de> | 2011-07-28 13:42:25 -0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-11-03 16:28:02 -0400 |
| commit | db669e79ed27b7842d1d3495836238fb46e29769 (patch) | |
| tree | f2a1567d9d06a9955948bbb3d651f111a9aa294d | |
| parent | ea04ddce4fe5c11eaccc95a23579f0ae513907ba (diff) | |
[media] V4L: ov6650: remove superfluous soc-camera client operations
Now that all soc-camera hosts have been ported to use V4L2 subdevice
mediabus-config operations and soc-camera client bus-parameter operations
have been made optional, they can be removed.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/video/ov6650.c | 50 |
1 files changed, 2 insertions, 48 deletions
diff --git a/drivers/media/video/ov6650.c b/drivers/media/video/ov6650.c index a26734d4cf30..654b2f591ae2 100644 --- a/drivers/media/video/ov6650.c +++ b/drivers/media/video/ov6650.c | |||
| @@ -419,52 +419,6 @@ static int ov6650_s_stream(struct v4l2_subdev *sd, int enable) | |||
| 419 | return 0; | 419 | return 0; |
| 420 | } | 420 | } |
| 421 | 421 | ||
| 422 | /* Alter bus settings on camera side */ | ||
| 423 | static int ov6650_set_bus_param(struct soc_camera_device *icd, | ||
| 424 | unsigned long flags) | ||
| 425 | { | ||
| 426 | struct soc_camera_link *icl = to_soc_camera_link(icd); | ||
| 427 | struct i2c_client *client = to_i2c_client(to_soc_camera_control(icd)); | ||
| 428 | int ret; | ||
| 429 | |||
| 430 | flags = soc_camera_apply_sensor_flags(icl, flags); | ||
| 431 | |||
| 432 | if (flags & SOCAM_PCLK_SAMPLE_RISING) | ||
| 433 | ret = ov6650_reg_rmw(client, REG_COMJ, COMJ_PCLK_RISING, 0); | ||
| 434 | else | ||
| 435 | ret = ov6650_reg_rmw(client, REG_COMJ, 0, COMJ_PCLK_RISING); | ||
| 436 | if (ret) | ||
| 437 | return ret; | ||
| 438 | |||
| 439 | if (flags & SOCAM_HSYNC_ACTIVE_LOW) | ||
| 440 | ret = ov6650_reg_rmw(client, REG_COMF, COMF_HREF_LOW, 0); | ||
| 441 | else | ||
| 442 | ret = ov6650_reg_rmw(client, REG_COMF, 0, COMF_HREF_LOW); | ||
| 443 | if (ret) | ||
| 444 | return ret; | ||
| 445 | |||
| 446 | if (flags & SOCAM_VSYNC_ACTIVE_HIGH) | ||
| 447 | ret = ov6650_reg_rmw(client, REG_COMJ, COMJ_VSYNC_HIGH, 0); | ||
| 448 | else | ||
| 449 | ret = ov6650_reg_rmw(client, REG_COMJ, 0, COMJ_VSYNC_HIGH); | ||
| 450 | |||
| 451 | return ret; | ||
| 452 | } | ||
| 453 | |||
| 454 | /* Request bus settings on camera side */ | ||
| 455 | static unsigned long ov6650_query_bus_param(struct soc_camera_device *icd) | ||
| 456 | { | ||
| 457 | struct soc_camera_link *icl = to_soc_camera_link(icd); | ||
| 458 | |||
| 459 | unsigned long flags = SOCAM_MASTER | | ||
| 460 | SOCAM_PCLK_SAMPLE_RISING | SOCAM_PCLK_SAMPLE_FALLING | | ||
| 461 | SOCAM_HSYNC_ACTIVE_HIGH | SOCAM_HSYNC_ACTIVE_LOW | | ||
| 462 | SOCAM_VSYNC_ACTIVE_HIGH | SOCAM_VSYNC_ACTIVE_LOW | | ||
| 463 | SOCAM_DATA_ACTIVE_HIGH | SOCAM_DATAWIDTH_8; | ||
| 464 | |||
| 465 | return soc_camera_apply_sensor_flags(icl, flags); | ||
| 466 | } | ||
| 467 | |||
| 468 | /* Get status of additional camera capabilities */ | 422 | /* Get status of additional camera capabilities */ |
| 469 | static int ov6650_g_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl) | 423 | static int ov6650_g_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl) |
| 470 | { | 424 | { |
| @@ -1095,8 +1049,6 @@ static int ov6650_video_probe(struct soc_camera_device *icd, | |||
| 1095 | } | 1049 | } |
| 1096 | 1050 | ||
| 1097 | static struct soc_camera_ops ov6650_ops = { | 1051 | static struct soc_camera_ops ov6650_ops = { |
| 1098 | .set_bus_param = ov6650_set_bus_param, | ||
| 1099 | .query_bus_param = ov6650_query_bus_param, | ||
| 1100 | .controls = ov6650_controls, | 1052 | .controls = ov6650_controls, |
| 1101 | .num_controls = ARRAY_SIZE(ov6650_controls), | 1053 | .num_controls = ARRAY_SIZE(ov6650_controls), |
| 1102 | }; | 1054 | }; |
| @@ -1111,6 +1063,7 @@ static struct v4l2_subdev_core_ops ov6650_core_ops = { | |||
| 1111 | #endif | 1063 | #endif |
| 1112 | }; | 1064 | }; |
| 1113 | 1065 | ||
| 1066 | /* Request bus settings on camera side */ | ||
| 1114 | static int ov6650_g_mbus_config(struct v4l2_subdev *sd, | 1067 | static int ov6650_g_mbus_config(struct v4l2_subdev *sd, |
| 1115 | struct v4l2_mbus_config *cfg) | 1068 | struct v4l2_mbus_config *cfg) |
| 1116 | { | 1069 | { |
| @@ -1129,6 +1082,7 @@ static int ov6650_g_mbus_config(struct v4l2_subdev *sd, | |||
| 1129 | return 0; | 1082 | return 0; |
| 1130 | } | 1083 | } |
| 1131 | 1084 | ||
| 1085 | /* Alter bus settings on camera side */ | ||
| 1132 | static int ov6650_s_mbus_config(struct v4l2_subdev *sd, | 1086 | static int ov6650_s_mbus_config(struct v4l2_subdev *sd, |
| 1133 | const struct v4l2_mbus_config *cfg) | 1087 | const struct v4l2_mbus_config *cfg) |
| 1134 | { | 1088 | { |
