aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVincent Bernat <vincent@bernat.im>2014-08-01 04:29:30 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-08-01 17:39:26 -0400
commitd746cb55b036da18f8cdcf76c9604d8e74315827 (patch)
tree8e4c4fc62096e366ef2cce5967e6368d63f6cd4c
parent1496125efd6b5852573d0c7ad5ebc7d60599b1b3 (diff)
staging: visorchipset: fix sparse warnings about static declaration
Some functions were prototyped as static but the actual definition wasn't. While this is valid (the function is static because the two declarations don't conflict and the first one is static), this makes sparse unhappy and cause confusion of normal people too. Signed-off-by: Vincent Bernat <vincent@bernat.im> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/unisys/visorchipset/visorchipset_main.c22
1 files changed, 13 insertions, 9 deletions
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c
index b21a2b1da233..fe3c0127d255 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset_main.c
+++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c
@@ -351,8 +351,9 @@ static void controlvm_respond_physdev_changestate(CONTROLVM_MESSAGE_HEADER *
351 msgHdr, int response, 351 msgHdr, int response,
352 ULTRA_SEGMENT_STATE state); 352 ULTRA_SEGMENT_STATE state);
353 353
354ssize_t toolaction_show(struct device *dev, struct device_attribute *attr, 354static ssize_t toolaction_show(struct device *dev,
355 char *buf) 355 struct device_attribute *attr,
356 char *buf)
356{ 357{
357 u8 toolAction; 358 u8 toolAction;
358 359
@@ -362,8 +363,9 @@ ssize_t toolaction_show(struct device *dev, struct device_attribute *attr,
362 return scnprintf(buf, PAGE_SIZE, "%u\n", toolAction); 363 return scnprintf(buf, PAGE_SIZE, "%u\n", toolAction);
363} 364}
364 365
365ssize_t toolaction_store(struct device *dev, struct device_attribute *attr, 366static ssize_t toolaction_store(struct device *dev,
366 const char *buf, size_t count) 367 struct device_attribute *attr,
368 const char *buf, size_t count)
367{ 369{
368 u8 toolAction; 370 u8 toolAction;
369 int ret; 371 int ret;
@@ -381,8 +383,9 @@ ssize_t toolaction_store(struct device *dev, struct device_attribute *attr,
381 return count; 383 return count;
382} 384}
383 385
384ssize_t boottotool_show(struct device *dev, struct device_attribute *attr, 386static ssize_t boottotool_show(struct device *dev,
385 char *buf) 387 struct device_attribute *attr,
388 char *buf)
386{ 389{
387 ULTRA_EFI_SPAR_INDICATION efiSparIndication; 390 ULTRA_EFI_SPAR_INDICATION efiSparIndication;
388 391
@@ -394,8 +397,9 @@ ssize_t boottotool_show(struct device *dev, struct device_attribute *attr,
394 efiSparIndication.BootToTool); 397 efiSparIndication.BootToTool);
395} 398}
396 399
397ssize_t boottotool_store(struct device *dev, struct device_attribute *attr, 400static ssize_t boottotool_store(struct device *dev,
398 const char *buf, size_t count) 401 struct device_attribute *attr,
402 const char *buf, size_t count)
399{ 403{
400 int val, ret; 404 int val, ret;
401 ULTRA_EFI_SPAR_INDICATION efiSparIndication; 405 ULTRA_EFI_SPAR_INDICATION efiSparIndication;
@@ -1897,7 +1901,7 @@ handle_command(CONTROLVM_MESSAGE inmsg, HOSTADDRESS channel_addr)
1897 return TRUE; 1901 return TRUE;
1898} 1902}
1899 1903
1900HOSTADDRESS controlvm_get_channel_address(void) 1904static HOSTADDRESS controlvm_get_channel_address(void)
1901{ 1905{
1902 u64 addr = 0; 1906 u64 addr = 0;
1903 u32 size = 0; 1907 u32 size = 0;