diff options
author | David S. Miller <davem@davemloft.net> | 2014-12-12 15:15:50 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-12-12 15:15:50 -0500 |
commit | d717e90420db737325928959a6b8651bb88a304a (patch) | |
tree | c10e7cde175984e2972c26fe1bf0d6b1b1917b4b | |
parent | a169758a271768eeebdbc3260435558534695015 (diff) | |
parent | 7142637dd93a7e1e9f5515e6c66c7d271fa92ad2 (diff) |
Merge branch 'kill_tasklet_hi_enable'
Quentin Lambert says:
====================
Remove redundant function
tasklet_hi_enable and tasklet_enable are redundant. Since
tasklet_hi_enable is used only 6 times in 1 file, the first
patch changes calls to the function with calls to tasklet_enable.
The second patch removes tasklet_hi_enable definition.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/jme.c | 12 | ||||
-rw-r--r-- | include/linux/interrupt.h | 6 |
2 files changed, 6 insertions, 12 deletions
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index 4a1be34d7214..44ce7d88f554 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c | |||
@@ -1364,8 +1364,8 @@ err_out_free_rx_resources: | |||
1364 | jme_free_rx_resources(jme); | 1364 | jme_free_rx_resources(jme); |
1365 | out_enable_tasklet: | 1365 | out_enable_tasklet: |
1366 | tasklet_enable(&jme->txclean_task); | 1366 | tasklet_enable(&jme->txclean_task); |
1367 | tasklet_hi_enable(&jme->rxclean_task); | 1367 | tasklet_enable(&jme->rxclean_task); |
1368 | tasklet_hi_enable(&jme->rxempty_task); | 1368 | tasklet_enable(&jme->rxempty_task); |
1369 | out: | 1369 | out: |
1370 | atomic_inc(&jme->link_changing); | 1370 | atomic_inc(&jme->link_changing); |
1371 | } | 1371 | } |
@@ -2408,8 +2408,8 @@ static inline void jme_resume_rx(struct jme_adapter *jme) | |||
2408 | if (test_bit(JME_FLAG_POLL, &jme->flags)) { | 2408 | if (test_bit(JME_FLAG_POLL, &jme->flags)) { |
2409 | JME_NAPI_ENABLE(jme); | 2409 | JME_NAPI_ENABLE(jme); |
2410 | } else { | 2410 | } else { |
2411 | tasklet_hi_enable(&jme->rxclean_task); | 2411 | tasklet_enable(&jme->rxclean_task); |
2412 | tasklet_hi_enable(&jme->rxempty_task); | 2412 | tasklet_enable(&jme->rxempty_task); |
2413 | } | 2413 | } |
2414 | dpi->cur = PCC_P1; | 2414 | dpi->cur = PCC_P1; |
2415 | dpi->attempt = PCC_P1; | 2415 | dpi->attempt = PCC_P1; |
@@ -3290,8 +3290,8 @@ jme_suspend(struct device *dev) | |||
3290 | } | 3290 | } |
3291 | 3291 | ||
3292 | tasklet_enable(&jme->txclean_task); | 3292 | tasklet_enable(&jme->txclean_task); |
3293 | tasklet_hi_enable(&jme->rxclean_task); | 3293 | tasklet_enable(&jme->rxclean_task); |
3294 | tasklet_hi_enable(&jme->rxempty_task); | 3294 | tasklet_enable(&jme->rxempty_task); |
3295 | 3295 | ||
3296 | jme_powersave_phy(jme); | 3296 | jme_powersave_phy(jme); |
3297 | 3297 | ||
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 69517a24bc50..d9b05b5bf8c7 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h | |||
@@ -556,12 +556,6 @@ static inline void tasklet_enable(struct tasklet_struct *t) | |||
556 | atomic_dec(&t->count); | 556 | atomic_dec(&t->count); |
557 | } | 557 | } |
558 | 558 | ||
559 | static inline void tasklet_hi_enable(struct tasklet_struct *t) | ||
560 | { | ||
561 | smp_mb__before_atomic(); | ||
562 | atomic_dec(&t->count); | ||
563 | } | ||
564 | |||
565 | extern void tasklet_kill(struct tasklet_struct *t); | 559 | extern void tasklet_kill(struct tasklet_struct *t); |
566 | extern void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu); | 560 | extern void tasklet_kill_immediate(struct tasklet_struct *t, unsigned int cpu); |
567 | extern void tasklet_init(struct tasklet_struct *t, | 561 | extern void tasklet_init(struct tasklet_struct *t, |