aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXie XiuQi <xiexiuqi@huawei.com>2014-01-24 15:00:51 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2014-01-25 18:31:58 -0500
commitccb3368cb4b97e2d8a763b894303e6a127f87bc8 (patch)
treeec617172c159c1ab40fec494b36ad69e76e3232a
parentaa5b2bab9c3eeb1f8135ba5e30c3ce712e099d81 (diff)
ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful
Use USEC_PER_SEC instead of 1000000, that making the later bugfix more clearly. Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com> Signed-off-by: Corey Minyard <cminyard@mvista.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/char/ipmi/ipmi_bt_sm.c8
-rw-r--r--drivers/char/ipmi/ipmi_kcs_sm.c4
-rw-r--r--drivers/char/ipmi/ipmi_smic_sm.c2
3 files changed, 7 insertions, 7 deletions
diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
index a22a7a502740..f5e4cd7617f6 100644
--- a/drivers/char/ipmi/ipmi_bt_sm.c
+++ b/drivers/char/ipmi/ipmi_bt_sm.c
@@ -201,7 +201,7 @@ static unsigned int bt_init_data(struct si_sm_data *bt, struct si_sm_io *io)
201 } 201 }
202 bt->state = BT_STATE_IDLE; /* start here */ 202 bt->state = BT_STATE_IDLE; /* start here */
203 bt->complete = BT_STATE_IDLE; /* end here */ 203 bt->complete = BT_STATE_IDLE; /* end here */
204 bt->BT_CAP_req2rsp = BT_NORMAL_TIMEOUT * 1000000; 204 bt->BT_CAP_req2rsp = BT_NORMAL_TIMEOUT * USEC_PER_SEC;
205 bt->BT_CAP_retries = BT_NORMAL_RETRY_LIMIT; 205 bt->BT_CAP_retries = BT_NORMAL_RETRY_LIMIT;
206 /* BT_CAP_outreqs == zero is a flag to read BT Capabilities */ 206 /* BT_CAP_outreqs == zero is a flag to read BT Capabilities */
207 return 3; /* We claim 3 bytes of space; ought to check SPMI table */ 207 return 3; /* We claim 3 bytes of space; ought to check SPMI table */
@@ -613,7 +613,7 @@ static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
613 HOST2BMC(42); /* Sequence number */ 613 HOST2BMC(42); /* Sequence number */
614 HOST2BMC(3); /* Cmd == Soft reset */ 614 HOST2BMC(3); /* Cmd == Soft reset */
615 BT_CONTROL(BT_H2B_ATN); 615 BT_CONTROL(BT_H2B_ATN);
616 bt->timeout = BT_RESET_DELAY * 1000000; 616 bt->timeout = BT_RESET_DELAY * USEC_PER_SEC;
617 BT_STATE_CHANGE(BT_STATE_RESET3, 617 BT_STATE_CHANGE(BT_STATE_RESET3,
618 SI_SM_CALL_WITH_DELAY); 618 SI_SM_CALL_WITH_DELAY);
619 619
@@ -651,14 +651,14 @@ static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
651 bt_init_data(bt, bt->io); 651 bt_init_data(bt, bt->io);
652 if ((i == 8) && !BT_CAP[2]) { 652 if ((i == 8) && !BT_CAP[2]) {
653 bt->BT_CAP_outreqs = BT_CAP[3]; 653 bt->BT_CAP_outreqs = BT_CAP[3];
654 bt->BT_CAP_req2rsp = BT_CAP[6] * 1000000; 654 bt->BT_CAP_req2rsp = BT_CAP[6] * USEC_PER_SEC;
655 bt->BT_CAP_retries = BT_CAP[7]; 655 bt->BT_CAP_retries = BT_CAP[7];
656 } else 656 } else
657 printk(KERN_WARNING "IPMI BT: using default values\n"); 657 printk(KERN_WARNING "IPMI BT: using default values\n");
658 if (!bt->BT_CAP_outreqs) 658 if (!bt->BT_CAP_outreqs)
659 bt->BT_CAP_outreqs = 1; 659 bt->BT_CAP_outreqs = 1;
660 printk(KERN_WARNING "IPMI BT: req2rsp=%ld secs retries=%d\n", 660 printk(KERN_WARNING "IPMI BT: req2rsp=%ld secs retries=%d\n",
661 bt->BT_CAP_req2rsp / 1000000L, bt->BT_CAP_retries); 661 bt->BT_CAP_req2rsp / USEC_PER_SEC, bt->BT_CAP_retries);
662 bt->timeout = bt->BT_CAP_req2rsp; 662 bt->timeout = bt->BT_CAP_req2rsp;
663 return SI_SM_CALL_WITHOUT_DELAY; 663 return SI_SM_CALL_WITHOUT_DELAY;
664 664
diff --git a/drivers/char/ipmi/ipmi_kcs_sm.c b/drivers/char/ipmi/ipmi_kcs_sm.c
index e53fc24c6af3..6a4bdc18955a 100644
--- a/drivers/char/ipmi/ipmi_kcs_sm.c
+++ b/drivers/char/ipmi/ipmi_kcs_sm.c
@@ -118,8 +118,8 @@ enum kcs_states {
118#define MAX_KCS_WRITE_SIZE IPMI_MAX_MSG_LENGTH 118#define MAX_KCS_WRITE_SIZE IPMI_MAX_MSG_LENGTH
119 119
120/* Timeouts in microseconds. */ 120/* Timeouts in microseconds. */
121#define IBF_RETRY_TIMEOUT 5000000 121#define IBF_RETRY_TIMEOUT (5*USEC_PER_SEC)
122#define OBF_RETRY_TIMEOUT 5000000 122#define OBF_RETRY_TIMEOUT (5*USEC_PER_SEC)
123#define MAX_ERROR_RETRIES 10 123#define MAX_ERROR_RETRIES 10
124#define ERROR0_OBF_WAIT_JIFFIES (2*HZ) 124#define ERROR0_OBF_WAIT_JIFFIES (2*HZ)
125 125
diff --git a/drivers/char/ipmi/ipmi_smic_sm.c b/drivers/char/ipmi/ipmi_smic_sm.c
index faed92971907..c8e77afa8b96 100644
--- a/drivers/char/ipmi/ipmi_smic_sm.c
+++ b/drivers/char/ipmi/ipmi_smic_sm.c
@@ -80,7 +80,7 @@ enum smic_states {
80#define SMIC_MAX_ERROR_RETRIES 3 80#define SMIC_MAX_ERROR_RETRIES 3
81 81
82/* Timeouts in microseconds. */ 82/* Timeouts in microseconds. */
83#define SMIC_RETRY_TIMEOUT 2000000 83#define SMIC_RETRY_TIMEOUT (2*USEC_PER_SEC)
84 84
85/* SMIC Flags Register Bits */ 85/* SMIC Flags Register Bits */
86#define SMIC_RX_DATA_READY 0x80 86#define SMIC_RX_DATA_READY 0x80