diff options
author | Rajesh Borundia <rajesh.borundia@qlogic.com> | 2014-06-04 03:40:54 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-06-05 18:06:09 -0400 |
commit | c531692073847fe64635f6992d774fb319e3529a (patch) | |
tree | 29977c34835cf70c3b9ca0df9b8906040cc43474 | |
parent | d4c642ea1239f0c5c1d794a5b788319d3373c58c (diff) |
qlcnic: Initialize mailbox cmd structure to zero
o Uninitialzed fields in mailbox command structure
caused commands to time out randomly due to garbage
values so initialize it to zero.
Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c index 6afe9c1f5ab9..d9216afa93c1 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | |||
@@ -454,6 +454,7 @@ static int qlcnic_sriov_get_vf_acl(struct qlcnic_adapter *adapter) | |||
454 | struct qlcnic_cmd_args cmd; | 454 | struct qlcnic_cmd_args cmd; |
455 | int ret = 0; | 455 | int ret = 0; |
456 | 456 | ||
457 | memset(&cmd, 0, sizeof(cmd)); | ||
457 | ret = qlcnic_sriov_alloc_bc_mbx_args(&cmd, QLCNIC_BC_CMD_GET_ACL); | 458 | ret = qlcnic_sriov_alloc_bc_mbx_args(&cmd, QLCNIC_BC_CMD_GET_ACL); |
458 | if (ret) | 459 | if (ret) |
459 | return ret; | 460 | return ret; |
@@ -1441,6 +1442,7 @@ static int qlcnic_sriov_channel_cfg_cmd(struct qlcnic_adapter *adapter, u8 cmd_o | |||
1441 | struct qlcnic_vf_info *vf = &adapter->ahw->sriov->vf_info[0]; | 1442 | struct qlcnic_vf_info *vf = &adapter->ahw->sriov->vf_info[0]; |
1442 | int ret; | 1443 | int ret; |
1443 | 1444 | ||
1445 | memset(&cmd, 0, sizeof(cmd)); | ||
1444 | if (qlcnic_sriov_alloc_bc_mbx_args(&cmd, cmd_op)) | 1446 | if (qlcnic_sriov_alloc_bc_mbx_args(&cmd, cmd_op)) |
1445 | return -ENOMEM; | 1447 | return -ENOMEM; |
1446 | 1448 | ||
@@ -1998,6 +2000,7 @@ int qlcnic_sriov_cfg_vf_guest_vlan(struct qlcnic_adapter *adapter, | |||
1998 | struct qlcnic_cmd_args cmd; | 2000 | struct qlcnic_cmd_args cmd; |
1999 | int ret; | 2001 | int ret; |
2000 | 2002 | ||
2003 | memset(&cmd, 0, sizeof(cmd)); | ||
2001 | if (vid == 0) | 2004 | if (vid == 0) |
2002 | return 0; | 2005 | return 0; |
2003 | 2006 | ||