aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichal Nazarewicz <mina86@mina86.com>2013-11-12 18:11:39 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2013-11-12 22:09:35 -0500
commitbe2d3f97e90cdf9f1523daaba705f320c3efaf00 (patch)
treec0c01ad705af5a08782d2eb03122db0f5475af68
parent1a10bd9424d463e550676e74f4875863d1bae3f5 (diff)
drivers/memstick/core/mspro_block.c: fix attributes array allocation
attrs field of attribute_group structure is a pointer to a pointer (as in an array of pointers) rather than pointer to attribute struct (as in an array of structures), so when allocating size of the pointer sholud be used instead of the structure it is pointing to. While at it, also change the call to use kcalloc rather than kzalloc. Signed-off-by: Michal Nazarewicz <mina86@mina86.com> Cc: Tejun Heo <tj@kernel.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Alex Dubov <oakad@yahoo.com> Cc: Maxim Levitsky <maximlevitsky@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/memstick/core/mspro_block.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
index f4176ca3a794..fc145d202c46 100644
--- a/drivers/memstick/core/mspro_block.c
+++ b/drivers/memstick/core/mspro_block.c
@@ -1023,8 +1023,8 @@ static int mspro_block_read_attributes(struct memstick_dev *card)
1023 } else 1023 } else
1024 attr_count = attr->count; 1024 attr_count = attr->count;
1025 1025
1026 msb->attr_group.attrs = kzalloc((attr_count + 1) 1026 msb->attr_group.attrs = kcalloc(attr_count + 1,
1027 * sizeof(struct attribute), 1027 sizeof(*msb->attr_group.attrs),
1028 GFP_KERNEL); 1028 GFP_KERNEL);
1029 if (!msb->attr_group.attrs) { 1029 if (!msb->attr_group.attrs) {
1030 rc = -ENOMEM; 1030 rc = -ENOMEM;