diff options
author | Allan Stephens <Allan.Stephens@windriver.com> | 2010-12-31 13:59:25 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-01-01 16:57:52 -0500 |
commit | b29f14284989b3d0b3a5ce268b5b1fc4df9c5795 (patch) | |
tree | a690fc7db347cb8ca2b38dc1da73a477d1fb4779 | |
parent | f5e75269f59f7c3816f23314b924895e4ecf8409 (diff) |
tipc: remove calls to dbg() and msg_dbg()
Eliminates obsolete calls to two of TIPC's main debugging macros, as well
as a pair of associated debugging routines that are no longer required.
Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/tipc/bcast.c | 3 | ||||
-rw-r--r-- | net/tipc/bearer.c | 1 | ||||
-rw-r--r-- | net/tipc/config.c | 4 | ||||
-rw-r--r-- | net/tipc/core.h | 4 | ||||
-rw-r--r-- | net/tipc/discover.c | 4 | ||||
-rw-r--r-- | net/tipc/link.c | 119 | ||||
-rw-r--r-- | net/tipc/name_distr.c | 14 | ||||
-rw-r--r-- | net/tipc/name_table.c | 33 | ||||
-rw-r--r-- | net/tipc/net.c | 10 | ||||
-rw-r--r-- | net/tipc/node.c | 3 | ||||
-rw-r--r-- | net/tipc/port.c | 10 | ||||
-rw-r--r-- | net/tipc/port.h | 1 | ||||
-rw-r--r-- | net/tipc/socket.c | 39 | ||||
-rw-r--r-- | net/tipc/subscr.c | 4 |
14 files changed, 16 insertions, 233 deletions
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index 110829eab96a..cb817d503c14 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c | |||
@@ -436,8 +436,6 @@ void tipc_bclink_recv_pkt(struct sk_buff *buf) | |||
436 | u32 seqno; | 436 | u32 seqno; |
437 | struct sk_buff *deferred; | 437 | struct sk_buff *deferred; |
438 | 438 | ||
439 | msg_dbg(msg, "<BC<<<"); | ||
440 | |||
441 | if (unlikely(!node || !tipc_node_is_up(node) || !node->bclink.supported || | 439 | if (unlikely(!node || !tipc_node_is_up(node) || !node->bclink.supported || |
442 | (msg_mc_netid(msg) != tipc_net_id))) { | 440 | (msg_mc_netid(msg) != tipc_net_id))) { |
443 | buf_discard(buf); | 441 | buf_discard(buf); |
@@ -445,7 +443,6 @@ void tipc_bclink_recv_pkt(struct sk_buff *buf) | |||
445 | } | 443 | } |
446 | 444 | ||
447 | if (unlikely(msg_user(msg) == BCAST_PROTOCOL)) { | 445 | if (unlikely(msg_user(msg) == BCAST_PROTOCOL)) { |
448 | msg_dbg(msg, "<BCNACK<<<"); | ||
449 | if (msg_destnode(msg) == tipc_own_addr) { | 446 | if (msg_destnode(msg) == tipc_own_addr) { |
450 | tipc_node_lock(node); | 447 | tipc_node_lock(node); |
451 | tipc_bclink_acknowledge(node, msg_bcast_ack(msg)); | 448 | tipc_bclink_acknowledge(node, msg_bcast_ack(msg)); |
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 885da94be4ac..24dc6c2c75ad 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c | |||
@@ -164,7 +164,6 @@ int tipc_register_media(u32 media_type, | |||
164 | m_ptr->priority = bearer_priority; | 164 | m_ptr->priority = bearer_priority; |
165 | m_ptr->tolerance = link_tolerance; | 165 | m_ptr->tolerance = link_tolerance; |
166 | m_ptr->window = send_window_limit; | 166 | m_ptr->window = send_window_limit; |
167 | dbg("Media <%s> registered\n", name); | ||
168 | res = 0; | 167 | res = 0; |
169 | exit: | 168 | exit: |
170 | write_unlock_bh(&tipc_net_lock); | 169 | write_unlock_bh(&tipc_net_lock); |
diff --git a/net/tipc/config.c b/net/tipc/config.c index afa6e853c04b..a7894ff77ae9 100644 --- a/net/tipc/config.c +++ b/net/tipc/config.c | |||
@@ -65,10 +65,8 @@ int tipc_cfg_append_tlv(struct sk_buff *buf, int tlv_type, | |||
65 | struct tlv_desc *tlv = (struct tlv_desc *)skb_tail_pointer(buf); | 65 | struct tlv_desc *tlv = (struct tlv_desc *)skb_tail_pointer(buf); |
66 | int new_tlv_space = TLV_SPACE(tlv_data_size); | 66 | int new_tlv_space = TLV_SPACE(tlv_data_size); |
67 | 67 | ||
68 | if (skb_tailroom(buf) < new_tlv_space) { | 68 | if (skb_tailroom(buf) < new_tlv_space) |
69 | dbg("tipc_cfg_append_tlv unable to append TLV\n"); | ||
70 | return 0; | 69 | return 0; |
71 | } | ||
72 | skb_put(buf, new_tlv_space); | 70 | skb_put(buf, new_tlv_space); |
73 | tlv->tlv_type = htons(tlv_type); | 71 | tlv->tlv_type = htons(tlv_type); |
74 | tlv->tlv_len = htons(TLV_LENGTH(tlv_data_size)); | 72 | tlv->tlv_len = htons(TLV_LENGTH(tlv_data_size)); |
diff --git a/net/tipc/core.h b/net/tipc/core.h index 17f3670ed95d..b4e54f8dd43b 100644 --- a/net/tipc/core.h +++ b/net/tipc/core.h | |||
@@ -243,7 +243,6 @@ u32 tipc_k_signal(Handler routine, unsigned long argument); | |||
243 | static inline void k_init_timer(struct timer_list *timer, Handler routine, | 243 | static inline void k_init_timer(struct timer_list *timer, Handler routine, |
244 | unsigned long argument) | 244 | unsigned long argument) |
245 | { | 245 | { |
246 | dbg("initializing timer %p\n", timer); | ||
247 | setup_timer(timer, routine, argument); | 246 | setup_timer(timer, routine, argument); |
248 | } | 247 | } |
249 | 248 | ||
@@ -263,7 +262,6 @@ static inline void k_init_timer(struct timer_list *timer, Handler routine, | |||
263 | 262 | ||
264 | static inline void k_start_timer(struct timer_list *timer, unsigned long msec) | 263 | static inline void k_start_timer(struct timer_list *timer, unsigned long msec) |
265 | { | 264 | { |
266 | dbg("starting timer %p for %u\n", timer, msec); | ||
267 | mod_timer(timer, jiffies + msecs_to_jiffies(msec) + 1); | 265 | mod_timer(timer, jiffies + msecs_to_jiffies(msec) + 1); |
268 | } | 266 | } |
269 | 267 | ||
@@ -280,7 +278,6 @@ static inline void k_start_timer(struct timer_list *timer, unsigned long msec) | |||
280 | 278 | ||
281 | static inline void k_cancel_timer(struct timer_list *timer) | 279 | static inline void k_cancel_timer(struct timer_list *timer) |
282 | { | 280 | { |
283 | dbg("cancelling timer %p\n", timer); | ||
284 | del_timer_sync(timer); | 281 | del_timer_sync(timer); |
285 | } | 282 | } |
286 | 283 | ||
@@ -298,7 +295,6 @@ static inline void k_cancel_timer(struct timer_list *timer) | |||
298 | 295 | ||
299 | static inline void k_term_timer(struct timer_list *timer) | 296 | static inline void k_term_timer(struct timer_list *timer) |
300 | { | 297 | { |
301 | dbg("terminating timer %p\n", timer); | ||
302 | } | 298 | } |
303 | 299 | ||
304 | 300 | ||
diff --git a/net/tipc/discover.c b/net/tipc/discover.c index 80799f6ba892..e7223789d150 100644 --- a/net/tipc/discover.c +++ b/net/tipc/discover.c | |||
@@ -133,7 +133,6 @@ void tipc_disc_recv_msg(struct sk_buff *buf, struct bearer *b_ptr) | |||
133 | u32 type = msg_type(msg); | 133 | u32 type = msg_type(msg); |
134 | 134 | ||
135 | msg_get_media_addr(msg,&media_addr); | 135 | msg_get_media_addr(msg,&media_addr); |
136 | msg_dbg(msg, "RECV:"); | ||
137 | buf_discard(buf); | 136 | buf_discard(buf); |
138 | 137 | ||
139 | if (net_id != tipc_net_id) | 138 | if (net_id != tipc_net_id) |
@@ -156,7 +155,6 @@ void tipc_disc_recv_msg(struct sk_buff *buf, struct bearer *b_ptr) | |||
156 | struct tipc_node *n_ptr = tipc_node_find(orig); | 155 | struct tipc_node *n_ptr = tipc_node_find(orig); |
157 | int link_fully_up; | 156 | int link_fully_up; |
158 | 157 | ||
159 | dbg(" in own cluster\n"); | ||
160 | if (n_ptr == NULL) { | 158 | if (n_ptr == NULL) { |
161 | n_ptr = tipc_node_create(orig); | 159 | n_ptr = tipc_node_create(orig); |
162 | if (!n_ptr) | 160 | if (!n_ptr) |
@@ -173,7 +171,6 @@ void tipc_disc_recv_msg(struct sk_buff *buf, struct bearer *b_ptr) | |||
173 | 171 | ||
174 | link = n_ptr->links[b_ptr->identity]; | 172 | link = n_ptr->links[b_ptr->identity]; |
175 | if (!link) { | 173 | if (!link) { |
176 | dbg("creating link\n"); | ||
177 | link = tipc_link_create(b_ptr, orig, &media_addr); | 174 | link = tipc_link_create(b_ptr, orig, &media_addr); |
178 | if (!link) { | 175 | if (!link) { |
179 | spin_unlock_bh(&n_ptr->lock); | 176 | spin_unlock_bh(&n_ptr->lock); |
@@ -198,7 +195,6 @@ void tipc_disc_recv_msg(struct sk_buff *buf, struct bearer *b_ptr) | |||
198 | return; | 195 | return; |
199 | rbuf = tipc_disc_init_msg(DSC_RESP_MSG, 1, orig, b_ptr); | 196 | rbuf = tipc_disc_init_msg(DSC_RESP_MSG, 1, orig, b_ptr); |
200 | if (rbuf != NULL) { | 197 | if (rbuf != NULL) { |
201 | msg_dbg(buf_msg(rbuf),"SEND:"); | ||
202 | b_ptr->media->send_msg(rbuf, &b_ptr->publ, &media_addr); | 198 | b_ptr->media->send_msg(rbuf, &b_ptr->publ, &media_addr); |
203 | buf_discard(rbuf); | 199 | buf_discard(rbuf); |
204 | } | 200 | } |
diff --git a/net/tipc/link.c b/net/tipc/link.c index 671ffd3c0e53..cb10d20caef3 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c | |||
@@ -153,18 +153,6 @@ static void dbg_print_link(struct link *l_ptr, const char *str) | |||
153 | link_print(l_ptr, DBG_OUTPUT, str); | 153 | link_print(l_ptr, DBG_OUTPUT, str); |
154 | } | 154 | } |
155 | 155 | ||
156 | static void dbg_print_buf_chain(struct sk_buff *root_buf) | ||
157 | { | ||
158 | if (DBG_OUTPUT != TIPC_NULL) { | ||
159 | struct sk_buff *buf = root_buf; | ||
160 | |||
161 | while (buf) { | ||
162 | msg_dbg(buf_msg(buf), "In chain: "); | ||
163 | buf = buf->next; | ||
164 | } | ||
165 | } | ||
166 | } | ||
167 | |||
168 | /* | 156 | /* |
169 | * Simple link routines | 157 | * Simple link routines |
170 | */ | 158 | */ |
@@ -433,9 +421,6 @@ struct link *tipc_link_create(struct bearer *b_ptr, const u32 peer, | |||
433 | list_add_tail(&l_ptr->link_list, &b_ptr->links); | 421 | list_add_tail(&l_ptr->link_list, &b_ptr->links); |
434 | tipc_k_signal((Handler)link_start, (unsigned long)l_ptr); | 422 | tipc_k_signal((Handler)link_start, (unsigned long)l_ptr); |
435 | 423 | ||
436 | dbg("tipc_link_create(): tolerance = %u,cont intv = %u, abort_limit = %u\n", | ||
437 | l_ptr->tolerance, l_ptr->continuity_interval, l_ptr->abort_limit); | ||
438 | |||
439 | return l_ptr; | 424 | return l_ptr; |
440 | } | 425 | } |
441 | 426 | ||
@@ -455,8 +440,6 @@ void tipc_link_delete(struct link *l_ptr) | |||
455 | return; | 440 | return; |
456 | } | 441 | } |
457 | 442 | ||
458 | dbg("tipc_link_delete()\n"); | ||
459 | |||
460 | k_cancel_timer(&l_ptr->timer); | 443 | k_cancel_timer(&l_ptr->timer); |
461 | 444 | ||
462 | tipc_node_lock(l_ptr->owner); | 445 | tipc_node_lock(l_ptr->owner); |
@@ -473,7 +456,6 @@ void tipc_link_delete(struct link *l_ptr) | |||
473 | 456 | ||
474 | static void link_start(struct link *l_ptr) | 457 | static void link_start(struct link *l_ptr) |
475 | { | 458 | { |
476 | dbg("link_start %x\n", l_ptr); | ||
477 | link_state_event(l_ptr, STARTING_EVT); | 459 | link_state_event(l_ptr, STARTING_EVT); |
478 | } | 460 | } |
479 | 461 | ||
@@ -926,9 +908,6 @@ static int link_bundle_buf(struct link *l_ptr, | |||
926 | skb_copy_to_linear_data_offset(bundler, to_pos, buf->data, size); | 908 | skb_copy_to_linear_data_offset(bundler, to_pos, buf->data, size); |
927 | msg_set_size(bundler_msg, to_pos + size); | 909 | msg_set_size(bundler_msg, to_pos + size); |
928 | msg_set_msgcnt(bundler_msg, msg_msgcnt(bundler_msg) + 1); | 910 | msg_set_msgcnt(bundler_msg, msg_msgcnt(bundler_msg) + 1); |
929 | dbg("Packed msg # %u(%u octets) into pos %u in buf(#%u)\n", | ||
930 | msg_msgcnt(bundler_msg), size, to_pos, msg_seqno(bundler_msg)); | ||
931 | msg_dbg(msg, "PACKD:"); | ||
932 | buf_discard(buf); | 911 | buf_discard(buf); |
933 | l_ptr->stats.sent_bundled++; | 912 | l_ptr->stats.sent_bundled++; |
934 | return 1; | 913 | return 1; |
@@ -977,7 +956,6 @@ int tipc_link_send_buf(struct link *l_ptr, struct sk_buff *buf) | |||
977 | return link_schedule_port(l_ptr, msg_origport(msg), | 956 | return link_schedule_port(l_ptr, msg_origport(msg), |
978 | size); | 957 | size); |
979 | } | 958 | } |
980 | msg_dbg(msg, "TIPC: Congestion, throwing away\n"); | ||
981 | buf_discard(buf); | 959 | buf_discard(buf); |
982 | if (imp > CONN_MANAGER) { | 960 | if (imp > CONN_MANAGER) { |
983 | warn("Resetting link <%s>, send queue full", l_ptr->name); | 961 | warn("Resetting link <%s>, send queue full", l_ptr->name); |
@@ -1066,17 +1044,12 @@ int tipc_link_send(struct sk_buff *buf, u32 dest, u32 selector) | |||
1066 | tipc_node_lock(n_ptr); | 1044 | tipc_node_lock(n_ptr); |
1067 | l_ptr = n_ptr->active_links[selector & 1]; | 1045 | l_ptr = n_ptr->active_links[selector & 1]; |
1068 | if (l_ptr) { | 1046 | if (l_ptr) { |
1069 | dbg("tipc_link_send: found link %x for dest %x\n", l_ptr, dest); | ||
1070 | res = tipc_link_send_buf(l_ptr, buf); | 1047 | res = tipc_link_send_buf(l_ptr, buf); |
1071 | } else { | 1048 | } else { |
1072 | dbg("Attempt to send msg to unreachable node:\n"); | ||
1073 | msg_dbg(buf_msg(buf),">>>"); | ||
1074 | buf_discard(buf); | 1049 | buf_discard(buf); |
1075 | } | 1050 | } |
1076 | tipc_node_unlock(n_ptr); | 1051 | tipc_node_unlock(n_ptr); |
1077 | } else { | 1052 | } else { |
1078 | dbg("Attempt to send msg to unknown node:\n"); | ||
1079 | msg_dbg(buf_msg(buf),">>>"); | ||
1080 | buf_discard(buf); | 1053 | buf_discard(buf); |
1081 | } | 1054 | } |
1082 | read_unlock_bh(&tipc_net_lock); | 1055 | read_unlock_bh(&tipc_net_lock); |
@@ -1103,10 +1076,8 @@ static int link_send_buf_fast(struct link *l_ptr, struct sk_buff *buf, | |||
1103 | if (likely(tipc_bearer_send(l_ptr->b_ptr, buf, | 1076 | if (likely(tipc_bearer_send(l_ptr->b_ptr, buf, |
1104 | &l_ptr->media_addr))) { | 1077 | &l_ptr->media_addr))) { |
1105 | l_ptr->unacked_window = 0; | 1078 | l_ptr->unacked_window = 0; |
1106 | msg_dbg(msg,"SENT_FAST:"); | ||
1107 | return res; | 1079 | return res; |
1108 | } | 1080 | } |
1109 | dbg("failed sent fast...\n"); | ||
1110 | tipc_bearer_schedule(l_ptr->b_ptr, l_ptr); | 1081 | tipc_bearer_schedule(l_ptr->b_ptr, l_ptr); |
1111 | l_ptr->stats.bearer_congs++; | 1082 | l_ptr->stats.bearer_congs++; |
1112 | l_ptr->next_out = buf; | 1083 | l_ptr->next_out = buf; |
@@ -1141,8 +1112,6 @@ int tipc_send_buf_fast(struct sk_buff *buf, u32 destnode) | |||
1141 | if (likely(n_ptr)) { | 1112 | if (likely(n_ptr)) { |
1142 | tipc_node_lock(n_ptr); | 1113 | tipc_node_lock(n_ptr); |
1143 | l_ptr = n_ptr->active_links[selector]; | 1114 | l_ptr = n_ptr->active_links[selector]; |
1144 | dbg("send_fast: buf %x selected %x, destnode = %x\n", | ||
1145 | buf, l_ptr, destnode); | ||
1146 | if (likely(l_ptr)) { | 1115 | if (likely(l_ptr)) { |
1147 | res = link_send_buf_fast(l_ptr, buf, &dummy); | 1116 | res = link_send_buf_fast(l_ptr, buf, &dummy); |
1148 | tipc_node_unlock(n_ptr); | 1117 | tipc_node_unlock(n_ptr); |
@@ -1292,7 +1261,6 @@ again: | |||
1292 | 1261 | ||
1293 | /* Prepare reusable fragment header: */ | 1262 | /* Prepare reusable fragment header: */ |
1294 | 1263 | ||
1295 | msg_dbg(hdr, ">FRAGMENTING>"); | ||
1296 | tipc_msg_init(&fragm_hdr, MSG_FRAGMENTER, FIRST_FRAGMENT, | 1264 | tipc_msg_init(&fragm_hdr, MSG_FRAGMENTER, FIRST_FRAGMENT, |
1297 | INT_H_SIZE, msg_destnode(hdr)); | 1265 | INT_H_SIZE, msg_destnode(hdr)); |
1298 | msg_set_link_selector(&fragm_hdr, sender->publ.ref); | 1266 | msg_set_link_selector(&fragm_hdr, sender->publ.ref); |
@@ -1308,7 +1276,6 @@ again: | |||
1308 | skb_copy_to_linear_data(buf, &fragm_hdr, INT_H_SIZE); | 1276 | skb_copy_to_linear_data(buf, &fragm_hdr, INT_H_SIZE); |
1309 | hsz = msg_hdr_sz(hdr); | 1277 | hsz = msg_hdr_sz(hdr); |
1310 | skb_copy_to_linear_data_offset(buf, INT_H_SIZE, hdr, hsz); | 1278 | skb_copy_to_linear_data_offset(buf, INT_H_SIZE, hdr, hsz); |
1311 | msg_dbg(buf_msg(buf), ">BUILD>"); | ||
1312 | 1279 | ||
1313 | /* Chop up message: */ | 1280 | /* Chop up message: */ |
1314 | 1281 | ||
@@ -1367,7 +1334,6 @@ error: | |||
1367 | skb_copy_to_linear_data(buf, &fragm_hdr, INT_H_SIZE); | 1334 | skb_copy_to_linear_data(buf, &fragm_hdr, INT_H_SIZE); |
1368 | fragm_crs = INT_H_SIZE; | 1335 | fragm_crs = INT_H_SIZE; |
1369 | fragm_rest = fragm_sz; | 1336 | fragm_rest = fragm_sz; |
1370 | msg_dbg(buf_msg(buf)," >BUILD>"); | ||
1371 | } | 1337 | } |
1372 | } | 1338 | } |
1373 | while (rest > 0); | 1339 | while (rest > 0); |
@@ -1417,7 +1383,6 @@ reject: | |||
1417 | l_ptr->stats.sent_fragments++; | 1383 | l_ptr->stats.sent_fragments++; |
1418 | msg_set_long_msgno(msg, l_ptr->long_msg_seq_no); | 1384 | msg_set_long_msgno(msg, l_ptr->long_msg_seq_no); |
1419 | link_add_to_outqueue(l_ptr, buf, msg); | 1385 | link_add_to_outqueue(l_ptr, buf, msg); |
1420 | msg_dbg(msg, ">ADD>"); | ||
1421 | buf = next; | 1386 | buf = next; |
1422 | } | 1387 | } |
1423 | 1388 | ||
@@ -1459,14 +1424,12 @@ u32 tipc_link_push_packet(struct link *l_ptr) | |||
1459 | msg_set_ack(buf_msg(buf), mod(l_ptr->next_in_no - 1)); | 1424 | msg_set_ack(buf_msg(buf), mod(l_ptr->next_in_no - 1)); |
1460 | msg_set_bcast_ack(buf_msg(buf), l_ptr->owner->bclink.last_in); | 1425 | msg_set_bcast_ack(buf_msg(buf), l_ptr->owner->bclink.last_in); |
1461 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { | 1426 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { |
1462 | msg_dbg(buf_msg(buf), ">DEF-RETR>"); | ||
1463 | l_ptr->retransm_queue_head = mod(++r_q_head); | 1427 | l_ptr->retransm_queue_head = mod(++r_q_head); |
1464 | l_ptr->retransm_queue_size = --r_q_size; | 1428 | l_ptr->retransm_queue_size = --r_q_size; |
1465 | l_ptr->stats.retransmitted++; | 1429 | l_ptr->stats.retransmitted++; |
1466 | return 0; | 1430 | return 0; |
1467 | } else { | 1431 | } else { |
1468 | l_ptr->stats.bearer_congs++; | 1432 | l_ptr->stats.bearer_congs++; |
1469 | msg_dbg(buf_msg(buf), "|>DEF-RETR>"); | ||
1470 | return PUSH_FAILED; | 1433 | return PUSH_FAILED; |
1471 | } | 1434 | } |
1472 | } | 1435 | } |
@@ -1478,13 +1441,11 @@ u32 tipc_link_push_packet(struct link *l_ptr) | |||
1478 | msg_set_ack(buf_msg(buf), mod(l_ptr->next_in_no - 1)); | 1441 | msg_set_ack(buf_msg(buf), mod(l_ptr->next_in_no - 1)); |
1479 | msg_set_bcast_ack(buf_msg(buf),l_ptr->owner->bclink.last_in); | 1442 | msg_set_bcast_ack(buf_msg(buf),l_ptr->owner->bclink.last_in); |
1480 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { | 1443 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { |
1481 | msg_dbg(buf_msg(buf), ">DEF-PROT>"); | ||
1482 | l_ptr->unacked_window = 0; | 1444 | l_ptr->unacked_window = 0; |
1483 | buf_discard(buf); | 1445 | buf_discard(buf); |
1484 | l_ptr->proto_msg_queue = NULL; | 1446 | l_ptr->proto_msg_queue = NULL; |
1485 | return 0; | 1447 | return 0; |
1486 | } else { | 1448 | } else { |
1487 | msg_dbg(buf_msg(buf), "|>DEF-PROT>"); | ||
1488 | l_ptr->stats.bearer_congs++; | 1449 | l_ptr->stats.bearer_congs++; |
1489 | return PUSH_FAILED; | 1450 | return PUSH_FAILED; |
1490 | } | 1451 | } |
@@ -1504,11 +1465,9 @@ u32 tipc_link_push_packet(struct link *l_ptr) | |||
1504 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { | 1465 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { |
1505 | if (msg_user(msg) == MSG_BUNDLER) | 1466 | if (msg_user(msg) == MSG_BUNDLER) |
1506 | msg_set_type(msg, CLOSED_MSG); | 1467 | msg_set_type(msg, CLOSED_MSG); |
1507 | msg_dbg(msg, ">PUSH-DATA>"); | ||
1508 | l_ptr->next_out = buf->next; | 1468 | l_ptr->next_out = buf->next; |
1509 | return 0; | 1469 | return 0; |
1510 | } else { | 1470 | } else { |
1511 | msg_dbg(msg, "|PUSH-DATA|"); | ||
1512 | l_ptr->stats.bearer_congs++; | 1471 | l_ptr->stats.bearer_congs++; |
1513 | return PUSH_FAILED; | 1472 | return PUSH_FAILED; |
1514 | } | 1473 | } |
@@ -1571,7 +1530,6 @@ static void link_retransmit_failure(struct link *l_ptr, struct sk_buff *buf) | |||
1571 | struct tipc_msg *msg = buf_msg(buf); | 1530 | struct tipc_msg *msg = buf_msg(buf); |
1572 | 1531 | ||
1573 | warn("Retransmission failure on link <%s>\n", l_ptr->name); | 1532 | warn("Retransmission failure on link <%s>\n", l_ptr->name); |
1574 | tipc_msg_dbg(TIPC_OUTPUT, msg, ">RETR-FAIL>"); | ||
1575 | 1533 | ||
1576 | if (l_ptr->addr) { | 1534 | if (l_ptr->addr) { |
1577 | 1535 | ||
@@ -1621,11 +1579,8 @@ void tipc_link_retransmit(struct link *l_ptr, struct sk_buff *buf, | |||
1621 | 1579 | ||
1622 | msg = buf_msg(buf); | 1580 | msg = buf_msg(buf); |
1623 | 1581 | ||
1624 | dbg("Retransmitting %u in link %x\n", retransmits, l_ptr); | ||
1625 | |||
1626 | if (tipc_bearer_congested(l_ptr->b_ptr, l_ptr)) { | 1582 | if (tipc_bearer_congested(l_ptr->b_ptr, l_ptr)) { |
1627 | if (l_ptr->retransm_queue_size == 0) { | 1583 | if (l_ptr->retransm_queue_size == 0) { |
1628 | msg_dbg(msg, ">NO_RETR->BCONG>"); | ||
1629 | dbg_print_link(l_ptr, " "); | 1584 | dbg_print_link(l_ptr, " "); |
1630 | l_ptr->retransm_queue_head = msg_seqno(msg); | 1585 | l_ptr->retransm_queue_head = msg_seqno(msg); |
1631 | l_ptr->retransm_queue_size = retransmits; | 1586 | l_ptr->retransm_queue_size = retransmits; |
@@ -1653,7 +1608,6 @@ void tipc_link_retransmit(struct link *l_ptr, struct sk_buff *buf, | |||
1653 | msg_set_ack(msg, mod(l_ptr->next_in_no - 1)); | 1608 | msg_set_ack(msg, mod(l_ptr->next_in_no - 1)); |
1654 | msg_set_bcast_ack(msg, l_ptr->owner->bclink.last_in); | 1609 | msg_set_bcast_ack(msg, l_ptr->owner->bclink.last_in); |
1655 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { | 1610 | if (tipc_bearer_send(l_ptr->b_ptr, buf, &l_ptr->media_addr)) { |
1656 | msg_dbg(buf_msg(buf), ">RETR>"); | ||
1657 | buf = buf->next; | 1611 | buf = buf->next; |
1658 | retransmits--; | 1612 | retransmits--; |
1659 | l_ptr->stats.retransmitted++; | 1613 | l_ptr->stats.retransmitted++; |
@@ -1939,12 +1893,10 @@ deliver: | |||
1939 | tipc_node_unlock(n_ptr); | 1893 | tipc_node_unlock(n_ptr); |
1940 | continue; | 1894 | continue; |
1941 | } | 1895 | } |
1942 | msg_dbg(msg,"NSEQ<REC<"); | ||
1943 | link_state_event(l_ptr, TRAFFIC_MSG_EVT); | 1896 | link_state_event(l_ptr, TRAFFIC_MSG_EVT); |
1944 | 1897 | ||
1945 | if (link_working_working(l_ptr)) { | 1898 | if (link_working_working(l_ptr)) { |
1946 | /* Re-insert in front of queue */ | 1899 | /* Re-insert in front of queue */ |
1947 | msg_dbg(msg,"RECV-REINS:"); | ||
1948 | buf->next = head; | 1900 | buf->next = head; |
1949 | head = buf; | 1901 | head = buf; |
1950 | tipc_node_unlock(n_ptr); | 1902 | tipc_node_unlock(n_ptr); |
@@ -2026,9 +1978,6 @@ static void link_handle_out_of_seq_msg(struct link *l_ptr, | |||
2026 | return; | 1978 | return; |
2027 | } | 1979 | } |
2028 | 1980 | ||
2029 | dbg("rx OOS msg: seq_no %u, expecting %u (%u)\n", | ||
2030 | seq_no, mod(l_ptr->next_in_no), l_ptr->next_in_no); | ||
2031 | |||
2032 | /* Record OOS packet arrival (force mismatch on next timeout) */ | 1981 | /* Record OOS packet arrival (force mismatch on next timeout) */ |
2033 | 1982 | ||
2034 | l_ptr->checkpoint--; | 1983 | l_ptr->checkpoint--; |
@@ -2146,8 +2095,6 @@ void tipc_link_send_proto_msg(struct link *l_ptr, u32 msg_typ, int probe_msg, | |||
2146 | 2095 | ||
2147 | /* Message can be sent */ | 2096 | /* Message can be sent */ |
2148 | 2097 | ||
2149 | msg_dbg(msg, ">>"); | ||
2150 | |||
2151 | buf = tipc_buf_acquire(msg_size); | 2098 | buf = tipc_buf_acquire(msg_size); |
2152 | if (!buf) | 2099 | if (!buf) |
2153 | return; | 2100 | return; |
@@ -2181,8 +2128,6 @@ static void link_recv_proto_msg(struct link *l_ptr, struct sk_buff *buf) | |||
2181 | u32 msg_tol; | 2128 | u32 msg_tol; |
2182 | struct tipc_msg *msg = buf_msg(buf); | 2129 | struct tipc_msg *msg = buf_msg(buf); |
2183 | 2130 | ||
2184 | dbg("AT(%u):", jiffies_to_msecs(jiffies)); | ||
2185 | msg_dbg(msg, "<<"); | ||
2186 | if (link_blocked(l_ptr)) | 2131 | if (link_blocked(l_ptr)) |
2187 | goto exit; | 2132 | goto exit; |
2188 | 2133 | ||
@@ -2201,11 +2146,8 @@ static void link_recv_proto_msg(struct link *l_ptr, struct sk_buff *buf) | |||
2201 | case RESET_MSG: | 2146 | case RESET_MSG: |
2202 | if (!link_working_unknown(l_ptr) && | 2147 | if (!link_working_unknown(l_ptr) && |
2203 | (l_ptr->peer_session != INVALID_SESSION)) { | 2148 | (l_ptr->peer_session != INVALID_SESSION)) { |
2204 | if (msg_session(msg) == l_ptr->peer_session) { | 2149 | if (msg_session(msg) == l_ptr->peer_session) |
2205 | dbg("Duplicate RESET: %u<->%u\n", | ||
2206 | msg_session(msg), l_ptr->peer_session); | ||
2207 | break; /* duplicate: ignore */ | 2150 | break; /* duplicate: ignore */ |
2208 | } | ||
2209 | } | 2151 | } |
2210 | /* fall thru' */ | 2152 | /* fall thru' */ |
2211 | case ACTIVATE_MSG: | 2153 | case ACTIVATE_MSG: |
@@ -2266,8 +2208,6 @@ static void link_recv_proto_msg(struct link *l_ptr, struct sk_buff *buf) | |||
2266 | 2208 | ||
2267 | max_pkt_ack = msg_max_pkt(msg); | 2209 | max_pkt_ack = msg_max_pkt(msg); |
2268 | if (max_pkt_ack > l_ptr->max_pkt) { | 2210 | if (max_pkt_ack > l_ptr->max_pkt) { |
2269 | dbg("Link <%s> updated MTU %u -> %u\n", | ||
2270 | l_ptr->name, l_ptr->max_pkt, max_pkt_ack); | ||
2271 | l_ptr->max_pkt = max_pkt_ack; | 2211 | l_ptr->max_pkt = max_pkt_ack; |
2272 | l_ptr->max_pkt_probes = 0; | 2212 | l_ptr->max_pkt_probes = 0; |
2273 | } | 2213 | } |
@@ -2289,14 +2229,11 @@ static void link_recv_proto_msg(struct link *l_ptr, struct sk_buff *buf) | |||
2289 | 0, rec_gap, 0, 0, max_pkt_ack); | 2229 | 0, rec_gap, 0, 0, max_pkt_ack); |
2290 | } | 2230 | } |
2291 | if (msg_seq_gap(msg)) { | 2231 | if (msg_seq_gap(msg)) { |
2292 | msg_dbg(msg, "With Gap:"); | ||
2293 | l_ptr->stats.recv_nacks++; | 2232 | l_ptr->stats.recv_nacks++; |
2294 | tipc_link_retransmit(l_ptr, l_ptr->first_out, | 2233 | tipc_link_retransmit(l_ptr, l_ptr->first_out, |
2295 | msg_seq_gap(msg)); | 2234 | msg_seq_gap(msg)); |
2296 | } | 2235 | } |
2297 | break; | 2236 | break; |
2298 | default: | ||
2299 | msg_dbg(buf_msg(buf), "<DISCARDING UNKNOWN<"); | ||
2300 | } | 2237 | } |
2301 | exit: | 2238 | exit: |
2302 | buf_discard(buf); | 2239 | buf_discard(buf); |
@@ -2331,8 +2268,6 @@ static void tipc_link_tunnel(struct link *l_ptr, | |||
2331 | } | 2268 | } |
2332 | skb_copy_to_linear_data(buf, tunnel_hdr, INT_H_SIZE); | 2269 | skb_copy_to_linear_data(buf, tunnel_hdr, INT_H_SIZE); |
2333 | skb_copy_to_linear_data_offset(buf, INT_H_SIZE, msg, length); | 2270 | skb_copy_to_linear_data_offset(buf, INT_H_SIZE, msg, length); |
2334 | dbg("%c->%c:", l_ptr->b_ptr->net_plane, tunnel->b_ptr->net_plane); | ||
2335 | msg_dbg(buf_msg(buf), ">SEND>"); | ||
2336 | tipc_link_send_buf(tunnel, buf); | 2271 | tipc_link_send_buf(tunnel, buf); |
2337 | } | 2272 | } |
2338 | 2273 | ||
@@ -2364,7 +2299,6 @@ void tipc_link_changeover(struct link *l_ptr) | |||
2364 | ORIGINAL_MSG, INT_H_SIZE, l_ptr->addr); | 2299 | ORIGINAL_MSG, INT_H_SIZE, l_ptr->addr); |
2365 | msg_set_bearer_id(&tunnel_hdr, l_ptr->peer_bearer_id); | 2300 | msg_set_bearer_id(&tunnel_hdr, l_ptr->peer_bearer_id); |
2366 | msg_set_msgcnt(&tunnel_hdr, msgcount); | 2301 | msg_set_msgcnt(&tunnel_hdr, msgcount); |
2367 | dbg("Link changeover requires %u tunnel messages\n", msgcount); | ||
2368 | 2302 | ||
2369 | if (!l_ptr->first_out) { | 2303 | if (!l_ptr->first_out) { |
2370 | struct sk_buff *buf; | 2304 | struct sk_buff *buf; |
@@ -2373,9 +2307,6 @@ void tipc_link_changeover(struct link *l_ptr) | |||
2373 | if (buf) { | 2307 | if (buf) { |
2374 | skb_copy_to_linear_data(buf, &tunnel_hdr, INT_H_SIZE); | 2308 | skb_copy_to_linear_data(buf, &tunnel_hdr, INT_H_SIZE); |
2375 | msg_set_size(&tunnel_hdr, INT_H_SIZE); | 2309 | msg_set_size(&tunnel_hdr, INT_H_SIZE); |
2376 | dbg("%c->%c:", l_ptr->b_ptr->net_plane, | ||
2377 | tunnel->b_ptr->net_plane); | ||
2378 | msg_dbg(&tunnel_hdr, "EMPTY>SEND>"); | ||
2379 | tipc_link_send_buf(tunnel, buf); | 2310 | tipc_link_send_buf(tunnel, buf); |
2380 | } else { | 2311 | } else { |
2381 | warn("Link changeover error, " | 2312 | warn("Link changeover error, " |
@@ -2439,9 +2370,6 @@ void tipc_link_send_duplicate(struct link *l_ptr, struct link *tunnel) | |||
2439 | skb_copy_to_linear_data(outbuf, &tunnel_hdr, INT_H_SIZE); | 2370 | skb_copy_to_linear_data(outbuf, &tunnel_hdr, INT_H_SIZE); |
2440 | skb_copy_to_linear_data_offset(outbuf, INT_H_SIZE, iter->data, | 2371 | skb_copy_to_linear_data_offset(outbuf, INT_H_SIZE, iter->data, |
2441 | length); | 2372 | length); |
2442 | dbg("%c->%c:", l_ptr->b_ptr->net_plane, | ||
2443 | tunnel->b_ptr->net_plane); | ||
2444 | msg_dbg(buf_msg(outbuf), ">SEND>"); | ||
2445 | tipc_link_send_buf(tunnel, outbuf); | 2373 | tipc_link_send_buf(tunnel, outbuf); |
2446 | if (!tipc_link_is_up(l_ptr)) | 2374 | if (!tipc_link_is_up(l_ptr)) |
2447 | return; | 2375 | return; |
@@ -2488,31 +2416,24 @@ static int link_recv_changeover_msg(struct link **l_ptr, | |||
2488 | u32 msg_count = msg_msgcnt(tunnel_msg); | 2416 | u32 msg_count = msg_msgcnt(tunnel_msg); |
2489 | 2417 | ||
2490 | dest_link = (*l_ptr)->owner->links[msg_bearer_id(tunnel_msg)]; | 2418 | dest_link = (*l_ptr)->owner->links[msg_bearer_id(tunnel_msg)]; |
2491 | if (!dest_link) { | 2419 | if (!dest_link) |
2492 | msg_dbg(tunnel_msg, "NOLINK/<REC<"); | ||
2493 | goto exit; | 2420 | goto exit; |
2494 | } | ||
2495 | if (dest_link == *l_ptr) { | 2421 | if (dest_link == *l_ptr) { |
2496 | err("Unexpected changeover message on link <%s>\n", | 2422 | err("Unexpected changeover message on link <%s>\n", |
2497 | (*l_ptr)->name); | 2423 | (*l_ptr)->name); |
2498 | goto exit; | 2424 | goto exit; |
2499 | } | 2425 | } |
2500 | dbg("%c<-%c:", dest_link->b_ptr->net_plane, | ||
2501 | (*l_ptr)->b_ptr->net_plane); | ||
2502 | *l_ptr = dest_link; | 2426 | *l_ptr = dest_link; |
2503 | msg = msg_get_wrapped(tunnel_msg); | 2427 | msg = msg_get_wrapped(tunnel_msg); |
2504 | 2428 | ||
2505 | if (msg_typ == DUPLICATE_MSG) { | 2429 | if (msg_typ == DUPLICATE_MSG) { |
2506 | if (less(msg_seqno(msg), mod(dest_link->next_in_no))) { | 2430 | if (less(msg_seqno(msg), mod(dest_link->next_in_no))) |
2507 | msg_dbg(tunnel_msg, "DROP/<REC<"); | ||
2508 | goto exit; | 2431 | goto exit; |
2509 | } | ||
2510 | *buf = buf_extract(tunnel_buf,INT_H_SIZE); | 2432 | *buf = buf_extract(tunnel_buf,INT_H_SIZE); |
2511 | if (*buf == NULL) { | 2433 | if (*buf == NULL) { |
2512 | warn("Link changeover error, duplicate msg dropped\n"); | 2434 | warn("Link changeover error, duplicate msg dropped\n"); |
2513 | goto exit; | 2435 | goto exit; |
2514 | } | 2436 | } |
2515 | msg_dbg(tunnel_msg, "TNL<REC<"); | ||
2516 | buf_discard(tunnel_buf); | 2437 | buf_discard(tunnel_buf); |
2517 | return 1; | 2438 | return 1; |
2518 | } | 2439 | } |
@@ -2520,18 +2441,14 @@ static int link_recv_changeover_msg(struct link **l_ptr, | |||
2520 | /* First original message ?: */ | 2441 | /* First original message ?: */ |
2521 | 2442 | ||
2522 | if (tipc_link_is_up(dest_link)) { | 2443 | if (tipc_link_is_up(dest_link)) { |
2523 | msg_dbg(tunnel_msg, "UP/FIRST/<REC<"); | ||
2524 | info("Resetting link <%s>, changeover initiated by peer\n", | 2444 | info("Resetting link <%s>, changeover initiated by peer\n", |
2525 | dest_link->name); | 2445 | dest_link->name); |
2526 | tipc_link_reset(dest_link); | 2446 | tipc_link_reset(dest_link); |
2527 | dest_link->exp_msg_count = msg_count; | 2447 | dest_link->exp_msg_count = msg_count; |
2528 | dbg("Expecting %u tunnelled messages\n", msg_count); | ||
2529 | if (!msg_count) | 2448 | if (!msg_count) |
2530 | goto exit; | 2449 | goto exit; |
2531 | } else if (dest_link->exp_msg_count == START_CHANGEOVER) { | 2450 | } else if (dest_link->exp_msg_count == START_CHANGEOVER) { |
2532 | msg_dbg(tunnel_msg, "BLK/FIRST/<REC<"); | ||
2533 | dest_link->exp_msg_count = msg_count; | 2451 | dest_link->exp_msg_count = msg_count; |
2534 | dbg("Expecting %u tunnelled messages\n", msg_count); | ||
2535 | if (!msg_count) | 2452 | if (!msg_count) |
2536 | goto exit; | 2453 | goto exit; |
2537 | } | 2454 | } |
@@ -2541,18 +2458,15 @@ static int link_recv_changeover_msg(struct link **l_ptr, | |||
2541 | if (dest_link->exp_msg_count == 0) { | 2458 | if (dest_link->exp_msg_count == 0) { |
2542 | warn("Link switchover error, " | 2459 | warn("Link switchover error, " |
2543 | "got too many tunnelled messages\n"); | 2460 | "got too many tunnelled messages\n"); |
2544 | msg_dbg(tunnel_msg, "OVERDUE/DROP/<REC<"); | ||
2545 | dbg_print_link(dest_link, "LINK:"); | 2461 | dbg_print_link(dest_link, "LINK:"); |
2546 | goto exit; | 2462 | goto exit; |
2547 | } | 2463 | } |
2548 | dest_link->exp_msg_count--; | 2464 | dest_link->exp_msg_count--; |
2549 | if (less(msg_seqno(msg), dest_link->reset_checkpoint)) { | 2465 | if (less(msg_seqno(msg), dest_link->reset_checkpoint)) { |
2550 | msg_dbg(tunnel_msg, "DROP/DUPL/<REC<"); | ||
2551 | goto exit; | 2466 | goto exit; |
2552 | } else { | 2467 | } else { |
2553 | *buf = buf_extract(tunnel_buf, INT_H_SIZE); | 2468 | *buf = buf_extract(tunnel_buf, INT_H_SIZE); |
2554 | if (*buf != NULL) { | 2469 | if (*buf != NULL) { |
2555 | msg_dbg(tunnel_msg, "TNL<REC<"); | ||
2556 | buf_discard(tunnel_buf); | 2470 | buf_discard(tunnel_buf); |
2557 | return 1; | 2471 | return 1; |
2558 | } else { | 2472 | } else { |
@@ -2574,7 +2488,6 @@ void tipc_link_recv_bundle(struct sk_buff *buf) | |||
2574 | u32 pos = INT_H_SIZE; | 2488 | u32 pos = INT_H_SIZE; |
2575 | struct sk_buff *obuf; | 2489 | struct sk_buff *obuf; |
2576 | 2490 | ||
2577 | msg_dbg(buf_msg(buf), "<BNDL<: "); | ||
2578 | while (msgcount--) { | 2491 | while (msgcount--) { |
2579 | obuf = buf_extract(buf, pos); | 2492 | obuf = buf_extract(buf, pos); |
2580 | if (obuf == NULL) { | 2493 | if (obuf == NULL) { |
@@ -2582,7 +2495,6 @@ void tipc_link_recv_bundle(struct sk_buff *buf) | |||
2582 | break; | 2495 | break; |
2583 | } | 2496 | } |
2584 | pos += align(msg_size(buf_msg(obuf))); | 2497 | pos += align(msg_size(buf_msg(obuf))); |
2585 | msg_dbg(buf_msg(obuf), " /"); | ||
2586 | tipc_net_route_msg(obuf); | 2498 | tipc_net_route_msg(obuf); |
2587 | } | 2499 | } |
2588 | buf_discard(buf); | 2500 | buf_discard(buf); |
@@ -2719,7 +2631,6 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb, | |||
2719 | u32 long_msg_seq_no = msg_long_msgno(fragm); | 2631 | u32 long_msg_seq_no = msg_long_msgno(fragm); |
2720 | 2632 | ||
2721 | *fb = NULL; | 2633 | *fb = NULL; |
2722 | msg_dbg(fragm,"FRG<REC<"); | ||
2723 | 2634 | ||
2724 | /* Is there an incomplete message waiting for this fragment? */ | 2635 | /* Is there an incomplete message waiting for this fragment? */ |
2725 | 2636 | ||
@@ -2738,7 +2649,6 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb, | |||
2738 | if (msg_type(imsg) == TIPC_MCAST_MSG) | 2649 | if (msg_type(imsg) == TIPC_MCAST_MSG) |
2739 | max = TIPC_MAX_USER_MSG_SIZE + MCAST_H_SIZE; | 2650 | max = TIPC_MAX_USER_MSG_SIZE + MCAST_H_SIZE; |
2740 | if (msg_size(imsg) > max) { | 2651 | if (msg_size(imsg) > max) { |
2741 | msg_dbg(fragm,"<REC<Oversized: "); | ||
2742 | buf_discard(fbuf); | 2652 | buf_discard(fbuf); |
2743 | return 0; | 2653 | return 0; |
2744 | } | 2654 | } |
@@ -2782,10 +2692,6 @@ int tipc_link_recv_fragment(struct sk_buff **pending, struct sk_buff **fb, | |||
2782 | set_expected_frags(pbuf,exp_frags); | 2692 | set_expected_frags(pbuf,exp_frags); |
2783 | return 0; | 2693 | return 0; |
2784 | } | 2694 | } |
2785 | dbg(" Discarding orphan fragment %x\n",fbuf); | ||
2786 | msg_dbg(fragm,"ORPHAN:"); | ||
2787 | dbg("Pending long buffers:\n"); | ||
2788 | dbg_print_buf_chain(*pending); | ||
2789 | buf_discard(fbuf); | 2695 | buf_discard(fbuf); |
2790 | return 0; | 2696 | return 0; |
2791 | } | 2697 | } |
@@ -2813,11 +2719,6 @@ static void link_check_defragm_bufs(struct link *l_ptr) | |||
2813 | incr_timer_cnt(buf); | 2719 | incr_timer_cnt(buf); |
2814 | prev = buf; | 2720 | prev = buf; |
2815 | } else { | 2721 | } else { |
2816 | dbg(" Discarding incomplete long buffer\n"); | ||
2817 | msg_dbg(buf_msg(buf), "LONG:"); | ||
2818 | dbg_print_link(l_ptr, "curr:"); | ||
2819 | dbg("Pending long buffers:\n"); | ||
2820 | dbg_print_buf_chain(l_ptr->defragm_buf); | ||
2821 | if (prev) | 2722 | if (prev) |
2822 | prev->next = buf->next; | 2723 | prev->next = buf->next; |
2823 | else | 2724 | else |
@@ -3165,19 +3066,6 @@ u32 tipc_link_get_max_pkt(u32 dest, u32 selector) | |||
3165 | return res; | 3066 | return res; |
3166 | } | 3067 | } |
3167 | 3068 | ||
3168 | static void link_dump_send_queue(struct link *l_ptr) | ||
3169 | { | ||
3170 | if (l_ptr->next_out) { | ||
3171 | info("\nContents of unsent queue:\n"); | ||
3172 | dbg_print_buf_chain(l_ptr->next_out); | ||
3173 | } | ||
3174 | info("\nContents of send queue:\n"); | ||
3175 | if (l_ptr->first_out) { | ||
3176 | dbg_print_buf_chain(l_ptr->first_out); | ||
3177 | } | ||
3178 | info("Empty send queue\n"); | ||
3179 | } | ||
3180 | |||
3181 | static void link_print(struct link *l_ptr, struct print_buf *buf, | 3069 | static void link_print(struct link *l_ptr, struct print_buf *buf, |
3182 | const char *str) | 3070 | const char *str) |
3183 | { | 3071 | { |
@@ -3203,7 +3091,6 @@ static void link_print(struct link *l_ptr, struct print_buf *buf, | |||
3203 | tipc_printf(buf, "first_out= %x ", l_ptr->first_out); | 3091 | tipc_printf(buf, "first_out= %x ", l_ptr->first_out); |
3204 | tipc_printf(buf, "next_out= %x ", l_ptr->next_out); | 3092 | tipc_printf(buf, "next_out= %x ", l_ptr->next_out); |
3205 | tipc_printf(buf, "last_out= %x ", l_ptr->last_out); | 3093 | tipc_printf(buf, "last_out= %x ", l_ptr->last_out); |
3206 | link_dump_send_queue(l_ptr); | ||
3207 | } | 3094 | } |
3208 | } else | 3095 | } else |
3209 | tipc_printf(buf, "[]"); | 3096 | tipc_printf(buf, "[]"); |
diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c index c4583fe888d8..0dd648ec0809 100644 --- a/net/tipc/name_distr.c +++ b/net/tipc/name_distr.c | |||
@@ -87,7 +87,6 @@ static void publ_to_item(struct distr_item *i, struct publication *p) | |||
87 | i->upper = htonl(p->upper); | 87 | i->upper = htonl(p->upper); |
88 | i->ref = htonl(p->ref); | 88 | i->ref = htonl(p->ref); |
89 | i->key = htonl(p->key); | 89 | i->key = htonl(p->key); |
90 | dbg("publ_to_item: %u, %u, %u\n", p->type, p->lower, p->upper); | ||
91 | } | 90 | } |
92 | 91 | ||
93 | /** | 92 | /** |
@@ -147,7 +146,6 @@ void tipc_named_publish(struct publication *publ) | |||
147 | 146 | ||
148 | item = (struct distr_item *)msg_data(buf_msg(buf)); | 147 | item = (struct distr_item *)msg_data(buf_msg(buf)); |
149 | publ_to_item(item, publ); | 148 | publ_to_item(item, publ); |
150 | dbg("tipc_named_publish: broadcasting publish msg\n"); | ||
151 | named_cluster_distribute(buf); | 149 | named_cluster_distribute(buf); |
152 | } | 150 | } |
153 | 151 | ||
@@ -171,7 +169,6 @@ void tipc_named_withdraw(struct publication *publ) | |||
171 | 169 | ||
172 | item = (struct distr_item *)msg_data(buf_msg(buf)); | 170 | item = (struct distr_item *)msg_data(buf_msg(buf)); |
173 | publ_to_item(item, publ); | 171 | publ_to_item(item, publ); |
174 | dbg("tipc_named_withdraw: broadcasting withdraw msg\n"); | ||
175 | named_cluster_distribute(buf); | 172 | named_cluster_distribute(buf); |
176 | } | 173 | } |
177 | 174 | ||
@@ -209,9 +206,6 @@ void tipc_named_node_up(unsigned long node) | |||
209 | left -= ITEM_SIZE; | 206 | left -= ITEM_SIZE; |
210 | if (!left) { | 207 | if (!left) { |
211 | msg_set_link_selector(buf_msg(buf), node); | 208 | msg_set_link_selector(buf_msg(buf), node); |
212 | dbg("tipc_named_node_up: sending publish msg to " | ||
213 | "<%u.%u.%u>\n", tipc_zone(node), | ||
214 | tipc_cluster(node), tipc_node(node)); | ||
215 | tipc_link_send(buf, node, node); | 209 | tipc_link_send(buf, node, node); |
216 | buf = NULL; | 210 | buf = NULL; |
217 | } | 211 | } |
@@ -236,8 +230,6 @@ static void node_is_down(struct publication *publ) | |||
236 | struct publication *p; | 230 | struct publication *p; |
237 | 231 | ||
238 | write_lock_bh(&tipc_nametbl_lock); | 232 | write_lock_bh(&tipc_nametbl_lock); |
239 | dbg("node_is_down: withdrawing %u, %u, %u\n", | ||
240 | publ->type, publ->lower, publ->upper); | ||
241 | publ->key += 1222345; | 233 | publ->key += 1222345; |
242 | p = tipc_nametbl_remove_publ(publ->type, publ->lower, | 234 | p = tipc_nametbl_remove_publ(publ->type, publ->lower, |
243 | publ->node, publ->ref, publ->key); | 235 | publ->node, publ->ref, publ->key); |
@@ -268,9 +260,6 @@ void tipc_named_recv(struct sk_buff *buf) | |||
268 | write_lock_bh(&tipc_nametbl_lock); | 260 | write_lock_bh(&tipc_nametbl_lock); |
269 | while (count--) { | 261 | while (count--) { |
270 | if (msg_type(msg) == PUBLICATION) { | 262 | if (msg_type(msg) == PUBLICATION) { |
271 | dbg("tipc_named_recv: got publication for %u, %u, %u\n", | ||
272 | ntohl(item->type), ntohl(item->lower), | ||
273 | ntohl(item->upper)); | ||
274 | publ = tipc_nametbl_insert_publ(ntohl(item->type), | 263 | publ = tipc_nametbl_insert_publ(ntohl(item->type), |
275 | ntohl(item->lower), | 264 | ntohl(item->lower), |
276 | ntohl(item->upper), | 265 | ntohl(item->upper), |
@@ -285,9 +274,6 @@ void tipc_named_recv(struct sk_buff *buf) | |||
285 | (net_ev_handler)node_is_down); | 274 | (net_ev_handler)node_is_down); |
286 | } | 275 | } |
287 | } else if (msg_type(msg) == WITHDRAWAL) { | 276 | } else if (msg_type(msg) == WITHDRAWAL) { |
288 | dbg("tipc_named_recv: got withdrawl for %u, %u, %u\n", | ||
289 | ntohl(item->type), ntohl(item->lower), | ||
290 | ntohl(item->upper)); | ||
291 | publ = tipc_nametbl_remove_publ(ntohl(item->type), | 277 | publ = tipc_nametbl_remove_publ(ntohl(item->type), |
292 | ntohl(item->lower), | 278 | ntohl(item->lower), |
293 | msg_orignode(msg), | 279 | msg_orignode(msg), |
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c index d5adb0456746..ddc2ad4c2d32 100644 --- a/net/tipc/name_table.c +++ b/net/tipc/name_table.c | |||
@@ -172,8 +172,6 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea | |||
172 | spin_lock_init(&nseq->lock); | 172 | spin_lock_init(&nseq->lock); |
173 | nseq->type = type; | 173 | nseq->type = type; |
174 | nseq->sseqs = sseq; | 174 | nseq->sseqs = sseq; |
175 | dbg("tipc_nameseq_create(): nseq = %p, type %u, ssseqs %p, ff: %u\n", | ||
176 | nseq, type, nseq->sseqs, nseq->first_free); | ||
177 | nseq->alloc = 1; | 175 | nseq->alloc = 1; |
178 | INIT_HLIST_NODE(&nseq->ns_list); | 176 | INIT_HLIST_NODE(&nseq->ns_list); |
179 | INIT_LIST_HEAD(&nseq->subscriptions); | 177 | INIT_LIST_HEAD(&nseq->subscriptions); |
@@ -251,8 +249,6 @@ static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, | |||
251 | int created_subseq = 0; | 249 | int created_subseq = 0; |
252 | 250 | ||
253 | sseq = nameseq_find_subseq(nseq, lower); | 251 | sseq = nameseq_find_subseq(nseq, lower); |
254 | dbg("nameseq_ins: for seq %p, {%u,%u}, found sseq %p\n", | ||
255 | nseq, type, lower, sseq); | ||
256 | if (sseq) { | 252 | if (sseq) { |
257 | 253 | ||
258 | /* Lower end overlaps existing entry => need an exact match */ | 254 | /* Lower end overlaps existing entry => need an exact match */ |
@@ -289,18 +285,15 @@ static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, | |||
289 | type, lower, upper); | 285 | type, lower, upper); |
290 | return NULL; | 286 | return NULL; |
291 | } | 287 | } |
292 | dbg("Allocated %u more sseqs\n", nseq->alloc); | ||
293 | memcpy(sseqs, nseq->sseqs, | 288 | memcpy(sseqs, nseq->sseqs, |
294 | nseq->alloc * sizeof(struct sub_seq)); | 289 | nseq->alloc * sizeof(struct sub_seq)); |
295 | kfree(nseq->sseqs); | 290 | kfree(nseq->sseqs); |
296 | nseq->sseqs = sseqs; | 291 | nseq->sseqs = sseqs; |
297 | nseq->alloc *= 2; | 292 | nseq->alloc *= 2; |
298 | } | 293 | } |
299 | dbg("Have %u sseqs for type %u\n", nseq->alloc, type); | ||
300 | 294 | ||
301 | /* Insert new sub-sequence */ | 295 | /* Insert new sub-sequence */ |
302 | 296 | ||
303 | dbg("ins in pos %u, ff = %u\n", inspos, nseq->first_free); | ||
304 | sseq = &nseq->sseqs[inspos]; | 297 | sseq = &nseq->sseqs[inspos]; |
305 | freesseq = &nseq->sseqs[nseq->first_free]; | 298 | freesseq = &nseq->sseqs[nseq->first_free]; |
306 | memmove(sseq + 1, sseq, (freesseq - sseq) * sizeof (*sseq)); | 299 | memmove(sseq + 1, sseq, (freesseq - sseq) * sizeof (*sseq)); |
@@ -310,17 +303,12 @@ static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, | |||
310 | sseq->upper = upper; | 303 | sseq->upper = upper; |
311 | created_subseq = 1; | 304 | created_subseq = 1; |
312 | } | 305 | } |
313 | dbg("inserting {%u,%u,%u} from <0x%x:%u> into sseq %p(%u,%u) of seq %p\n", | ||
314 | type, lower, upper, node, port, sseq, | ||
315 | sseq->lower, sseq->upper, nseq); | ||
316 | 306 | ||
317 | /* Insert a publication: */ | 307 | /* Insert a publication: */ |
318 | 308 | ||
319 | publ = publ_create(type, lower, upper, scope, node, port, key); | 309 | publ = publ_create(type, lower, upper, scope, node, port, key); |
320 | if (!publ) | 310 | if (!publ) |
321 | return NULL; | 311 | return NULL; |
322 | dbg("inserting publ %p, node=0x%x publ->node=0x%x, subscr->node=%p\n", | ||
323 | publ, node, publ->node, publ->subscr.node); | ||
324 | 312 | ||
325 | sseq->zone_list_size++; | 313 | sseq->zone_list_size++; |
326 | if (!sseq->zone_list) | 314 | if (!sseq->zone_list) |
@@ -355,7 +343,6 @@ static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq, | |||
355 | * Any subscriptions waiting for notification? | 343 | * Any subscriptions waiting for notification? |
356 | */ | 344 | */ |
357 | list_for_each_entry_safe(s, st, &nseq->subscriptions, nameseq_list) { | 345 | list_for_each_entry_safe(s, st, &nseq->subscriptions, nameseq_list) { |
358 | dbg("calling report_overlap()\n"); | ||
359 | tipc_subscr_report_overlap(s, | 346 | tipc_subscr_report_overlap(s, |
360 | publ->lower, | 347 | publ->lower, |
361 | publ->upper, | 348 | publ->upper, |
@@ -393,9 +380,6 @@ static struct publication *tipc_nameseq_remove_publ(struct name_seq *nseq, u32 i | |||
393 | if (!sseq) | 380 | if (!sseq) |
394 | return NULL; | 381 | return NULL; |
395 | 382 | ||
396 | dbg("tipc_nameseq_remove_publ: seq: %p, sseq %p, {%u,%u}, key %u\n", | ||
397 | nseq, sseq, nseq->type, inst, key); | ||
398 | |||
399 | /* Remove publication from zone scope list */ | 383 | /* Remove publication from zone scope list */ |
400 | 384 | ||
401 | prev = sseq->zone_list; | 385 | prev = sseq->zone_list; |
@@ -549,15 +533,10 @@ static struct name_seq *nametbl_find_seq(u32 type) | |||
549 | struct hlist_node *seq_node; | 533 | struct hlist_node *seq_node; |
550 | struct name_seq *ns; | 534 | struct name_seq *ns; |
551 | 535 | ||
552 | dbg("find_seq %u,(%u,0x%x) table = %p, hash[type] = %u\n", | ||
553 | type, htonl(type), type, table.types, hash(type)); | ||
554 | |||
555 | seq_head = &table.types[hash(type)]; | 536 | seq_head = &table.types[hash(type)]; |
556 | hlist_for_each_entry(ns, seq_node, seq_head, ns_list) { | 537 | hlist_for_each_entry(ns, seq_node, seq_head, ns_list) { |
557 | if (ns->type == type) { | 538 | if (ns->type == type) |
558 | dbg("found %p\n", ns); | ||
559 | return ns; | 539 | return ns; |
560 | } | ||
561 | } | 540 | } |
562 | 541 | ||
563 | return NULL; | 542 | return NULL; |
@@ -568,18 +547,14 @@ struct publication *tipc_nametbl_insert_publ(u32 type, u32 lower, u32 upper, | |||
568 | { | 547 | { |
569 | struct name_seq *seq = nametbl_find_seq(type); | 548 | struct name_seq *seq = nametbl_find_seq(type); |
570 | 549 | ||
571 | dbg("tipc_nametbl_insert_publ: {%u,%u,%u} found %p\n", type, lower, upper, seq); | ||
572 | if (lower > upper) { | 550 | if (lower > upper) { |
573 | warn("Failed to publish illegal {%u,%u,%u}\n", | 551 | warn("Failed to publish illegal {%u,%u,%u}\n", |
574 | type, lower, upper); | 552 | type, lower, upper); |
575 | return NULL; | 553 | return NULL; |
576 | } | 554 | } |
577 | 555 | ||
578 | dbg("Publishing {%u,%u,%u} from 0x%x\n", type, lower, upper, node); | 556 | if (!seq) |
579 | if (!seq) { | ||
580 | seq = tipc_nameseq_create(type, &table.types[hash(type)]); | 557 | seq = tipc_nameseq_create(type, &table.types[hash(type)]); |
581 | dbg("tipc_nametbl_insert_publ: created %p\n", seq); | ||
582 | } | ||
583 | if (!seq) | 558 | if (!seq) |
584 | return NULL; | 559 | return NULL; |
585 | 560 | ||
@@ -596,7 +571,6 @@ struct publication *tipc_nametbl_remove_publ(u32 type, u32 lower, | |||
596 | if (!seq) | 571 | if (!seq) |
597 | return NULL; | 572 | return NULL; |
598 | 573 | ||
599 | dbg("Withdrawing {%u,%u} from 0x%x\n", type, lower, node); | ||
600 | publ = tipc_nameseq_remove_publ(seq, lower, node, ref, key); | 574 | publ = tipc_nameseq_remove_publ(seq, lower, node, ref, key); |
601 | 575 | ||
602 | if (!seq->first_free && list_empty(&seq->subscriptions)) { | 576 | if (!seq->first_free && list_empty(&seq->subscriptions)) { |
@@ -792,7 +766,6 @@ int tipc_nametbl_withdraw(u32 type, u32 lower, u32 ref, u32 key) | |||
792 | { | 766 | { |
793 | struct publication *publ; | 767 | struct publication *publ; |
794 | 768 | ||
795 | dbg("tipc_nametbl_withdraw: {%u,%u}, key=%u\n", type, lower, key); | ||
796 | write_lock_bh(&tipc_nametbl_lock); | 769 | write_lock_bh(&tipc_nametbl_lock); |
797 | publ = tipc_nametbl_remove_publ(type, lower, tipc_own_addr, ref, key); | 770 | publ = tipc_nametbl_remove_publ(type, lower, tipc_own_addr, ref, key); |
798 | if (likely(publ)) { | 771 | if (likely(publ)) { |
@@ -827,8 +800,6 @@ void tipc_nametbl_subscribe(struct subscription *s) | |||
827 | } | 800 | } |
828 | if (seq){ | 801 | if (seq){ |
829 | spin_lock_bh(&seq->lock); | 802 | spin_lock_bh(&seq->lock); |
830 | dbg("tipc_nametbl_subscribe:found %p for {%u,%u,%u}\n", | ||
831 | seq, type, s->seq.lower, s->seq.upper); | ||
832 | tipc_nameseq_subscribe(seq, s); | 803 | tipc_nameseq_subscribe(seq, s); |
833 | spin_unlock_bh(&seq->lock); | 804 | spin_unlock_bh(&seq->lock); |
834 | } else { | 805 | } else { |
diff --git a/net/tipc/net.c b/net/tipc/net.c index 3baf55ee0985..6290becd35be 100644 --- a/net/tipc/net.c +++ b/net/tipc/net.c | |||
@@ -138,22 +138,18 @@ static void net_route_named_msg(struct sk_buff *buf) | |||
138 | u32 dport; | 138 | u32 dport; |
139 | 139 | ||
140 | if (!msg_named(msg)) { | 140 | if (!msg_named(msg)) { |
141 | msg_dbg(msg, "tipc_net->drop_nam:"); | ||
142 | buf_discard(buf); | 141 | buf_discard(buf); |
143 | return; | 142 | return; |
144 | } | 143 | } |
145 | 144 | ||
146 | dnode = addr_domain(msg_lookup_scope(msg)); | 145 | dnode = addr_domain(msg_lookup_scope(msg)); |
147 | dport = tipc_nametbl_translate(msg_nametype(msg), msg_nameinst(msg), &dnode); | 146 | dport = tipc_nametbl_translate(msg_nametype(msg), msg_nameinst(msg), &dnode); |
148 | dbg("tipc_net->lookup<%u,%u>-><%u,%x>\n", | ||
149 | msg_nametype(msg), msg_nameinst(msg), dport, dnode); | ||
150 | if (dport) { | 147 | if (dport) { |
151 | msg_set_destnode(msg, dnode); | 148 | msg_set_destnode(msg, dnode); |
152 | msg_set_destport(msg, dport); | 149 | msg_set_destport(msg, dport); |
153 | tipc_net_route_msg(buf); | 150 | tipc_net_route_msg(buf); |
154 | return; | 151 | return; |
155 | } | 152 | } |
156 | msg_dbg(msg, "tipc_net->rej:NO NAME: "); | ||
157 | tipc_reject_msg(buf, TIPC_ERR_NO_NAME); | 153 | tipc_reject_msg(buf, TIPC_ERR_NO_NAME); |
158 | } | 154 | } |
159 | 155 | ||
@@ -169,18 +165,14 @@ void tipc_net_route_msg(struct sk_buff *buf) | |||
169 | msg_incr_reroute_cnt(msg); | 165 | msg_incr_reroute_cnt(msg); |
170 | if (msg_reroute_cnt(msg) > 6) { | 166 | if (msg_reroute_cnt(msg) > 6) { |
171 | if (msg_errcode(msg)) { | 167 | if (msg_errcode(msg)) { |
172 | msg_dbg(msg, "NET>DISC>:"); | ||
173 | buf_discard(buf); | 168 | buf_discard(buf); |
174 | } else { | 169 | } else { |
175 | msg_dbg(msg, "NET>REJ>:"); | ||
176 | tipc_reject_msg(buf, msg_destport(msg) ? | 170 | tipc_reject_msg(buf, msg_destport(msg) ? |
177 | TIPC_ERR_NO_PORT : TIPC_ERR_NO_NAME); | 171 | TIPC_ERR_NO_PORT : TIPC_ERR_NO_NAME); |
178 | } | 172 | } |
179 | return; | 173 | return; |
180 | } | 174 | } |
181 | 175 | ||
182 | msg_dbg(msg, "tipc_net->rout: "); | ||
183 | |||
184 | /* Handle message for this node */ | 176 | /* Handle message for this node */ |
185 | dnode = msg_short(msg) ? tipc_own_addr : msg_destnode(msg); | 177 | dnode = msg_short(msg) ? tipc_own_addr : msg_destnode(msg); |
186 | if (tipc_in_scope(dnode, tipc_own_addr)) { | 178 | if (tipc_in_scope(dnode, tipc_own_addr)) { |
@@ -201,14 +193,12 @@ void tipc_net_route_msg(struct sk_buff *buf) | |||
201 | tipc_port_recv_proto_msg(buf); | 193 | tipc_port_recv_proto_msg(buf); |
202 | break; | 194 | break; |
203 | default: | 195 | default: |
204 | msg_dbg(msg,"DROP/NET/<REC<"); | ||
205 | buf_discard(buf); | 196 | buf_discard(buf); |
206 | } | 197 | } |
207 | return; | 198 | return; |
208 | } | 199 | } |
209 | 200 | ||
210 | /* Handle message for another node */ | 201 | /* Handle message for another node */ |
211 | msg_dbg(msg, "NET>SEND>: "); | ||
212 | skb_trim(buf, msg_size(msg)); | 202 | skb_trim(buf, msg_size(msg)); |
213 | tipc_link_send(buf, dnode, msg_link_selector(msg)); | 203 | tipc_link_send(buf, dnode, msg_link_selector(msg)); |
214 | } | 204 | } |
diff --git a/net/tipc/node.c b/net/tipc/node.c index 31dcca98201a..fb54719679a6 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c | |||
@@ -97,7 +97,6 @@ void tipc_node_delete(struct tipc_node *n_ptr) | |||
97 | if (!n_ptr) | 97 | if (!n_ptr) |
98 | return; | 98 | return; |
99 | 99 | ||
100 | dbg("node %x deleted\n", n_ptr->addr); | ||
101 | n_num = tipc_node(n_ptr->addr); | 100 | n_num = tipc_node(n_ptr->addr); |
102 | tipc_net.nodes[n_num] = NULL; | 101 | tipc_net.nodes[n_num] = NULL; |
103 | kfree(n_ptr); | 102 | kfree(n_ptr); |
@@ -124,7 +123,6 @@ void tipc_node_link_up(struct tipc_node *n_ptr, struct link *l_ptr) | |||
124 | l_ptr->name, l_ptr->b_ptr->net_plane); | 123 | l_ptr->name, l_ptr->b_ptr->net_plane); |
125 | 124 | ||
126 | if (!active[0]) { | 125 | if (!active[0]) { |
127 | dbg(" link %x into %x/%x\n", l_ptr, &active[0], &active[1]); | ||
128 | active[0] = active[1] = l_ptr; | 126 | active[0] = active[1] = l_ptr; |
129 | node_established_contact(n_ptr); | 127 | node_established_contact(n_ptr); |
130 | return; | 128 | return; |
@@ -302,7 +300,6 @@ void tipc_node_detach_link(struct tipc_node *n_ptr, struct link *l_ptr) | |||
302 | 300 | ||
303 | static void node_established_contact(struct tipc_node *n_ptr) | 301 | static void node_established_contact(struct tipc_node *n_ptr) |
304 | { | 302 | { |
305 | dbg("node_established_contact:-> %x\n", n_ptr->addr); | ||
306 | tipc_k_signal((Handler)tipc_named_node_up, n_ptr->addr); | 303 | tipc_k_signal((Handler)tipc_named_node_up, n_ptr->addr); |
307 | 304 | ||
308 | /* Syncronize broadcast acks */ | 305 | /* Syncronize broadcast acks */ |
diff --git a/net/tipc/port.c b/net/tipc/port.c index 33d0b3b7175f..8bacd572a9fb 100644 --- a/net/tipc/port.c +++ b/net/tipc/port.c | |||
@@ -188,7 +188,6 @@ void tipc_port_recv_mcast(struct sk_buff *buf, struct port_list *dp) | |||
188 | 188 | ||
189 | if (b == NULL) { | 189 | if (b == NULL) { |
190 | warn("Unable to deliver multicast message(s)\n"); | 190 | warn("Unable to deliver multicast message(s)\n"); |
191 | msg_dbg(msg, "LOST:"); | ||
192 | goto exit; | 191 | goto exit; |
193 | } | 192 | } |
194 | if ((index == 0) && (cnt != 0)) { | 193 | if ((index == 0) && (cnt != 0)) { |
@@ -280,7 +279,6 @@ int tipc_deleteport(u32 ref) | |||
280 | spin_unlock_bh(&tipc_port_list_lock); | 279 | spin_unlock_bh(&tipc_port_list_lock); |
281 | k_term_timer(&p_ptr->timer); | 280 | k_term_timer(&p_ptr->timer); |
282 | kfree(p_ptr); | 281 | kfree(p_ptr); |
283 | dbg("Deleted port %u\n", ref); | ||
284 | tipc_net_route_msg(buf); | 282 | tipc_net_route_msg(buf); |
285 | return 0; | 283 | return 0; |
286 | } | 284 | } |
@@ -366,7 +364,6 @@ static struct sk_buff *port_build_proto_msg(u32 destport, u32 destnode, | |||
366 | msg_set_orignode(msg, orignode); | 364 | msg_set_orignode(msg, orignode); |
367 | msg_set_transp_seqno(msg, seqno); | 365 | msg_set_transp_seqno(msg, seqno); |
368 | msg_set_msgcnt(msg, ack); | 366 | msg_set_msgcnt(msg, ack); |
369 | msg_dbg(msg, "PORT>SEND>:"); | ||
370 | } | 367 | } |
371 | return buf; | 368 | return buf; |
372 | } | 369 | } |
@@ -384,7 +381,6 @@ int tipc_reject_msg(struct sk_buff *buf, u32 err) | |||
384 | data_sz = MAX_REJECT_SIZE; | 381 | data_sz = MAX_REJECT_SIZE; |
385 | if (msg_connected(msg) && (imp < TIPC_CRITICAL_IMPORTANCE)) | 382 | if (msg_connected(msg) && (imp < TIPC_CRITICAL_IMPORTANCE)) |
386 | imp++; | 383 | imp++; |
387 | msg_dbg(msg, "port->rej: "); | ||
388 | 384 | ||
389 | /* discard rejected message if it shouldn't be returned to sender */ | 385 | /* discard rejected message if it shouldn't be returned to sender */ |
390 | if (msg_errcode(msg) || msg_dest_droppable(msg)) { | 386 | if (msg_errcode(msg) || msg_dest_droppable(msg)) { |
@@ -547,8 +543,6 @@ void tipc_port_recv_proto_msg(struct sk_buff *buf) | |||
547 | struct sk_buff *r_buf = NULL; | 543 | struct sk_buff *r_buf = NULL; |
548 | struct sk_buff *abort_buf = NULL; | 544 | struct sk_buff *abort_buf = NULL; |
549 | 545 | ||
550 | msg_dbg(msg, "PORT<RECV<:"); | ||
551 | |||
552 | if (!p_ptr) { | 546 | if (!p_ptr) { |
553 | err = TIPC_ERR_NO_PORT; | 547 | err = TIPC_ERR_NO_PORT; |
554 | } else if (p_ptr->publ.connected) { | 548 | } else if (p_ptr->publ.connected) { |
@@ -1015,9 +1009,6 @@ int tipc_publish(u32 ref, unsigned int scope, struct tipc_name_seq const *seq) | |||
1015 | if (!p_ptr) | 1009 | if (!p_ptr) |
1016 | return -EINVAL; | 1010 | return -EINVAL; |
1017 | 1011 | ||
1018 | dbg("tipc_publ %u, p_ptr = %x, conn = %x, scope = %x, " | ||
1019 | "lower = %u, upper = %u\n", | ||
1020 | ref, p_ptr, p_ptr->publ.connected, scope, seq->lower, seq->upper); | ||
1021 | if (p_ptr->publ.connected) | 1012 | if (p_ptr->publ.connected) |
1022 | goto exit; | 1013 | goto exit; |
1023 | if (seq->lower > seq->upper) | 1014 | if (seq->lower > seq->upper) |
@@ -1357,7 +1348,6 @@ int tipc_send_buf2port(u32 ref, struct tipc_portid const *dest, | |||
1357 | 1348 | ||
1358 | skb_push(buf, DIR_MSG_H_SIZE); | 1349 | skb_push(buf, DIR_MSG_H_SIZE); |
1359 | skb_copy_to_linear_data(buf, msg, DIR_MSG_H_SIZE); | 1350 | skb_copy_to_linear_data(buf, msg, DIR_MSG_H_SIZE); |
1360 | msg_dbg(msg, "buf2port: "); | ||
1361 | p_ptr->sent++; | 1351 | p_ptr->sent++; |
1362 | if (dest->node == tipc_own_addr) | 1352 | if (dest->node == tipc_own_addr) |
1363 | return tipc_port_recv_msg(buf); | 1353 | return tipc_port_recv_msg(buf); |
diff --git a/net/tipc/port.h b/net/tipc/port.h index da607a8a2f35..a9c528799f2f 100644 --- a/net/tipc/port.h +++ b/net/tipc/port.h | |||
@@ -316,7 +316,6 @@ static inline int tipc_port_recv_msg(struct sk_buff *buf) | |||
316 | err = TIPC_ERR_NO_PORT; | 316 | err = TIPC_ERR_NO_PORT; |
317 | } | 317 | } |
318 | reject: | 318 | reject: |
319 | dbg("port->rejecting, err = %x..\n",err); | ||
320 | return tipc_reject_msg(buf, err); | 319 | return tipc_reject_msg(buf, err); |
321 | } | 320 | } |
322 | 321 | ||
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index cd0bb77f2673..7a21a5ee43e8 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c | |||
@@ -1226,42 +1226,25 @@ static u32 filter_rcv(struct sock *sk, struct sk_buff *buf) | |||
1226 | */ | 1226 | */ |
1227 | 1227 | ||
1228 | if (sock->state == SS_READY) { | 1228 | if (sock->state == SS_READY) { |
1229 | if (msg_connected(msg)) { | 1229 | if (msg_connected(msg)) |
1230 | msg_dbg(msg, "dispatch filter 1\n"); | ||
1231 | return TIPC_ERR_NO_PORT; | 1230 | return TIPC_ERR_NO_PORT; |
1232 | } | ||
1233 | } else { | 1231 | } else { |
1234 | if (msg_mcast(msg)) { | 1232 | if (msg_mcast(msg)) |
1235 | msg_dbg(msg, "dispatch filter 2\n"); | ||
1236 | return TIPC_ERR_NO_PORT; | 1233 | return TIPC_ERR_NO_PORT; |
1237 | } | ||
1238 | if (sock->state == SS_CONNECTED) { | 1234 | if (sock->state == SS_CONNECTED) { |
1239 | if (!msg_connected(msg)) { | 1235 | if (!msg_connected(msg)) |
1240 | msg_dbg(msg, "dispatch filter 3\n"); | ||
1241 | return TIPC_ERR_NO_PORT; | 1236 | return TIPC_ERR_NO_PORT; |
1242 | } | 1237 | } else if (sock->state == SS_CONNECTING) { |
1243 | } | 1238 | if (!msg_connected(msg) && (msg_errcode(msg) == 0)) |
1244 | else if (sock->state == SS_CONNECTING) { | ||
1245 | if (!msg_connected(msg) && (msg_errcode(msg) == 0)) { | ||
1246 | msg_dbg(msg, "dispatch filter 4\n"); | ||
1247 | return TIPC_ERR_NO_PORT; | 1239 | return TIPC_ERR_NO_PORT; |
1248 | } | 1240 | } else if (sock->state == SS_LISTENING) { |
1249 | } | 1241 | if (msg_connected(msg) || msg_errcode(msg)) |
1250 | else if (sock->state == SS_LISTENING) { | ||
1251 | if (msg_connected(msg) || msg_errcode(msg)) { | ||
1252 | msg_dbg(msg, "dispatch filter 5\n"); | ||
1253 | return TIPC_ERR_NO_PORT; | 1242 | return TIPC_ERR_NO_PORT; |
1254 | } | 1243 | } else if (sock->state == SS_DISCONNECTING) { |
1255 | } | ||
1256 | else if (sock->state == SS_DISCONNECTING) { | ||
1257 | msg_dbg(msg, "dispatch filter 6\n"); | ||
1258 | return TIPC_ERR_NO_PORT; | 1244 | return TIPC_ERR_NO_PORT; |
1259 | } | 1245 | } else /* (sock->state == SS_UNCONNECTED) */ { |
1260 | else /* (sock->state == SS_UNCONNECTED) */ { | 1246 | if (msg_connected(msg) || msg_errcode(msg)) |
1261 | if (msg_connected(msg) || msg_errcode(msg)) { | ||
1262 | msg_dbg(msg, "dispatch filter 7\n"); | ||
1263 | return TIPC_ERR_NO_PORT; | 1247 | return TIPC_ERR_NO_PORT; |
1264 | } | ||
1265 | } | 1248 | } |
1266 | } | 1249 | } |
1267 | 1250 | ||
@@ -1280,7 +1263,6 @@ static u32 filter_rcv(struct sock *sk, struct sk_buff *buf) | |||
1280 | 1263 | ||
1281 | /* Enqueue message (finally!) */ | 1264 | /* Enqueue message (finally!) */ |
1282 | 1265 | ||
1283 | msg_dbg(msg, "<DISP<: "); | ||
1284 | TIPC_SKB_CB(buf)->handle = msg_data(msg); | 1266 | TIPC_SKB_CB(buf)->handle = msg_data(msg); |
1285 | atomic_inc(&tipc_queue_size); | 1267 | atomic_inc(&tipc_queue_size); |
1286 | __skb_queue_tail(&sk->sk_receive_queue, buf); | 1268 | __skb_queue_tail(&sk->sk_receive_queue, buf); |
@@ -1588,7 +1570,6 @@ static int accept(struct socket *sock, struct socket *new_sock, int flags) | |||
1588 | * Respond to 'SYN+' by queuing it on new socket. | 1570 | * Respond to 'SYN+' by queuing it on new socket. |
1589 | */ | 1571 | */ |
1590 | 1572 | ||
1591 | msg_dbg(msg,"<ACC<: "); | ||
1592 | if (!msg_data_sz(msg)) { | 1573 | if (!msg_data_sz(msg)) { |
1593 | struct msghdr m = {NULL,}; | 1574 | struct msghdr m = {NULL,}; |
1594 | 1575 | ||
diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c index c5ba323dba47..510271152165 100644 --- a/net/tipc/subscr.c +++ b/net/tipc/subscr.c | |||
@@ -249,8 +249,6 @@ static void subscr_terminate(struct subscriber *subscriber) | |||
249 | k_cancel_timer(&sub->timer); | 249 | k_cancel_timer(&sub->timer); |
250 | k_term_timer(&sub->timer); | 250 | k_term_timer(&sub->timer); |
251 | } | 251 | } |
252 | dbg("Term: Removing sub %u,%u,%u from subscriber %x list\n", | ||
253 | sub->seq.type, sub->seq.lower, sub->seq.upper, subscriber); | ||
254 | subscr_del(sub); | 252 | subscr_del(sub); |
255 | } | 253 | } |
256 | 254 | ||
@@ -307,8 +305,6 @@ static void subscr_cancel(struct tipc_subscr *s, | |||
307 | k_term_timer(&sub->timer); | 305 | k_term_timer(&sub->timer); |
308 | spin_lock_bh(subscriber->lock); | 306 | spin_lock_bh(subscriber->lock); |
309 | } | 307 | } |
310 | dbg("Cancel: removing sub %u,%u,%u from subscriber %x list\n", | ||
311 | sub->seq.type, sub->seq.lower, sub->seq.upper, subscriber); | ||
312 | subscr_del(sub); | 308 | subscr_del(sub); |
313 | } | 309 | } |
314 | 310 | ||