aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhao Yakui <yakui.zhao@intel.com>2014-04-16 22:37:36 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-05-05 03:08:44 -0400
commitb1a93306ed2686a7064ed54f99203b6db852ca27 (patch)
tree3f572cc008c20b6bb9ab0d43a47b631aaec0e9f6
parentfd3c269f8ff940cc0fbb3b7f7e84c0572f6f759a (diff)
drm/i915: Update the restrict check to filter out wrong Ring ID passed by user-space
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/i915/i915_gem_execbuffer.c2
-rw-r--r--drivers/gpu/drm/i915/intel_ringbuffer.h1
2 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index b9dcc2869edc..0aa1b4cb1f6d 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -1037,7 +1037,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
1037 if (args->flags & I915_EXEC_IS_PINNED) 1037 if (args->flags & I915_EXEC_IS_PINNED)
1038 flags |= I915_DISPATCH_PINNED; 1038 flags |= I915_DISPATCH_PINNED;
1039 1039
1040 if ((args->flags & I915_EXEC_RING_MASK) > I915_NUM_RINGS) { 1040 if ((args->flags & I915_EXEC_RING_MASK) > LAST_USER_RING) {
1041 DRM_DEBUG("execbuf with unknown ring: %d\n", 1041 DRM_DEBUG("execbuf with unknown ring: %d\n",
1042 (int)(args->flags & I915_EXEC_RING_MASK)); 1042 (int)(args->flags & I915_EXEC_RING_MASK));
1043 return -EINVAL; 1043 return -EINVAL;
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
index 54839165eb6d..7c0eb33d5027 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.h
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
@@ -63,6 +63,7 @@ struct intel_ring_buffer {
63 VECS, 63 VECS,
64 } id; 64 } id;
65#define I915_NUM_RINGS 4 65#define I915_NUM_RINGS 4
66#define LAST_USER_RING (VECS + 1)
66 u32 mmio_base; 67 u32 mmio_base;
67 void __iomem *virtual_start; 68 void __iomem *virtual_start;
68 struct drm_device *dev; 69 struct drm_device *dev;